ddtrace/tracer: add support for agent discovery endpoint, feature flags, stats & drops #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
force-pushed
the
gbbr/discovery
branch
2 times, most recently
from
546b793
to
64a53f0
Compare
|
Don't you need to implement both obfuscation and metrics as a prerequisite of this change? |
gbbr
force-pushed
the
gbbr/discovery
branch
3 times, most recently
from
ba120e6
to
c91a8af
Compare
gbbr
force-pushed
the
gbbr/discovery
branch
2 times, most recently
from
f5d3f01
to
59f6055
Compare
gbbr
commented
Mar 16, 2021
|
@richardstartin I think I got it now. Won't be doing obfuscation though. At least not at this point... |
gbbr
force-pushed
the
gbbr/discovery
branch
5 times, most recently
from
b3095d5
to
63c16b6
Compare
gbbr
force-pushed
the
gbbr/discovery
branch
4 times, most recently
from
a5d6c4c
to
ce324c7
Compare
gbbr
force-pushed
the
gbbr/discovery
branch
4 times, most recently
from
45173c8
to
4be4428
Compare
gbbr
force-pushed
the
gbbr/discovery
branch
3 times, most recently
from
d7baedd
to
d95e0ce
Compare
gbbr
changed the title
piochelepiotr
previously approved these changes
Apr 27, 2021
| // This product includes software developed at Datadog (https://www.datadoghq.com/). | ||
| // Copyright 2016 Datadog, Inc. | ||
|
|
||
| //go:generate msgp -unexported -marshal=false -o=stats_msgp.go -tests=false |
There was a problem hiding this comment.
I believe we don't use msgp on this file right?
| } | ||
|
|
||
| // nsTimestampToFloat converts a nanosec timestamp into a float nanosecond timestamp truncated to a fixed precision | ||
| func nsTimestampToFloat(ns int64) float64 { |
There was a problem hiding this comment.
why not divide by 1024 and multiply again?
Division by power of two should be really efficient.
There was a problem hiding this comment.
I copied this from the agent. I don't know what you mean. You'd have to spell (code) it out 🙂
| if err != nil { | ||
| return err | ||
| } | ||
| resp, err := t.client.Do(req) |
There was a problem hiding this comment.
do we want to add retries here?
There was a problem hiding this comment.
Maybe? Might be a good idea. If we do, we should do it in a separate PR for both traces and stats. We currently don't have it for traces either.
raphaelgavache
previously approved these changes
Apr 27, 2021
raphaelgavache
approved these changes
Apr 28, 2021
nicoledanuwidjaja
pushed a commit
that referenced
this pull request
May 5, 2021
…gs, stats & drops (#859) This change adds a multitude of new features, such as support for feature flags, agent discovery, client-side stats computations and enabling the dropping of P0 traces in the client. ### Feature flags Support for feature flags by means of: * `WithFeatureFlags` tracer start option. * `DD_TRACE_FEATURES` environment variable which takes a list of comma or space separated flag tokens. ### Agent discovery When the feature flag `discovery` is set, support for detecting features by means of the new agent (7.27.0) discovery endpoint added in DataDog/datadog-agent#7344 and DataDog/datadog-agent#7495 becomes enabled. ### Client-computed stats and dropping p0's When `discovery` is enabled, if the agent supports client-computed stats and dropping p0's in the client, the tracer can now do this by means of the newly added concentrator and drop logic. ### TODO * Obfuscation is not yet supported in the client but will be added in a subsequent PR by factoring out the obfuscator code from the agent into a separate package to be shared with this module.
stlimtat
pushed a commit
to stlimtat/dd-trace-go
that referenced
this pull request
May 17, 2021
* 'v1' of https://github.com/DataDog/dd-trace-go: Implement DD_PROFILING_OUTPUT_DIR for dev/debug (DataDog#924) contrib/go-pg/pg.v10: add INTEGRATION flag check for tests (DataDog#921) contrib/go-redis/redis.v8: optimize BeforeProcess and BeforeProcessPipeline (DataDog#920) CI: check go.sum is up-to-date (DataDog#918) README: Fix go get instructions (DataDog#913) internal/log: Improve API for testing (DataDog#916) ddtrace/tracer: add support for agent discovery endpoint, feature flags, stats & drops (DataDog#859) internal/version: bump to v1.31.0 (DataDog#910) CONTRIBUTING.md: add link to contrib/README.md (DataDog#802) profiler: Disable agentless mode for WithAPIKey (DataDog#906) contrib/Shopify/sarama: fix possible deadlock in WrapAsyncProducer (DataDog#907) contrib/database/sql.tracedConn implement driver.SessionResetter (DataDog#908) ddtrace/opentracer: consider FollowsFrom references as children (DataDog#905) ddtrace/opentracer: add support for opentracing.TracerContextWithSpanExtension (DataDog#855) ddtrace/tracer: follow noDebugStack setting when using SetTag with an error (DataDog#900) contrib/net/http: add a getter to retrieve original round tripper (DataDog#903) ddtrace/tracer: ensure Flush call is synchronous (DataDog#901)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a multitude of new features, such as support for feature flags, agent discovery, client-side stats computations and enabling the dropping of P0 traces in the client.
Feature flags
Support for feature flags by means of:
WithFeatureFlagstracer start option.DD_TRACE_FEATURESenvironment variable which takes a list of comma or space separated flag tokens.Agent discovery
When the feature flag
discoveryis set, support for detecting features by means of the new agent (7.27.0) discovery endpoint added in DataDog/datadog-agent#7344 and DataDog/datadog-agent#7495 becomes enabled.Client-computed stats and dropping p0's
When
discoveryis enabled, if the agent supports client-computed stats and dropping p0's in the client, the tracer can now do this by means of the newly added concentrator and drop logic.TODO