ddtrace/tracer: add noDebugStack to config when setting error tags #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoledanuwidjaja
force-pushed
the
nicoledanuwidjaja/fix-set-tag-error
branch
from
ca4ae0b
to
7726bb6
Compare
nicoledanuwidjaja
force-pushed
the
nicoledanuwidjaja/fix-set-tag-error
branch
from
7726bb6
to
ce49089
Compare
nicoledanuwidjaja
changed the title
gbbr
reviewed
Apr 13, 2021
nicoledanuwidjaja
force-pushed
the
nicoledanuwidjaja/fix-set-tag-error
branch
5 times, most recently
from
037945f
to
14d8eb8
Compare
gbbr
reviewed
Apr 15, 2021
ddtrace/tracer/span.go
Outdated
| @@ -145,6 +147,7 @@ func (s *span) setTagError(value interface{}, cfg *errorConfig) { | |||
| s.Error = 1 | |||
| s.setMeta(ext.ErrorMsg, v.Error()) | |||
| s.setMeta(ext.ErrorType, reflect.TypeOf(v).String()) | |||
|
|
|||
nicoledanuwidjaja
force-pushed
the
nicoledanuwidjaja/fix-set-tag-error
branch
2 times, most recently
from
c3a6cde
to
8c406ef
Compare
gbbr
reviewed
Apr 15, 2021
nicoledanuwidjaja
force-pushed
the
nicoledanuwidjaja/fix-set-tag-error
branch
from
8c406ef
to
b462c13
Compare
gbbr
approved these changes
Apr 15, 2021
|
You need to rebase on |
stlimtat
pushed a commit
to stlimtat/dd-trace-go
that referenced
this pull request
May 17, 2021
* 'v1' of https://github.com/DataDog/dd-trace-go: Implement DD_PROFILING_OUTPUT_DIR for dev/debug (DataDog#924) contrib/go-pg/pg.v10: add INTEGRATION flag check for tests (DataDog#921) contrib/go-redis/redis.v8: optimize BeforeProcess and BeforeProcessPipeline (DataDog#920) CI: check go.sum is up-to-date (DataDog#918) README: Fix go get instructions (DataDog#913) internal/log: Improve API for testing (DataDog#916) ddtrace/tracer: add support for agent discovery endpoint, feature flags, stats & drops (DataDog#859) internal/version: bump to v1.31.0 (DataDog#910) CONTRIBUTING.md: add link to contrib/README.md (DataDog#802) profiler: Disable agentless mode for WithAPIKey (DataDog#906) contrib/Shopify/sarama: fix possible deadlock in WrapAsyncProducer (DataDog#907) contrib/database/sql.tracedConn implement driver.SessionResetter (DataDog#908) ddtrace/opentracer: consider FollowsFrom references as children (DataDog#905) ddtrace/opentracer: add support for opentracing.TracerContextWithSpanExtension (DataDog#855) ddtrace/tracer: follow noDebugStack setting when using SetTag with an error (DataDog#900) contrib/net/http: add a getter to retrieve original round tripper (DataDog#903) ddtrace/tracer: ensure Flush call is synchronous (DataDog#901)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets
noDebugStackoption inerrorConfigso thatsetTagErroronly adds debug stack traces when this option is set as false. Added tests to check if tags set as errors properly acknowledge thenoDebugStackoption set byWithDebugStack().