Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade integrations-core to 7.49.0 to fix embedded JMX metrics for Tomcat #6206

Closed
michelzanini opened this issue Nov 13, 2023 · 3 comments
Closed

Upgrade integrations-core to 7.49.0 to fix embedded JMX metrics for Tomcat #6206

michelzanini opened this issue Nov 13, 2023 · 3 comments
Assignees
@mcculls
Labels
tag: no release notes Changes to exclude from release notes
Milestone
1.24.0

Comments

@michelzanini
Copy link

This repository has a Git sub-module to integrations core pointing to version 7.47.0.
Can you please point it to the latest 7.49.0 release?

There's a fix I added there to support JMX metrics for Tomcat on Spring Boot (embedded tomcat):

DataDog/integrations-core#15761
See file now:
https://github.com/DataDog/integrations-core/blob/7.49.0/tomcat/datadog_checks/tomcat/data/metrics.yaml

I can create a PR myself in case you want that.

Thanks.
@mcculls mcculls mentioned this issue Nov 13, 2023
Merged
@mcculls mcculls self-assigned this Nov 13, 2023
@mcculls
Copy link
Contributor

mcculls commented Nov 13, 2023

Hi @michelzanini - I've opened #6207 to address this, it will be in the next release (1.24.0)

@mcculls mcculls added this to the 1.24.0 milestone Nov 13, 2023
@michelzanini
Copy link
Author

Thank you!

@nayeem-kamal nayeem-kamal added comp: jmx-fetch JMX fetch tag: no release notes Changes to exclude from release notes and removed comp: jmx-fetch JMX fetch labels Nov 15, 2023
@github-actions GitHub Actions
Copy link
Contributor

🤖 This issue has been addressed in the latest release. See full details in the Release Notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcculls mcculls

Labels
tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
1.24.0
Development

No branches or pull requests
3 participants
@mcculls @michelzanini @nayeem-kamal