Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade bundled metrics integrations to 7.49.0 #6207

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Upgrade bundled metrics integrations to 7.49.0 #6207

merged 1 commit into from
Nov 13, 2023

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Nov 13, 2023

See #6206

@mcculls mcculls added the comp: metrics Metrics label Nov 13, 2023
@mcculls mcculls requested a review from a team as a code owner November 13, 2023 13:12
@mcculls mcculls changed the title Bump integrations-core submodule to 7.49.0 Upgrade bundled metrics integrations to 7.49.0 Nov 13, 2023
@mcculls mcculls mentioned this pull request Nov 13, 2023
Closed
@pr-commenter
Copy link

pr-commenter bot commented Nov 13, 2023

Benchmarks

Startup

Parameters

Baseline Candidate
commit 1.24.0-SNAPSHOT~3fb888b81b 1.24.0-SNAPSHOT~1e066f85e5
config baseline candidate
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 cases.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.24.0-SNAPSHOT~1e066f85e5, baseline=1.24.0-SNAPSHOT~3fb888b81b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1042481
Total [baseline] (8.815 s) : 0, 8815339
Agent [candidate] (1.051 s) : 0, 1050670
Total [candidate] (8.829 s) : 0, 8829426
section iast
Agent [baseline] (1.15 s) : 0, 1150192
Total [baseline] (9.308 s) : 0, 9307660
Agent [candidate] (1.156 s) : 0, 1156247
Total [candidate] (9.376 s) : 0, 9376061
section iast_TELEMETRY_OFF
Agent [baseline] (1.146 s) : 0, 1145683
Total [baseline] (9.316 s) : 0, 9316476
Agent [candidate] (1.146 s) : 0, 1146323
Total [candidate] (9.358 s) : 0, 9358331
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.042 s -
Agent iast 1.15 s 107.711 ms (10.3%)
Agent iast_TELEMETRY_OFF 1.146 s 103.202 ms (9.9%)
Total tracing 8.815 s -
Total iast 9.308 s 492.321 ms (5.6%)
Total iast_TELEMETRY_OFF 9.316 s 501.137 ms (5.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.051 s -
Agent iast 1.156 s 105.577 ms (10.0%)
Agent iast_TELEMETRY_OFF 1.146 s 95.653 ms (9.1%)
Total tracing 8.829 s -
Total iast 9.376 s 546.635 ms (6.2%)
Total iast_TELEMETRY_OFF 9.358 s 528.905 ms (6.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.24.0-SNAPSHOT~1e066f85e5, baseline=1.24.0-SNAPSHOT~3fb888b81b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (650.393 ms) : 0, 650393
BytebuddyAgent [candidate] (655.775 ms) : 0, 655775
GlobalTracer [baseline] (295.916 ms) : 0, 295916
GlobalTracer [candidate] (298.621 ms) : 0, 298621
AppSec [baseline] (49.333 ms) : 0, 49333
AppSec [candidate] (49.252 ms) : 0, 49252
Remote Config [baseline] (702.923 µs) : 0, 703
Remote Config [candidate] (701.048 µs) : 0, 701
Telemetry [baseline] (11.446 ms) : 0, 11446
Telemetry [candidate] (11.513 ms) : 0, 11513
section iast
BytebuddyAgent [baseline] (764.339 ms) : 0, 764339
BytebuddyAgent [candidate] (768.444 ms) : 0, 768444
GlobalTracer [baseline] (274.018 ms) : 0, 274018
GlobalTracer [candidate] (275.701 ms) : 0, 275701
AppSec [baseline] (46.742 ms) : 0, 46742
AppSec [candidate] (46.745 ms) : 0, 46745
IAST [baseline] (16.838 ms) : 0, 16838
IAST [candidate] (17.053 ms) : 0, 17053
Remote Config [baseline] (576.189 µs) : 0, 576
Remote Config [candidate] (579.533 µs) : 0, 580
Telemetry [baseline] (13.354 ms) : 0, 13354
Telemetry [candidate] (13.171 ms) : 0, 13171
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (760.64 ms) : 0, 760640
BytebuddyAgent [candidate] (759.779 ms) : 0, 759779
GlobalTracer [baseline] (274.856 ms) : 0, 274856
GlobalTracer [candidate] (274.528 ms) : 0, 274528
AppSec [baseline] (46.422 ms) : 0, 46422
AppSec [candidate] (46.309 ms) : 0, 46309
IAST [baseline] (16.114 ms) : 0, 16114
IAST [candidate] (17.367 ms) : 0, 17367
Remote Config [baseline] (565.014 µs) : 0, 565
Remote Config [candidate] (569.507 µs) : 0, 570
Telemetry [baseline] (12.594 ms) : 0, 12594
Telemetry [candidate] (13.279 ms) : 0, 13279
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.24.0-SNAPSHOT~1e066f85e5, baseline=1.24.0-SNAPSHOT~3fb888b81b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.036 s) : 0, 1036069
Total [baseline] (9.356 s) : 0, 9355575
Agent [candidate] (1.038 s) : 0, 1037608
Total [candidate] (9.314 s) : 0, 9313920
section appsec
Agent [baseline] (1.122 s) : 0, 1121527
Total [baseline] (9.437 s) : 0, 9437022
Agent [candidate] (1.121 s) : 0, 1121204
Total [candidate] (9.442 s) : 0, 9441792
section iast
Agent [baseline] (1.164 s) : 0, 1163694
Total [baseline] (9.546 s) : 0, 9546212
Agent [candidate] (1.156 s) : 0, 1155696
Total [candidate] (9.523 s) : 0, 9522529
section profiling
Agent [baseline] (1.226 s) : 0, 1225937
Total [baseline] (9.642 s) : 0, 9641514
Agent [candidate] (1.22 s) : 0, 1220181
Total [candidate] (9.56 s) : 0, 9559988
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.036 s -
Agent appsec 1.122 s 85.458 ms (8.2%)
Agent iast 1.164 s 127.626 ms (12.3%)
Agent profiling 1.226 s 189.868 ms (18.3%)
Total tracing 9.356 s -
Total appsec 9.437 s 81.448 ms (0.9%)
Total iast 9.546 s 190.637 ms (2.0%)
Total profiling 9.642 s 285.94 ms (3.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.038 s -
Agent appsec 1.121 s 83.596 ms (8.1%)
Agent iast 1.156 s 118.088 ms (11.4%)
Agent profiling 1.22 s 182.573 ms (17.6%)
Total tracing 9.314 s -
Total appsec 9.442 s 127.872 ms (1.4%)
Total iast 9.523 s 208.609 ms (2.2%)
Total profiling 9.56 s 246.068 ms (2.6%) 
gantt
    title petclinic - break down per module: candidate=1.24.0-SNAPSHOT~1e066f85e5, baseline=1.24.0-SNAPSHOT~3fb888b81b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (645.743 ms) : 0, 645743
BytebuddyAgent [candidate] (647.068 ms) : 0, 647068
GlobalTracer [baseline] (294.789 ms) : 0, 294789
GlobalTracer [candidate] (295.175 ms) : 0, 295175
AppSec [baseline] (49.133 ms) : 0, 49133
AppSec [candidate] (48.875 ms) : 0, 48875
Remote Config [baseline] (687.38 µs) : 0, 687
Remote Config [candidate] (689.306 µs) : 0, 689
Telemetry [baseline] (11.397 ms) : 0, 11397
Telemetry [candidate] (11.286 ms) : 0, 11286
section appsec
BytebuddyAgent [baseline] (646.021 ms) : 0, 646021
BytebuddyAgent [candidate] (645.88 ms) : 0, 645880
GlobalTracer [baseline] (294.316 ms) : 0, 294316
GlobalTracer [candidate] (294.406 ms) : 0, 294406
AppSec [baseline] (139.257 ms) : 0, 139257
AppSec [candidate] (139.015 ms) : 0, 139015
Remote Config [baseline] (644.811 µs) : 0, 645
Remote Config [candidate] (641.449 µs) : 0, 641
Telemetry [baseline] (6.885 ms) : 0, 6885
Telemetry [candidate] (6.865 ms) : 0, 6865
section iast
BytebuddyAgent [baseline] (775.957 ms) : 0, 775957
BytebuddyAgent [candidate] (770.502 ms) : 0, 770502
GlobalTracer [baseline] (275.765 ms) : 0, 275765
GlobalTracer [candidate] (274.514 ms) : 0, 274514
AppSec [baseline] (46.871 ms) : 0, 46871
AppSec [candidate] (46.699 ms) : 0, 46699
IAST [baseline] (17.696 ms) : 0, 17696
IAST [candidate] (16.227 ms) : 0, 16227
Remote Config [baseline] (584.048 µs) : 0, 584
Remote Config [candidate] (577.049 µs) : 0, 577
Telemetry [baseline] (11.888 ms) : 0, 11888
Telemetry [candidate] (12.579 ms) : 0, 12579
section profiling
BytebuddyAgent [baseline] (660.408 ms) : 0, 660408
BytebuddyAgent [candidate] (658.522 ms) : 0, 658522
GlobalTracer [baseline] (360.292 ms) : 0, 360292
GlobalTracer [candidate] (358.36 ms) : 0, 358360
AppSec [baseline] (49.444 ms) : 0, 49444
AppSec [candidate] (49.024 ms) : 0, 49024
Remote Config [baseline] (664.427 µs) : 0, 664
Remote Config [candidate] (647.394 µs) : 0, 647
Telemetry [baseline] (11.427 ms) : 0, 11427
Telemetry [candidate] (11.299 ms) : 0, 11299
ProfilingAgent [baseline] (89.064 ms) : 0, 89064
ProfilingAgent [candidate] (88.116 ms) : 0, 88116
Profiling [baseline] (89.088 ms) : 0, 89088
Profiling [candidate] (88.14 ms) : 0, 88140
Loading

Load

Parameters

Baseline Candidate
commit 1.24.0-SNAPSHOT~3fb888b81b 1.24.0-SNAPSHOT~1e066f85e5
config baseline candidate
end_time 2023-11-13T13:33:45 2023-11-13T13:50:17
start_time 2023-11-13T13:33:32 2023-11-13T13:50:05
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.24.0-SNAPSHOT~1e066f85e5, baseline=1.24.0-SNAPSHOT~3fb888b81b
    dateFormat X
    axisFormat %s
section baseline
no_agent (363.782 µs) : 344, 384
.   : milestone, 364,
iast (461.81 µs) : 441, 483
.   : milestone, 462,
iast_FULL (527.566 µs) : 507, 548
.   : milestone, 528,
iast_INACTIVE (442.047 µs) : 421, 463
.   : milestone, 442,
iast_TELEMETRY_OFF (465.793 µs) : 445, 487
.   : milestone, 466,
tracing (437.104 µs) : 416, 458
.   : milestone, 437,
section candidate
no_agent (367.983 µs) : 347, 389
.   : milestone, 368,
iast (461.429 µs) : 441, 482
.   : milestone, 461,
iast_FULL (532.186 µs) : 512, 553
.   : milestone, 532,
iast_INACTIVE (439.72 µs) : 419, 461
.   : milestone, 440,
iast_TELEMETRY_OFF (463.169 µs) : 442, 484
.   : milestone, 463,
tracing (437.836 µs) : 417, 458
.   : milestone, 438,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.782 µs [343.97 µs, 383.595 µs] -
iast 461.81 µs [440.68 µs, 482.941 µs] 98.028 µs (26.9%)
iast_FULL 527.566 µs [506.802 µs, 548.331 µs] 163.784 µs (45.0%)
iast_INACTIVE 442.047 µs [421.207 µs, 462.888 µs] 78.265 µs (21.5%)
iast_TELEMETRY_OFF 465.793 µs [444.867 µs, 486.719 µs] 102.011 µs (28.0%)
tracing 437.104 µs [416.069 µs, 458.138 µs] 73.321 µs (20.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.983 µs [347.454 µs, 388.512 µs] -
iast 461.429 µs [440.731 µs, 482.128 µs] 93.446 µs (25.4%)
iast_FULL 532.186 µs [511.739 µs, 552.633 µs] 164.203 µs (44.6%)
iast_INACTIVE 439.72 µs [418.534 µs, 460.906 µs] 71.737 µs (19.5%)
iast_TELEMETRY_OFF 463.169 µs [442.335 µs, 484.002 µs] 95.186 µs (25.9%)
tracing 437.836 µs [417.294 µs, 458.379 µs] 69.853 µs (19.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.24.0-SNAPSHOT~1e066f85e5, baseline=1.24.0-SNAPSHOT~3fb888b81b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.361 ms) : 1342, 1380
.   : milestone, 1361,
appsec (1.73 ms) : 1706, 1755
.   : milestone, 1730,
iast (1.505 ms) : 1481, 1529
.   : milestone, 1505,
profiling (1.496 ms) : 1469, 1523
.   : milestone, 1496,
tracing (1.45 ms) : 1426, 1475
.   : milestone, 1450,
section candidate
no_agent (1.338 ms) : 1318, 1358
.   : milestone, 1338,
appsec (1.724 ms) : 1698, 1749
.   : milestone, 1724,
iast (1.463 ms) : 1439, 1487
.   : milestone, 1463,
profiling (1.49 ms) : 1463, 1516
.   : milestone, 1490,
tracing (1.47 ms) : 1444, 1495
.   : milestone, 1470,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.361 ms [1.342 ms, 1.38 ms] -
appsec 1.73 ms [1.706 ms, 1.755 ms] 369.522 µs (27.2%)
iast 1.505 ms [1.481 ms, 1.529 ms] 143.817 µs (10.6%)
profiling 1.496 ms [1.469 ms, 1.523 ms] 135.525 µs (10.0%)
tracing 1.45 ms [1.426 ms, 1.475 ms] 89.649 µs (6.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.338 ms [1.318 ms, 1.358 ms] -
appsec 1.724 ms [1.698 ms, 1.749 ms] 385.461 µs (28.8%)
iast 1.463 ms [1.439 ms, 1.487 ms] 124.95 µs (9.3%)
profiling 1.49 ms [1.463 ms, 1.516 ms] 151.613 µs (11.3%)
tracing 1.47 ms [1.444 ms, 1.495 ms] 131.694 µs (9.8%)

@mcculls mcculls merged commit 00f2671 into master Nov 13, 2023
69 of 71 checks passed
@mcculls mcculls deleted the mcculls/integrations-core-7.49.0 branch November 13, 2023 22:42
@github-actions github-actions bot added this to the 1.24.0 milestone Nov 13, 2023
jandro996 pushed a commit that referenced this pull request Nov 14, 2023
@mcculls @jandro996
Bump integrations-core submodule to 7.49.0 (#6207)
daefe58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nayeem-kamal nayeem-kamal nayeem-kamal approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: metrics Metrics
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcculls @nayeem-kamal