Add priorities to resource names #3085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bantonsson
reviewed
Sep 22, 2021
...rap/src/main/java/datadog/trace/bootstrap/instrumentation/decorator/HttpServerDecorator.java
Outdated
Show resolved
Hide resolved
bantonsson
reviewed
Sep 22, 2021
devinsba
force-pushed
the
bds/path-matcher-highest-precedent
branch
5 times, most recently
from
bb1bacc
to
031bdd2
Compare
devinsba
force-pushed
the
bds/path-matcher-highest-precedent
branch
9 times, most recently
from
2799a8f
to
f905b64
Compare
devinsba
commented
Oct 4, 2021
| @@ -151,6 +167,7 @@ class VertxHttpServerForkedTest extends HttpServerTest<Vertx> { | |||
| } | |||
| } | |||
|
|
|||
| @Ignore("Route matching doesn't work with a handler before the controller") | |||
There was a problem hiding this comment.
This is a problem that seems to have already existed. It's going to require a large rework of the instrumentation in order to fix it. Essentially what happens is that every handler added to the router is instrumented, including things like auth handlers, which will usually have a mapping like /* or null but the way we have the instrumentation written only the first handler will evaluate the path as a route. In the case of this test the path is null because of router.route().handler(VertxChainingTestServer::firstHandler);
devinsba
force-pushed
the
bds/path-matcher-highest-precedent
branch
from
f905b64
to
db76665
Compare
devinsba
changed the title
devinsba
force-pushed
the
bds/path-matcher-highest-precedent
branch
from
db76665
to
e9e1ba4
Compare
charliegracie
approved these changes
Oct 7, 2021
bantonsson
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for resource name "types" to take precedence without having to worry about write order