Refactor BeanFactory advice so we can repair other injected bean definitions #4543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
changed the title
mcculls
force-pushed
the
mcculls/reuse-spring-bean-definition-repair
branch
2 times, most recently
from
d4c04e1
to
a1b744c
Compare
mcculls
force-pushed
the
mcculls/reuse-spring-bean-definition-repair
branch
from
a1b744c
to
6b077ca
Compare
amarziali
force-pushed
the
mcculls/reuse-spring-bean-definition-repair
branch
from
e32d494
to
934a1aa
Compare
amarziali
reviewed
Jan 16, 2023
...webmvc-3.1/src/main/java/datadog/trace/instrumentation/springweb/BeanDefinitionRepairer.java
Outdated
Show resolved
Hide resolved
mcculls
added
inst: others
mcculls
changed the title
amarziali
approved these changes
Jan 16, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Introduces
BeanDefinitionRepairerto help make the existing bean definition repair approach more re-usable. Bean definitions registered by the tracer now just have to register their classes withBeanDefinitionRepairerand these will be re-applied to bean definitions with matching names, even if the original bean class has been lost, for example due to the definition being cloned.Additional Notes
Includes a new smoke test to verify that bean definition repair works for both old and new spring-webmvc definitions.
Solves #4537