Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove debugger check for config endpoint at bootstrap #4657

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

shatzi
Copy link
Contributor

@shatzi shatzi commented Feb 4, 2023

What Does This Do

remove disabling the DebugerAgent if datadog agent config was not found at boot time.
Unlike other endpoints, configEndpoint get attached after datadog agent remote config client started.

The solution is to remove this check and let configurationPoller discovery that endpoint at later point in time.

Motivation

Our customer have setup that start both library and datadog-agent almost at the same time.
That causes DebuggerAgent to cancel it boot sequence because config endpoint was not found.
On the other hand, ASM products doesn't check for config endpoint and register itself.
Therefore, configurationPoller retried agent discovery until it find the configEndpoint and start getting configurations.

Additional Notes

We might also want to disable the check for debuggerProxy endpoint. And we should delay this discovery until we get a snapshot to send and drop the snapshot buffer if no endpoint was discovered.

@shatzi shatzi requested a review from a team as a code owner February 4, 2023 03:46
@shatzi shatzi requested review from jpbempel and removed request for a team February 4, 2023 03:46
@shatzi shatzi changed the title remove debugger check for config endpoint at bootstrart remove debugger check for config endpoint at bootstrap Feb 4, 2023
Copy link
Member

@jpbempel jpbempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes makes sense 👍 .
Before we were handling completely the access to RemoteConfig

@smola smola added the comp: debugger Dynamic Instrumentation label Feb 4, 2023
@shatzi shatzi merged commit 1f6f4df into master Feb 4, 2023
@shatzi shatzi deleted the shatzi/resolve-bootstrap-race-with-agent branch February 4, 2023 16:33
@github-actions github-actions bot added this to the 1.7.0 milestone Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: debugger Dynamic Instrumentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants