Add support for DD_TRACE_AGENT_PORT setting #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realark
approved these changes
Nov 16, 2018
Makes this more consistent with other apm language clients.
tylerbenson
force-pushed
the
tyler/env-config
branch
from
42e4b9c
to
93c046a
Compare
tylerbenson
commented
Nov 16, 2018
| overridePort | overrideLegacyPort | expectedPort | ||
| true | true | 123 | ||
| true | false | 123 | ||
| false | true | 777 // env var gets picked up instead. |
There was a problem hiding this comment.
This line highlights the following precedence:
sys prop > env var > legacy sys prop > legacy env var
mar-kolya
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes this more consistent with other apm language clients.