Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIT-8165] Add DSM API changes to support kinesis use case #6001

Merged
merged 1 commit into from
Oct 6, 2023
Merged

[AIT-8165] Add DSM API changes to support kinesis use case #6001

merged 1 commit into from
Oct 6, 2023
+35 −7

Conversation

devinsba
Copy link
Contributor

@devinsba devinsba commented Oct 6, 2023 •
edited
Loading

What Does This Do

Revised #5982 to include only the NoOp context carrier, and move interface methods to make them accessible from instrumentation. The consume method did not work as expected

Motivation

Additional Notes

@devinsba devinsba marked this pull request as ready for review October 6, 2023 15:05
@devinsba devinsba requested a review from a team as a code owner October 6, 2023 15:05
@pr-commenter
Copy link

pr-commenter bot commented Oct 6, 2023 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
commit 1.22.0-SNAPSHOT~d0fd364355 1.22.0-SNAPSHOT~be0de70d4d
config baseline candidate
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
module Agent Agent
parent None None
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 cases.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.22.0-SNAPSHOT~be0de70d4d, baseline=1.22.0-SNAPSHOT~d0fd364355

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.012 s) : 0, 1011545
Total [baseline] (9.226 s) : 0, 9226013
Agent [candidate] (1.014 s) : 0, 1013644
Total [candidate] (9.235 s) : 0, 9234719
section appsec
Agent [baseline] (1.1 s) : 0, 1100490
Total [baseline] (9.241 s) : 0, 9241421
Agent [candidate] (1.103 s) : 0, 1103007
Total [candidate] (9.283 s) : 0, 9283336
section iast
Agent [baseline] (1.123 s) : 0, 1123278
Total [baseline] (9.44 s) : 0, 9440097
Agent [candidate] (1.124 s) : 0, 1124222
Total [candidate] (9.453 s) : 0, 9452864
section profiling
Agent [baseline] (1.184 s) : 0, 1183846
Total [baseline] (9.434 s) : 0, 9433967
Agent [candidate] (1.192 s) : 0, 1191818
Total [candidate] (9.479 s) : 0, 9478693
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.012 s -
Agent appsec 1.1 s 88.946 ms (8.8%)
Agent iast 1.123 s 111.733 ms (11.0%)
Agent profiling 1.184 s 172.301 ms (17.0%)
Total tracing 9.226 s -
Total appsec 9.241 s 15.408 ms (0.2%)
Total iast 9.44 s 214.084 ms (2.3%)
Total profiling 9.434 s 207.954 ms (2.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.014 s -
Agent appsec 1.103 s 89.363 ms (8.8%)
Agent iast 1.124 s 110.578 ms (10.9%)
Agent profiling 1.192 s 178.173 ms (17.6%)
Total tracing 9.235 s -
Total appsec 9.283 s 48.617 ms (0.5%)
Total iast 9.453 s 218.145 ms (2.4%)
Total profiling 9.479 s 243.974 ms (2.6%) 
gantt
    title petclinic - break down per module: candidate=1.22.0-SNAPSHOT~be0de70d4d, baseline=1.22.0-SNAPSHOT~d0fd364355

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (630.056 ms) : 0, 630056
BytebuddyAgent [candidate] (630.409 ms) : 0, 630409
GlobalTracer [baseline] (291.525 ms) : 0, 291525
GlobalTracer [candidate] (293.092 ms) : 0, 293092
AppSec [baseline] (49.046 ms) : 0, 49046
AppSec [candidate] (49.025 ms) : 0, 49025
Remote Config [baseline] (660.225 µs) : 0, 660
Remote Config [candidate] (665.998 µs) : 0, 666
Telemetry [baseline] (5.961 ms) : 0, 5961
Telemetry [candidate] (6.048 ms) : 0, 6048
section appsec
BytebuddyAgent [baseline] (630.086 ms) : 0, 630086
BytebuddyAgent [candidate] (631.718 ms) : 0, 631718
GlobalTracer [baseline] (292.089 ms) : 0, 292089
GlobalTracer [candidate] (292.848 ms) : 0, 292848
AppSec [baseline] (137.755 ms) : 0, 137755
AppSec [candidate] (137.763 ms) : 0, 137763
Remote Config [baseline] (651.469 µs) : 0, 651
Remote Config [candidate] (652.063 µs) : 0, 652
Telemetry [baseline] (5.717 ms) : 0, 5717
Telemetry [candidate] (5.715 ms) : 0, 5715
section iast
BytebuddyAgent [baseline] (744.707 ms) : 0, 744707
BytebuddyAgent [candidate] (744.948 ms) : 0, 744948
GlobalTracer [baseline] (277.083 ms) : 0, 277083
GlobalTracer [candidate] (277.805 ms) : 0, 277805
AppSec [baseline] (46.523 ms) : 0, 46523
AppSec [candidate] (46.426 ms) : 0, 46426
Remote Config [baseline] (556.552 µs) : 0, 557
Remote Config [candidate] (565.655 µs) : 0, 566
Telemetry [baseline] (5.724 ms) : 0, 5724
Telemetry [candidate] (5.733 ms) : 0, 5733
IAST [baseline] (14.266 ms) : 0, 14266
IAST [candidate] (14.413 ms) : 0, 14413
section profiling
BytebuddyAgent [baseline] (641.319 ms) : 0, 641319
BytebuddyAgent [candidate] (645.984 ms) : 0, 645984
GlobalTracer [baseline] (353.189 ms) : 0, 353189
GlobalTracer [candidate] (355.015 ms) : 0, 355015
AppSec [baseline] (49.31 ms) : 0, 49310
AppSec [candidate] (49.48 ms) : 0, 49480
Remote Config [baseline] (646.417 µs) : 0, 646
Remote Config [candidate] (659.679 µs) : 0, 660
Telemetry [baseline] (6.113 ms) : 0, 6113
Telemetry [candidate] (6.162 ms) : 0, 6162
ProfilingAgent [baseline] (80.157 ms) : 0, 80157
ProfilingAgent [candidate] (80.882 ms) : 0, 80882
Profiling [baseline] (80.181 ms) : 0, 80181
Profiling [candidate] (80.906 ms) : 0, 80906
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.22.0-SNAPSHOT~be0de70d4d, baseline=1.22.0-SNAPSHOT~d0fd364355

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.023 s) : 0, 1023269
Total [baseline] (8.7 s) : 0, 8699669
Agent [candidate] (1.014 s) : 0, 1014070
Total [candidate] (8.653 s) : 0, 8652894
section appsec
Agent [baseline] (1.107 s) : 0, 1106819
Total [baseline] (8.81 s) : 0, 8810004
Agent [candidate] (1.11 s) : 0, 1110394
Total [candidate] (8.741 s) : 0, 8740680
section iast
Agent [baseline] (1.123 s) : 0, 1123303
Total [baseline] (9.2 s) : 0, 9199943
Agent [candidate] (1.126 s) : 0, 1125777
Total [candidate] (9.299 s) : 0, 9299101
section profiling
Agent [baseline] (1.184 s) : 0, 1184438
Total [baseline] (8.876 s) : 0, 8875686
Agent [candidate] (1.192 s) : 0, 1191543
Total [candidate] (8.926 s) : 0, 8926253
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.023 s -
Agent appsec 1.107 s 83.55 ms (8.2%)
Agent iast 1.123 s 100.034 ms (9.8%)
Agent profiling 1.184 s 161.169 ms (15.8%)
Total tracing 8.7 s -
Total appsec 8.81 s 110.335 ms (1.3%)
Total iast 9.2 s 500.274 ms (5.8%)
Total profiling 8.876 s 176.017 ms (2.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.014 s -
Agent appsec 1.11 s 96.324 ms (9.5%)
Agent iast 1.126 s 111.707 ms (11.0%)
Agent profiling 1.192 s 177.473 ms (17.5%)
Total tracing 8.653 s -
Total appsec 8.741 s 87.786 ms (1.0%)
Total iast 9.299 s 646.206 ms (7.5%)
Total profiling 8.926 s 273.359 ms (3.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.22.0-SNAPSHOT~be0de70d4d, baseline=1.22.0-SNAPSHOT~d0fd364355

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (638.311 ms) : 0, 638311
BytebuddyAgent [candidate] (630.536 ms) : 0, 630536
GlobalTracer [baseline] (294.475 ms) : 0, 294475
GlobalTracer [candidate] (293.31 ms) : 0, 293310
AppSec [baseline] (49.045 ms) : 0, 49045
AppSec [candidate] (49.205 ms) : 0, 49205
Remote Config [baseline] (670.478 µs) : 0, 670
Remote Config [candidate] (670.864 µs) : 0, 671
Telemetry [baseline] (6.009 ms) : 0, 6009
Telemetry [candidate] (6.082 ms) : 0, 6082
section appsec
BytebuddyAgent [baseline] (634.867 ms) : 0, 634867
BytebuddyAgent [candidate] (636.686 ms) : 0, 636686
GlobalTracer [baseline] (292.702 ms) : 0, 292702
GlobalTracer [candidate] (294.378 ms) : 0, 294378
AppSec [baseline] (138.34 ms) : 0, 138340
AppSec [candidate] (138.307 ms) : 0, 138307
Remote Config [baseline] (645.532 µs) : 0, 646
Remote Config [candidate] (644.914 µs) : 0, 645
Telemetry [baseline] (5.757 ms) : 0, 5757
Telemetry [candidate] (5.776 ms) : 0, 5776
section iast
BytebuddyAgent [baseline] (744.663 ms) : 0, 744663
BytebuddyAgent [candidate] (746.499 ms) : 0, 746499
GlobalTracer [baseline] (277.362 ms) : 0, 277362
GlobalTracer [candidate] (277.838 ms) : 0, 277838
AppSec [baseline] (46.242 ms) : 0, 46242
AppSec [candidate] (46.276 ms) : 0, 46276
Remote Config [baseline] (558.722 µs) : 0, 559
Remote Config [candidate] (554.26 µs) : 0, 554
Telemetry [baseline] (5.732 ms) : 0, 5732
Telemetry [candidate] (5.739 ms) : 0, 5739
IAST [baseline] (14.343 ms) : 0, 14343
IAST [candidate] (14.418 ms) : 0, 14418
section profiling
BytebuddyAgent [baseline] (641.279 ms) : 0, 641279
BytebuddyAgent [candidate] (645.544 ms) : 0, 645544
GlobalTracer [baseline] (353.313 ms) : 0, 353313
GlobalTracer [candidate] (355.002 ms) : 0, 355002
AppSec [baseline] (49.229 ms) : 0, 49229
AppSec [candidate] (49.512 ms) : 0, 49512
Remote Config [baseline] (650.661 µs) : 0, 651
Remote Config [candidate] (652.059 µs) : 0, 652
Telemetry [baseline] (6.103 ms) : 0, 6103
Telemetry [candidate] (6.144 ms) : 0, 6144
ProfilingAgent [baseline] (80.768 ms) : 0, 80768
ProfilingAgent [candidate] (81.168 ms) : 0, 81168
Profiling [baseline] (80.792 ms) : 0, 80792
Profiling [candidate] (81.193 ms) : 0, 81193
Loading

Load

Parameters

Baseline Candidate
commit 1.22.0-SNAPSHOT~d0fd364355 1.22.0-SNAPSHOT~be0de70d4d
config baseline candidate
end_time 2023-10-06T20:44:40 2023-10-06T21:02:49
start_time 2023-10-06T20:44:22 2023-10-06T21:02:30
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 cases.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.22.0-SNAPSHOT~be0de70d4d, baseline=1.22.0-SNAPSHOT~d0fd364355
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.322 ms) : 1303, 1342
.   : milestone, 1322,
appsec (1.714 ms) : 1689, 1738
.   : milestone, 1714,
iast (1.447 ms) : 1423, 1472
.   : milestone, 1447,
profiling (1.486 ms) : 1460, 1512
.   : milestone, 1486,
tracing (1.449 ms) : 1424, 1473
.   : milestone, 1449,
section candidate
no_agent (1.33 ms) : 1311, 1349
.   : milestone, 1330,
appsec (1.694 ms) : 1670, 1718
.   : milestone, 1694,
iast (1.452 ms) : 1428, 1476
.   : milestone, 1452,
profiling (1.52 ms) : 1494, 1545
.   : milestone, 1520,
tracing (1.434 ms) : 1409, 1458
.   : milestone, 1434,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.322 ms [1.303 ms, 1.342 ms] -
appsec 1.714 ms [1.689 ms, 1.738 ms] 391.297 µs (29.6%)
iast 1.447 ms [1.423 ms, 1.472 ms] 125.135 µs (9.5%)
profiling 1.486 ms [1.46 ms, 1.512 ms] 163.588 µs (12.4%)
tracing 1.449 ms [1.424 ms, 1.473 ms] 126.309 µs (9.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.33 ms [1.311 ms, 1.349 ms] -
appsec 1.694 ms [1.67 ms, 1.718 ms] 363.806 µs (27.4%)
iast 1.452 ms [1.428 ms, 1.476 ms] 122.084 µs (9.2%)
profiling 1.52 ms [1.494 ms, 1.545 ms] 189.611 µs (14.3%)
tracing 1.434 ms [1.409 ms, 1.458 ms] 103.807 µs (7.8%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.22.0-SNAPSHOT~be0de70d4d, baseline=1.22.0-SNAPSHOT~d0fd364355
    dateFormat X
    axisFormat %s
section baseline
no_agent (362.011 µs) : 341, 383
.   : milestone, 362,
appsec (692.578 µs) : 672, 713
.   : milestone, 693,
iast (459.303 µs) : 439, 480
.   : milestone, 459,
iast_FULL (520.366 µs) : 500, 541
.   : milestone, 520,
iast_INACTIVE (434.972 µs) : 413, 456
.   : milestone, 435,
profiling (443.683 µs) : 422, 465
.   : milestone, 444,
tracing (434.743 µs) : 414, 456
.   : milestone, 435,
section candidate
no_agent (357.14 µs) : 337, 377
.   : milestone, 357,
appsec (690.355 µs) : 670, 711
.   : milestone, 690,
iast (454.099 µs) : 433, 475
.   : milestone, 454,
iast_FULL (515.154 µs) : 495, 536
.   : milestone, 515,
iast_INACTIVE (425.236 µs) : 405, 446
.   : milestone, 425,
profiling (429.239 µs) : 409, 449
.   : milestone, 429,
tracing (430.071 µs) : 409, 451
.   : milestone, 430,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 362.011 µs [341.386 µs, 382.636 µs] -
appsec 692.578 µs [671.911 µs, 713.244 µs] 330.566 µs (91.3%)
iast 459.303 µs [438.708 µs, 479.897 µs] 97.291 µs (26.9%)
iast_FULL 520.366 µs [499.591 µs, 541.141 µs] 158.355 µs (43.7%)
iast_INACTIVE 434.972 µs [413.461 µs, 456.484 µs] 72.961 µs (20.2%)
profiling 443.683 µs [422.323 µs, 465.044 µs] 81.672 µs (22.6%)
tracing 434.743 µs [413.588 µs, 455.897 µs] 72.731 µs (20.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 357.14 µs [337.194 µs, 377.086 µs] -
appsec 690.355 µs [669.982 µs, 710.728 µs] 333.215 µs (93.3%)
iast 454.099 µs [433.365 µs, 474.834 µs] 96.959 µs (27.1%)
iast_FULL 515.154 µs [494.786 µs, 535.522 µs] 158.014 µs (44.2%)
iast_INACTIVE 425.236 µs [404.597 µs, 445.875 µs] 68.096 µs (19.1%)
profiling 429.239 µs [409.138 µs, 449.34 µs] 72.099 µs (20.2%)
tracing 430.071 µs [408.986 µs, 451.155 µs] 72.931 µs (20.4%)

@devinsba devinsba force-pushed the bds/dsm-api-for-kinesis-2 branch 4 times, most recently from 857d646 to 7ad8add Compare October 6, 2023 20:30
ygree
ygree approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@ygree ygree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devinsba devinsba merged commit d6af7de into master Oct 6, 2023
65 of 68 checks passed
@devinsba devinsba deleted the bds/dsm-api-for-kinesis-2 branch October 6, 2023 21:15
@github-actions github-actions bot added this to the 1.22.0 milestone Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygree ygree ygree approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: data streams Data Streams Monitoring type: enhancement
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@devinsba @ygree