Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip task scope creation for Graal VMOperation threads #6078

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Skip task scope creation for Graal VMOperation threads #6078

merged 1 commit into from
Oct 23, 2023

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Oct 21, 2023 •
edited
Loading

Motivation

Avoids unexpected allocation issue when using G1-GC

@mcculls mcculls added the comp: native-image GraalVM native-image label Oct 21, 2023
@pr-commenter
Copy link

pr-commenter bot commented Oct 21, 2023 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
commit 1.22.0-SNAPSHOT~fcb4d04920 1.22.0-SNAPSHOT~12baa31700
config baseline candidate
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 cases.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.22.0-SNAPSHOT~12baa31700, baseline=1.22.0-SNAPSHOT~fcb4d04920

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.014 s) : 0, 1013643
Total [baseline] (8.686 s) : 0, 8686352
Agent [candidate] (1.014 s) : 0, 1013926
Total [candidate] (8.674 s) : 0, 8674130
section iast
Agent [baseline] (1.156 s) : 0, 1156119
Total [baseline] (9.226 s) : 0, 9225605
Agent [candidate] (1.143 s) : 0, 1143197
Total [candidate] (9.201 s) : 0, 9200534
section iast_TELEMETRY_OFF
Agent [baseline] (1.137 s) : 0, 1136852
Total [baseline] (9.207 s) : 0, 9207375
Agent [candidate] (1.137 s) : 0, 1137181
Total [candidate] (9.215 s) : 0, 9215042
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.014 s -
Agent iast 1.156 s 142.477 ms (14.1%)
Agent iast_TELEMETRY_OFF 1.137 s 123.21 ms (12.2%)
Total tracing 8.686 s -
Total iast 9.226 s 539.253 ms (6.2%)
Total iast_TELEMETRY_OFF 9.207 s 521.023 ms (6.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.014 s -
Agent iast 1.143 s 129.271 ms (12.7%)
Agent iast_TELEMETRY_OFF 1.137 s 123.255 ms (12.2%)
Total tracing 8.674 s -
Total iast 9.201 s 526.404 ms (6.1%)
Total iast_TELEMETRY_OFF 9.215 s 540.913 ms (6.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.22.0-SNAPSHOT~12baa31700, baseline=1.22.0-SNAPSHOT~fcb4d04920

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (631.955 ms) : 0, 631955
BytebuddyAgent [candidate] (631.699 ms) : 0, 631699
GlobalTracer [baseline] (291.743 ms) : 0, 291743
GlobalTracer [candidate] (292.365 ms) : 0, 292365
AppSec [baseline] (48.843 ms) : 0, 48843
AppSec [candidate] (48.927 ms) : 0, 48927
Remote Config [baseline] (665.601 µs) : 0, 666
Remote Config [candidate] (657.287 µs) : 0, 657
Telemetry [baseline] (6.006 ms) : 0, 6006
Telemetry [candidate] (5.946 ms) : 0, 5946
section iast
BytebuddyAgent [baseline] (772.145 ms) : 0, 772145
BytebuddyAgent [candidate] (762.945 ms) : 0, 762945
GlobalTracer [baseline] (275.554 ms) : 0, 275554
GlobalTracer [candidate] (272.949 ms) : 0, 272949
AppSec [baseline] (46.926 ms) : 0, 46926
AppSec [candidate] (46.533 ms) : 0, 46533
IAST [baseline] (19.161 ms) : 0, 19161
IAST [candidate] (18.319 ms) : 0, 18319
Remote Config [baseline] (572.076 µs) : 0, 572
Remote Config [candidate] (577.658 µs) : 0, 578
Telemetry [baseline] (6.893 ms) : 0, 6893
Telemetry [candidate] (7.577 ms) : 0, 7577
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (758.141 ms) : 0, 758141
BytebuddyAgent [candidate] (755.428 ms) : 0, 755428
GlobalTracer [baseline] (273.282 ms) : 0, 273282
GlobalTracer [candidate] (274.813 ms) : 0, 274813
AppSec [baseline] (46.323 ms) : 0, 46323
AppSec [candidate] (46.55 ms) : 0, 46550
IAST [baseline] (14.998 ms) : 0, 14998
IAST [candidate] (16.407 ms) : 0, 16407
Remote Config [baseline] (582.428 µs) : 0, 582
Remote Config [candidate] (578.545 µs) : 0, 579
Telemetry [baseline] (9.036 ms) : 0, 9036
Telemetry [candidate] (9.05 ms) : 0, 9050
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.22.0-SNAPSHOT~12baa31700, baseline=1.22.0-SNAPSHOT~fcb4d04920

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.012 s) : 0, 1012287
Total [baseline] (9.212 s) : 0, 9212428
Agent [candidate] (1.024 s) : 0, 1023677
Total [candidate] (9.217 s) : 0, 9216944
section appsec
Agent [baseline] (1.102 s) : 0, 1101695
Total [baseline] (9.259 s) : 0, 9259154
Agent [candidate] (1.104 s) : 0, 1103669
Total [candidate] (9.261 s) : 0, 9260796
section iast
Agent [baseline] (1.147 s) : 0, 1146509
Total [baseline] (9.487 s) : 0, 9487079
Agent [candidate] (1.142 s) : 0, 1142029
Total [candidate] (9.403 s) : 0, 9402705
section profiling
Agent [baseline] (1.193 s) : 0, 1192510
Total [baseline] (9.478 s) : 0, 9478436
Agent [candidate] (1.186 s) : 0, 1185987
Total [candidate] (9.406 s) : 0, 9406305
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.012 s -
Agent appsec 1.102 s 89.408 ms (8.8%)
Agent iast 1.147 s 134.222 ms (13.3%)
Agent profiling 1.193 s 180.223 ms (17.8%)
Total tracing 9.212 s -
Total appsec 9.259 s 46.725 ms (0.5%)
Total iast 9.487 s 274.651 ms (3.0%)
Total profiling 9.478 s 266.008 ms (2.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.024 s -
Agent appsec 1.104 s 79.993 ms (7.8%)
Agent iast 1.142 s 118.353 ms (11.6%)
Agent profiling 1.186 s 162.311 ms (15.9%)
Total tracing 9.217 s -
Total appsec 9.261 s 43.852 ms (0.5%)
Total iast 9.403 s 185.761 ms (2.0%)
Total profiling 9.406 s 189.36 ms (2.1%) 
gantt
    title petclinic - break down per module: candidate=1.22.0-SNAPSHOT~12baa31700, baseline=1.22.0-SNAPSHOT~fcb4d04920

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (630.87 ms) : 0, 630870
BytebuddyAgent [candidate] (637.768 ms) : 0, 637768
GlobalTracer [baseline] (291.757 ms) : 0, 291757
GlobalTracer [candidate] (295.167 ms) : 0, 295167
AppSec [baseline] (48.768 ms) : 0, 48768
AppSec [candidate] (49.394 ms) : 0, 49394
Remote Config [baseline] (659.734 µs) : 0, 660
Remote Config [candidate] (683.515 µs) : 0, 684
Telemetry [baseline] (6.005 ms) : 0, 6005
Telemetry [candidate] (6.079 ms) : 0, 6079
section appsec
BytebuddyAgent [baseline] (632.141 ms) : 0, 632141
BytebuddyAgent [candidate] (633.656 ms) : 0, 633656
GlobalTracer [baseline] (291.457 ms) : 0, 291457
GlobalTracer [candidate] (292.189 ms) : 0, 292189
AppSec [baseline] (137.568 ms) : 0, 137568
AppSec [candidate] (137.165 ms) : 0, 137165
Remote Config [baseline] (636.496 µs) : 0, 636
Remote Config [candidate] (637.164 µs) : 0, 637
Telemetry [baseline] (5.675 ms) : 0, 5675
Telemetry [candidate] (5.674 ms) : 0, 5674
section iast
BytebuddyAgent [baseline] (765.56 ms) : 0, 765560
BytebuddyAgent [candidate] (761.688 ms) : 0, 761688
GlobalTracer [baseline] (273.405 ms) : 0, 273405
GlobalTracer [candidate] (273.153 ms) : 0, 273153
AppSec [baseline] (46.693 ms) : 0, 46693
AppSec [candidate] (46.355 ms) : 0, 46355
Remote Config [baseline] (585.751 µs) : 0, 586
Remote Config [candidate] (563.891 µs) : 0, 564
Telemetry [baseline] (6.908 ms) : 0, 6908
Telemetry [candidate] (7.404 ms) : 0, 7404
IAST [baseline] (18.863 ms) : 0, 18863
IAST [candidate] (18.61 ms) : 0, 18610
section profiling
ProfilingAgent [baseline] (80.155 ms) : 0, 80155
ProfilingAgent [candidate] (79.669 ms) : 0, 79669
BytebuddyAgent [baseline] (646.079 ms) : 0, 646079
BytebuddyAgent [candidate] (643.333 ms) : 0, 643333
GlobalTracer [baseline] (356.24 ms) : 0, 356240
GlobalTracer [candidate] (354.425 ms) : 0, 354425
AppSec [baseline] (49.678 ms) : 0, 49678
AppSec [candidate] (48.863 ms) : 0, 48863
Remote Config [baseline] (656.766 µs) : 0, 657
Remote Config [candidate] (641.503 µs) : 0, 642
Telemetry [baseline] (6.126 ms) : 0, 6126
Telemetry [candidate] (6.001 ms) : 0, 6001
Profiling [baseline] (80.179 ms) : 0, 80179
Profiling [candidate] (79.693 ms) : 0, 79693
Loading

Load

Parameters

Baseline Candidate
commit 1.22.0-SNAPSHOT~fcb4d04920 1.22.0-SNAPSHOT~12baa31700
config baseline candidate
end_time 2023-10-21T22:52:05 2023-10-21T23:08:18
start_time 2023-10-21T22:51:52 2023-10-21T23:08:05
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 21 cases.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:petclinic:profiling better
[-85.478µs; -30.242µs] or [-5.696%; -2.015%]		 same
[-409.205op/s; +750.505op/s] or [-12.955%; +23.761%]		 1.443ms 3329.250op/s 1.501ms 3158.600op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.22.0-SNAPSHOT~12baa31700, baseline=1.22.0-SNAPSHOT~fcb4d04920
    dateFormat X
    axisFormat %s
section baseline
no_agent (363.858 µs) : 343, 384
.   : milestone, 364,
iast (458.998 µs) : 438, 480
.   : milestone, 459,
iast_FULL (515.87 µs) : 495, 537
.   : milestone, 516,
iast_INACTIVE (432.377 µs) : 412, 453
.   : milestone, 432,
iast_TELEMETRY_OFF (454.891 µs) : 434, 476
.   : milestone, 455,
tracing (432.998 µs) : 412, 454
.   : milestone, 433,
section candidate
no_agent (359.436 µs) : 339, 380
.   : milestone, 359,
iast (457.223 µs) : 436, 478
.   : milestone, 457,
iast_FULL (518.497 µs) : 498, 539
.   : milestone, 518,
iast_INACTIVE (438.649 µs) : 417, 461
.   : milestone, 439,
iast_TELEMETRY_OFF (453.874 µs) : 433, 475
.   : milestone, 454,
tracing (431.274 µs) : 410, 452
.   : milestone, 431,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.858 µs [343.297 µs, 384.419 µs] -
iast 458.998 µs [438.422 µs, 479.575 µs] 95.14 µs (26.1%)
iast_FULL 515.87 µs [495.041 µs, 536.699 µs] 152.011 µs (41.8%)
iast_INACTIVE 432.377 µs [411.944 µs, 452.811 µs] 68.519 µs (18.8%)
iast_TELEMETRY_OFF 454.891 µs [434.21 µs, 475.573 µs] 91.033 µs (25.0%)
tracing 432.998 µs [411.925 µs, 454.072 µs] 69.14 µs (19.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 359.436 µs [338.702 µs, 380.17 µs] -
iast 457.223 µs [435.966 µs, 478.48 µs] 97.787 µs (27.2%)
iast_FULL 518.497 µs [497.954 µs, 539.041 µs] 159.062 µs (44.3%)
iast_INACTIVE 438.649 µs [416.582 µs, 460.715 µs] 79.213 µs (22.0%)
iast_TELEMETRY_OFF 453.874 µs [433.092 µs, 474.656 µs] 94.439 µs (26.3%)
tracing 431.274 µs [410.454 µs, 452.094 µs] 71.839 µs (20.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.22.0-SNAPSHOT~12baa31700, baseline=1.22.0-SNAPSHOT~fcb4d04920
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.328 ms) : 1309, 1346
.   : milestone, 1328,
appsec (1.724 ms) : 1700, 1748
.   : milestone, 1724,
iast (1.459 ms) : 1435, 1483
.   : milestone, 1459,
profiling (1.501 ms) : 1474, 1527
.   : milestone, 1501,
tracing (1.45 ms) : 1426, 1474
.   : milestone, 1450,
section candidate
no_agent (1.304 ms) : 1285, 1323
.   : milestone, 1304,
appsec (1.671 ms) : 1646, 1696
.   : milestone, 1671,
iast (1.439 ms) : 1415, 1463
.   : milestone, 1439,
profiling (1.443 ms) : 1418, 1467
.   : milestone, 1443,
tracing (1.461 ms) : 1436, 1485
.   : milestone, 1461,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.328 ms [1.309 ms, 1.346 ms] -
appsec 1.724 ms [1.7 ms, 1.748 ms] 396.677 µs (29.9%)
iast 1.459 ms [1.435 ms, 1.483 ms] 131.121 µs (9.9%)
profiling 1.501 ms [1.474 ms, 1.527 ms] 172.882 µs (13.0%)
tracing 1.45 ms [1.426 ms, 1.474 ms] 122.469 µs (9.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.304 ms [1.285 ms, 1.323 ms] -
appsec 1.671 ms [1.646 ms, 1.696 ms] 366.871 µs (28.1%)
iast 1.439 ms [1.415 ms, 1.463 ms] 135.113 µs (10.4%)
profiling 1.443 ms [1.418 ms, 1.467 ms] 138.696 µs (10.6%)
tracing 1.461 ms [1.436 ms, 1.485 ms] 156.572 µs (12.0%)

@mcculls mcculls added this to the 1.22.0 milestone Oct 21, 2023
@mcculls mcculls marked this pull request as ready for review October 21, 2023 23:46
@mcculls mcculls requested a review from a team as a code owner October 21, 2023 23:46
@mcculls mcculls merged commit 6f0485d into master Oct 23, 2023
69 checks passed
@mcculls mcculls deleted the mcculls/ignore-graal-vmthreads branch October 23, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@bantonsson bantonsson Awaiting requested review from bantonsson bantonsson was automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: native-image GraalVM native-image
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mcculls @PerfectSlayer