Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark some default services as off during native-image build #6079

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Mark some default services as off during native-image build #6079

merged 1 commit into from
Oct 24, 2023
+6 −0

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Oct 21, 2023

Motivation

Avoids potential ClassNotFoundException shutting down the generated image

@mcculls mcculls added the comp: native-image GraalVM native-image label Oct 21, 2023
@pr-commenter
Copy link

pr-commenter bot commented Oct 21, 2023

Benchmarks

Startup

Parameters

Baseline Candidate
commit 1.22.0-SNAPSHOT~fcb4d04920 1.22.0-SNAPSHOT~67498f2342
config baseline candidate
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 cases.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.22.0-SNAPSHOT~67498f2342, baseline=1.22.0-SNAPSHOT~fcb4d04920

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.014 s) : 0, 1014152
Total [baseline] (9.239 s) : 0, 9238509
Agent [candidate] (1.017 s) : 0, 1017446
Total [candidate] (9.24 s) : 0, 9240003
section appsec
Agent [baseline] (1.103 s) : 0, 1103352
Total [baseline] (9.265 s) : 0, 9265353
Agent [candidate] (1.11 s) : 0, 1110143
Total [candidate] (9.342 s) : 0, 9342414
section iast
Agent [baseline] (1.142 s) : 0, 1142218
Total [baseline] (9.486 s) : 0, 9485997
Agent [candidate] (1.148 s) : 0, 1148426
Total [candidate] (9.402 s) : 0, 9401605
section profiling
Agent [baseline] (1.189 s) : 0, 1189252
Total [baseline] (9.393 s) : 0, 9392895
Agent [candidate] (1.196 s) : 0, 1196252
Total [candidate] (9.53 s) : 0, 9529742
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.014 s -
Agent appsec 1.103 s 89.199 ms (8.8%)
Agent iast 1.142 s 128.065 ms (12.6%)
Agent profiling 1.189 s 175.1 ms (17.3%)
Total tracing 9.239 s -
Total appsec 9.265 s 26.844 ms (0.3%)
Total iast 9.486 s 247.488 ms (2.7%)
Total profiling 9.393 s 154.386 ms (1.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.017 s -
Agent appsec 1.11 s 92.697 ms (9.1%)
Agent iast 1.148 s 130.98 ms (12.9%)
Agent profiling 1.196 s 178.806 ms (17.6%)
Total tracing 9.24 s -
Total appsec 9.342 s 102.411 ms (1.1%)
Total iast 9.402 s 161.602 ms (1.7%)
Total profiling 9.53 s 289.739 ms (3.1%) 
gantt
    title petclinic - break down per module: candidate=1.22.0-SNAPSHOT~67498f2342, baseline=1.22.0-SNAPSHOT~fcb4d04920

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (631.947 ms) : 0, 631947
BytebuddyAgent [candidate] (633.473 ms) : 0, 633473
GlobalTracer [baseline] (292.296 ms) : 0, 292296
GlobalTracer [candidate] (293.859 ms) : 0, 293859
AppSec [baseline] (48.945 ms) : 0, 48945
AppSec [candidate] (48.895 ms) : 0, 48895
Remote Config [baseline] (666.737 µs) : 0, 667
Remote Config [candidate] (695.578 µs) : 0, 696
Telemetry [baseline] (6.012 ms) : 0, 6012
Telemetry [candidate] (6.075 ms) : 0, 6075
section appsec
BytebuddyAgent [baseline] (633.456 ms) : 0, 633456
BytebuddyAgent [candidate] (637.62 ms) : 0, 637620
GlobalTracer [baseline] (292.004 ms) : 0, 292004
GlobalTracer [candidate] (293.809 ms) : 0, 293809
AppSec [baseline] (137.296 ms) : 0, 137296
AppSec [candidate] (137.805 ms) : 0, 137805
Remote Config [baseline] (641.469 µs) : 0, 641
Remote Config [candidate] (644.856 µs) : 0, 645
Telemetry [baseline] (5.669 ms) : 0, 5669
Telemetry [candidate] (5.728 ms) : 0, 5728
section iast
BytebuddyAgent [baseline] (763.187 ms) : 0, 763187
BytebuddyAgent [candidate] (767.495 ms) : 0, 767495
GlobalTracer [baseline] (272.653 ms) : 0, 272653
GlobalTracer [candidate] (274.112 ms) : 0, 274112
AppSec [baseline] (46.3 ms) : 0, 46300
AppSec [candidate] (46.367 ms) : 0, 46367
Remote Config [baseline] (565.161 µs) : 0, 565
Remote Config [candidate] (571.478 µs) : 0, 571
Telemetry [baseline] (8.226 ms) : 0, 8226
Telemetry [candidate] (6.781 ms) : 0, 6781
IAST [baseline] (16.613 ms) : 0, 16613
IAST [candidate] (18.537 ms) : 0, 18537
section profiling
BytebuddyAgent [baseline] (643.443 ms) : 0, 643443
BytebuddyAgent [candidate] (649.776 ms) : 0, 649776
GlobalTracer [baseline] (355.624 ms) : 0, 355624
GlobalTracer [candidate] (356.565 ms) : 0, 356565
AppSec [baseline] (49.369 ms) : 0, 49369
AppSec [candidate] (49.057 ms) : 0, 49057
Remote Config [baseline] (662.108 µs) : 0, 662
Remote Config [candidate] (677.026 µs) : 0, 677
Telemetry [baseline] (6.054 ms) : 0, 6054
Telemetry [candidate] (6.077 ms) : 0, 6077
ProfilingAgent [baseline] (80.703 ms) : 0, 80703
ProfilingAgent [candidate] (80.426 ms) : 0, 80426
Profiling [baseline] (80.727 ms) : 0, 80727
Profiling [candidate] (80.45 ms) : 0, 80450
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.22.0-SNAPSHOT~67498f2342, baseline=1.22.0-SNAPSHOT~fcb4d04920

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.014 s) : 0, 1014090
Total [baseline] (8.669 s) : 0, 8668673
Agent [candidate] (1.029 s) : 0, 1029343
Total [candidate] (8.734 s) : 0, 8734272
section iast
Agent [baseline] (1.138 s) : 0, 1137711
Total [baseline] (9.236 s) : 0, 9236476
Agent [candidate] (1.151 s) : 0, 1150810
Total [candidate] (9.283 s) : 0, 9282607
section iast_TELEMETRY_OFF
Agent [baseline] (1.138 s) : 0, 1138032
Total [baseline] (9.197 s) : 0, 9196533
Agent [candidate] (1.145 s) : 0, 1144974
Total [candidate] (9.186 s) : 0, 9185897
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.014 s -
Agent iast 1.138 s 123.621 ms (12.2%)
Agent iast_TELEMETRY_OFF 1.138 s 123.942 ms (12.2%)
Total tracing 8.669 s -
Total iast 9.236 s 567.803 ms (6.6%)
Total iast_TELEMETRY_OFF 9.197 s 527.86 ms (6.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.029 s -
Agent iast 1.151 s 121.466 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.145 s 115.631 ms (11.2%)
Total tracing 8.734 s -
Total iast 9.283 s 548.335 ms (6.3%)
Total iast_TELEMETRY_OFF 9.186 s 451.625 ms (5.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.22.0-SNAPSHOT~67498f2342, baseline=1.22.0-SNAPSHOT~fcb4d04920

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (632.036 ms) : 0, 632036
BytebuddyAgent [candidate] (641.271 ms) : 0, 641271
GlobalTracer [baseline] (292.295 ms) : 0, 292295
GlobalTracer [candidate] (296.823 ms) : 0, 296823
AppSec [baseline] (48.684 ms) : 0, 48684
AppSec [candidate] (49.62 ms) : 0, 49620
Remote Config [baseline] (667.742 µs) : 0, 668
Remote Config [candidate] (668.972 µs) : 0, 669
Telemetry [baseline] (5.976 ms) : 0, 5976
Telemetry [candidate] (6.146 ms) : 0, 6146
section iast
BytebuddyAgent [baseline] (759.437 ms) : 0, 759437
BytebuddyAgent [candidate] (768.441 ms) : 0, 768441
GlobalTracer [baseline] (272.436 ms) : 0, 272436
GlobalTracer [candidate] (274.729 ms) : 0, 274729
AppSec [baseline] (46.228 ms) : 0, 46228
AppSec [candidate] (46.469 ms) : 0, 46469
IAST [baseline] (17.986 ms) : 0, 17986
IAST [candidate] (19.052 ms) : 0, 19052
Remote Config [baseline] (563.103 µs) : 0, 563
Remote Config [candidate] (575.658 µs) : 0, 576
Telemetry [baseline] (6.795 ms) : 0, 6795
Telemetry [candidate] (6.831 ms) : 0, 6831
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (756.81 ms) : 0, 756810
BytebuddyAgent [candidate] (762.725 ms) : 0, 762725
GlobalTracer [baseline] (274.248 ms) : 0, 274248
GlobalTracer [candidate] (275.225 ms) : 0, 275225
AppSec [baseline] (47.023 ms) : 0, 47023
AppSec [candidate] (46.633 ms) : 0, 46633
IAST [baseline] (16.483 ms) : 0, 16483
IAST [candidate] (18.337 ms) : 0, 18337
Remote Config [baseline] (585.916 µs) : 0, 586
Remote Config [candidate] (580.739 µs) : 0, 581
Telemetry [baseline] (8.425 ms) : 0, 8425
Telemetry [candidate] (6.825 ms) : 0, 6825
Loading

Load

Parameters

Baseline Candidate
commit 1.22.0-SNAPSHOT~fcb4d04920 1.22.0-SNAPSHOT~67498f2342
config baseline candidate
end_time 2023-10-21T22:50:16 2023-10-21T23:06:34
start_time 2023-10-21T22:50:03 2023-10-21T23:06:21
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.22.0-SNAPSHOT~67498f2342, baseline=1.22.0-SNAPSHOT~fcb4d04920
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.347 ms) : 1327, 1367
.   : milestone, 1347,
appsec (1.702 ms) : 1678, 1726
.   : milestone, 1702,
iast (1.463 ms) : 1439, 1488
.   : milestone, 1463,
profiling (1.483 ms) : 1457, 1509
.   : milestone, 1483,
tracing (1.462 ms) : 1438, 1486
.   : milestone, 1462,
section candidate
no_agent (1.322 ms) : 1304, 1341
.   : milestone, 1322,
appsec (1.702 ms) : 1678, 1727
.   : milestone, 1702,
iast (1.473 ms) : 1448, 1497
.   : milestone, 1473,
profiling (1.475 ms) : 1450, 1499
.   : milestone, 1475,
tracing (1.44 ms) : 1415, 1464
.   : milestone, 1440,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.347 ms [1.327 ms, 1.367 ms] -
appsec 1.702 ms [1.678 ms, 1.726 ms] 354.984 µs (26.4%)
iast 1.463 ms [1.439 ms, 1.488 ms] 115.908 µs (8.6%)
profiling 1.483 ms [1.457 ms, 1.509 ms] 135.799 µs (10.1%)
tracing 1.462 ms [1.438 ms, 1.486 ms] 114.644 µs (8.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.322 ms [1.304 ms, 1.341 ms] -
appsec 1.702 ms [1.678 ms, 1.727 ms] 380.063 µs (28.7%)
iast 1.473 ms [1.448 ms, 1.497 ms] 150.366 µs (11.4%)
profiling 1.475 ms [1.45 ms, 1.499 ms] 152.187 µs (11.5%)
tracing 1.44 ms [1.415 ms, 1.464 ms] 117.292 µs (8.9%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.22.0-SNAPSHOT~67498f2342, baseline=1.22.0-SNAPSHOT~fcb4d04920
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.94 µs) : 346, 388
.   : milestone, 367,
iast (460.802 µs) : 440, 481
.   : milestone, 461,
iast_FULL (527.193 µs) : 506, 548
.   : milestone, 527,
iast_INACTIVE (432.831 µs) : 412, 454
.   : milestone, 433,
iast_TELEMETRY_OFF (463.98 µs) : 442, 486
.   : milestone, 464,
tracing (431.799 µs) : 411, 453
.   : milestone, 432,
section candidate
no_agent (359.807 µs) : 340, 380
.   : milestone, 360,
iast (467.233 µs) : 446, 488
.   : milestone, 467,
iast_FULL (530.933 µs) : 510, 552
.   : milestone, 531,
iast_INACTIVE (431.239 µs) : 411, 452
.   : milestone, 431,
iast_TELEMETRY_OFF (461.817 µs) : 441, 483
.   : milestone, 462,
tracing (436.752 µs) : 416, 458
.   : milestone, 437,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.94 µs [346.27 µs, 387.61 µs] -
iast 460.802 µs [440.326 µs, 481.277 µs] 93.862 µs (25.6%)
iast_FULL 527.193 µs [506.419 µs, 547.966 µs] 160.253 µs (43.7%)
iast_INACTIVE 432.831 µs [411.659 µs, 454.003 µs] 65.891 µs (18.0%)
iast_TELEMETRY_OFF 463.98 µs [442.451 µs, 485.509 µs] 97.04 µs (26.4%)
tracing 431.799 µs [410.714 µs, 452.884 µs] 64.859 µs (17.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 359.807 µs [340.029 µs, 379.585 µs] -
iast 467.233 µs [446.344 µs, 488.122 µs] 107.426 µs (29.9%)
iast_FULL 530.933 µs [510.27 µs, 551.596 µs] 171.126 µs (47.6%)
iast_INACTIVE 431.239 µs [410.535 µs, 451.944 µs] 71.432 µs (19.9%)
iast_TELEMETRY_OFF 461.817 µs [440.788 µs, 482.847 µs] 102.01 µs (28.4%)
tracing 436.752 µs [415.683 µs, 457.821 µs] 76.945 µs (21.4%)

@mcculls mcculls added this to the 1.22.0 milestone Oct 21, 2023
@mcculls mcculls marked this pull request as ready for review October 21, 2023 23:46
@mcculls mcculls requested a review from a team as a code owner October 21, 2023 23:46
PerfectSlayer
PerfectSlayer approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcculls mcculls merged commit 7956126 into master Oct 24, 2023
71 checks passed
@mcculls mcculls deleted the mcculls/native-image-builder-default-services branch October 24, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

@am312 am312 Awaiting requested review from am312 am312 is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: native-image GraalVM native-image
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mcculls @PerfectSlayer