Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tracer enabled detection default value #6142

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Fix tracer enabled detection default value #6142

merged 1 commit into from
Nov 3, 2023

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Nov 3, 2023

What Does This Do

Checking for trace enabled needs to be true by default if no token

Motivation

Additional Notes

@jpbempel
Fix tracer enabled detection default value
ebc3241 
Checking for trace enabled needs to be true by default if no token
@jpbempel jpbempel requested a review from a team as a code owner November 3, 2023 07:09
@jpbempel jpbempel requested review from cimi and removed request for a team November 3, 2023 07:09
@jpbempel jpbempel added comp: debugger Dynamic Instrumentation type: bug labels Nov 3, 2023
@pr-commenter
Copy link

pr-commenter bot commented Nov 3, 2023

Benchmarks

Startup

Parameters

Baseline Candidate
commit 1.23.0-SNAPSHOT~23bbe149f2 1.23.0-SNAPSHOT~ebc32411ba
config baseline candidate
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 cases.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.23.0-SNAPSHOT~ebc32411ba, baseline=1.23.0-SNAPSHOT~23bbe149f2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.034 s) : 0, 1033502
Total [baseline] (8.733 s) : 0, 8733352
Agent [candidate] (1.035 s) : 0, 1035248
Total [candidate] (8.762 s) : 0, 8761993
section iast
Agent [baseline] (1.147 s) : 0, 1147120
Total [baseline] (9.282 s) : 0, 9281661
Agent [candidate] (1.15 s) : 0, 1150202
Total [candidate] (9.315 s) : 0, 9315224
section iast_TELEMETRY_OFF
Agent [baseline] (1.141 s) : 0, 1140770
Total [baseline] (9.256 s) : 0, 9255683
Agent [candidate] (1.143 s) : 0, 1143304
Total [candidate] (9.292 s) : 0, 9292367
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.034 s -
Agent iast 1.147 s 113.618 ms (11.0%)
Agent iast_TELEMETRY_OFF 1.141 s 107.268 ms (10.4%)
Total tracing 8.733 s -
Total iast 9.282 s 548.309 ms (6.3%)
Total iast_TELEMETRY_OFF 9.256 s 522.331 ms (6.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.035 s -
Agent iast 1.15 s 114.954 ms (11.1%)
Agent iast_TELEMETRY_OFF 1.143 s 108.056 ms (10.4%)
Total tracing 8.762 s -
Total iast 9.315 s 553.232 ms (6.3%)
Total iast_TELEMETRY_OFF 9.292 s 530.375 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.23.0-SNAPSHOT~ebc32411ba, baseline=1.23.0-SNAPSHOT~23bbe149f2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (644.355 ms) : 0, 644355
BytebuddyAgent [candidate] (645.8 ms) : 0, 645800
GlobalTracer [baseline] (292.812 ms) : 0, 292812
GlobalTracer [candidate] (293.838 ms) : 0, 293838
AppSec [baseline] (49.773 ms) : 0, 49773
AppSec [candidate] (49.016 ms) : 0, 49016
Remote Config [baseline] (702.372 µs) : 0, 702
Remote Config [candidate] (683.886 µs) : 0, 684
Telemetry [baseline] (11.415 ms) : 0, 11415
Telemetry [candidate] (11.363 ms) : 0, 11363
section iast
BytebuddyAgent [baseline] (764.175 ms) : 0, 764175
BytebuddyAgent [candidate] (765.0 ms) : 0, 765000
GlobalTracer [baseline] (272.755 ms) : 0, 272755
GlobalTracer [candidate] (273.795 ms) : 0, 273795
AppSec [baseline] (46.619 ms) : 0, 46619
AppSec [candidate] (46.488 ms) : 0, 46488
IAST [baseline] (15.304 ms) : 0, 15304
IAST [candidate] (17.336 ms) : 0, 17336
Remote Config [baseline] (566.947 µs) : 0, 567
Remote Config [candidate] (573.999 µs) : 0, 574
Telemetry [baseline] (13.194 ms) : 0, 13194
Telemetry [candidate] (12.597 ms) : 0, 12597
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (757.585 ms) : 0, 757585
BytebuddyAgent [candidate] (757.888 ms) : 0, 757888
GlobalTracer [baseline] (273.904 ms) : 0, 273904
GlobalTracer [candidate] (273.985 ms) : 0, 273985
AppSec [baseline] (46.547 ms) : 0, 46547
AppSec [candidate] (46.6 ms) : 0, 46600
IAST [baseline] (16.461 ms) : 0, 16461
IAST [candidate] (17.919 ms) : 0, 17919
Remote Config [baseline] (593.099 µs) : 0, 593
Remote Config [candidate] (573.012 µs) : 0, 573
Telemetry [baseline] (11.307 ms) : 0, 11307
Telemetry [candidate] (11.859 ms) : 0, 11859
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.23.0-SNAPSHOT~ebc32411ba, baseline=1.23.0-SNAPSHOT~23bbe149f2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046390
Total [baseline] (9.337 s) : 0, 9336558
Agent [candidate] (1.042 s) : 0, 1042228
Total [candidate] (9.288 s) : 0, 9288086
section appsec
Agent [baseline] (1.118 s) : 0, 1117604
Total [baseline] (9.35 s) : 0, 9349934
Agent [candidate] (1.12 s) : 0, 1120143
Total [candidate] (9.433 s) : 0, 9432538
section iast
Agent [baseline] (1.146 s) : 0, 1146377
Total [baseline] (9.548 s) : 0, 9548488
Agent [candidate] (1.15 s) : 0, 1150009
Total [candidate] (9.542 s) : 0, 9542470
section profiling
Agent [baseline] (1.224 s) : 0, 1223926
Total [baseline] (9.549 s) : 0, 9548793
Agent [candidate] (1.217 s) : 0, 1216822
Total [candidate] (9.519 s) : 0, 9519388
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent appsec 1.118 s 71.215 ms (6.8%)
Agent iast 1.146 s 99.987 ms (9.6%)
Agent profiling 1.224 s 177.536 ms (17.0%)
Total tracing 9.337 s -
Total appsec 9.35 s 13.376 ms (0.1%)
Total iast 9.548 s 211.93 ms (2.3%)
Total profiling 9.549 s 212.235 ms (2.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.042 s -
Agent appsec 1.12 s 77.915 ms (7.5%)
Agent iast 1.15 s 107.781 ms (10.3%)
Agent profiling 1.217 s 174.595 ms (16.8%)
Total tracing 9.288 s -
Total appsec 9.433 s 144.452 ms (1.6%)
Total iast 9.542 s 254.383 ms (2.7%)
Total profiling 9.519 s 231.302 ms (2.5%) 
gantt
    title petclinic - break down per module: candidate=1.23.0-SNAPSHOT~ebc32411ba, baseline=1.23.0-SNAPSHOT~23bbe149f2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (653.792 ms) : 0, 653792
BytebuddyAgent [candidate] (650.02 ms) : 0, 650020
GlobalTracer [baseline] (296.526 ms) : 0, 296526
GlobalTracer [candidate] (296.214 ms) : 0, 296214
AppSec [baseline] (49.248 ms) : 0, 49248
AppSec [candidate] (49.143 ms) : 0, 49143
Remote Config [baseline] (707.223 µs) : 0, 707
Remote Config [candidate] (714.001 µs) : 0, 714
Telemetry [baseline] (11.312 ms) : 0, 11312
Telemetry [candidate] (11.434 ms) : 0, 11434
section appsec
BytebuddyAgent [baseline] (644.022 ms) : 0, 644022
BytebuddyAgent [candidate] (645.953 ms) : 0, 645953
GlobalTracer [baseline] (293.227 ms) : 0, 293227
GlobalTracer [candidate] (294.031 ms) : 0, 294031
AppSec [baseline] (138.515 ms) : 0, 138515
AppSec [candidate] (138.241 ms) : 0, 138241
Remote Config [baseline] (643.84 µs) : 0, 644
Remote Config [candidate] (642.847 µs) : 0, 643
Telemetry [baseline] (6.869 ms) : 0, 6869
Telemetry [candidate] (6.873 ms) : 0, 6873
section iast
BytebuddyAgent [baseline] (763.836 ms) : 0, 763836
BytebuddyAgent [candidate] (765.575 ms) : 0, 765575
GlobalTracer [baseline] (273.59 ms) : 0, 273590
GlobalTracer [candidate] (274.294 ms) : 0, 274294
AppSec [baseline] (46.329 ms) : 0, 46329
AppSec [candidate] (46.591 ms) : 0, 46591
IAST [baseline] (17.169 ms) : 0, 17169
IAST [candidate] (15.92 ms) : 0, 15920
Remote Config [baseline] (562.596 µs) : 0, 563
Remote Config [candidate] (563.197 µs) : 0, 563
Telemetry [baseline] (10.516 ms) : 0, 10516
Telemetry [candidate] (12.527 ms) : 0, 12527
section profiling
BytebuddyAgent [baseline] (659.028 ms) : 0, 659028
BytebuddyAgent [candidate] (655.375 ms) : 0, 655375
GlobalTracer [baseline] (359.748 ms) : 0, 359748
GlobalTracer [candidate] (357.701 ms) : 0, 357701
AppSec [baseline] (49.693 ms) : 0, 49693
AppSec [candidate] (49.227 ms) : 0, 49227
Remote Config [baseline] (645.803 µs) : 0, 646
Remote Config [candidate] (645.172 µs) : 0, 645
Telemetry [baseline] (11.344 ms) : 0, 11344
Telemetry [candidate] (11.288 ms) : 0, 11288
ProfilingAgent [baseline] (88.952 ms) : 0, 88952
ProfilingAgent [candidate] (88.236 ms) : 0, 88236
Profiling [baseline] (88.976 ms) : 0, 88976
Profiling [candidate] (88.26 ms) : 0, 88260
Loading

Load

Parameters

Baseline Candidate
commit 1.23.0-SNAPSHOT~23bbe149f2 1.23.0-SNAPSHOT~ebc32411ba
config baseline candidate
end_time 2023-11-03T07:35:07 2023-11-03T07:51:33
start_time 2023-11-03T07:34:54 2023-11-03T07:51:21
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.23.0-SNAPSHOT~ebc32411ba, baseline=1.23.0-SNAPSHOT~23bbe149f2
    dateFormat X
    axisFormat %s
section baseline
no_agent (359.298 µs) : 340, 379
.   : milestone, 359,
iast (471.975 µs) : 451, 493
.   : milestone, 472,
iast_FULL (521.141 µs) : 501, 542
.   : milestone, 521,
iast_INACTIVE (429.235 µs) : 408, 450
.   : milestone, 429,
iast_TELEMETRY_OFF (455.945 µs) : 434, 477
.   : milestone, 456,
tracing (434.86 µs) : 414, 456
.   : milestone, 435,
section candidate
no_agent (361.434 µs) : 341, 382
.   : milestone, 361,
iast (464.496 µs) : 443, 486
.   : milestone, 464,
iast_FULL (516.594 µs) : 496, 537
.   : milestone, 517,
iast_INACTIVE (432.471 µs) : 411, 453
.   : milestone, 432,
iast_TELEMETRY_OFF (456.237 µs) : 435, 478
.   : milestone, 456,
tracing (428.67 µs) : 407, 450
.   : milestone, 429,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 359.298 µs [339.578 µs, 379.017 µs] -
iast 471.975 µs [450.898 µs, 493.052 µs] 112.677 µs (31.4%)
iast_FULL 521.141 µs [500.677 µs, 541.604 µs] 161.843 µs (45.0%)
iast_INACTIVE 429.235 µs [408.406 µs, 450.064 µs] 69.937 µs (19.5%)
iast_TELEMETRY_OFF 455.945 µs [434.412 µs, 477.477 µs] 96.647 µs (26.9%)
tracing 434.86 µs [413.505 µs, 456.214 µs] 75.562 µs (21.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 361.434 µs [340.509 µs, 382.359 µs] -
iast 464.496 µs [443.338 µs, 485.653 µs] 103.062 µs (28.5%)
iast_FULL 516.594 µs [495.896 µs, 537.292 µs] 155.16 µs (42.9%)
iast_INACTIVE 432.471 µs [411.491 µs, 453.45 µs] 71.037 µs (19.7%)
iast_TELEMETRY_OFF 456.237 µs [434.907 µs, 477.566 µs] 94.803 µs (26.2%)
tracing 428.67 µs [407.442 µs, 449.899 µs] 67.237 µs (18.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.23.0-SNAPSHOT~ebc32411ba, baseline=1.23.0-SNAPSHOT~23bbe149f2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.347 ms) : 1328, 1366
.   : milestone, 1347,
appsec (1.718 ms) : 1693, 1742
.   : milestone, 1718,
iast (1.476 ms) : 1452, 1500
.   : milestone, 1476,
profiling (1.483 ms) : 1455, 1510
.   : milestone, 1483,
tracing (1.451 ms) : 1427, 1475
.   : milestone, 1451,
section candidate
no_agent (1.324 ms) : 1306, 1343
.   : milestone, 1324,
appsec (1.715 ms) : 1690, 1740
.   : milestone, 1715,
iast (1.48 ms) : 1457, 1504
.   : milestone, 1480,
profiling (1.475 ms) : 1450, 1500
.   : milestone, 1475,
tracing (1.455 ms) : 1431, 1479
.   : milestone, 1455,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.347 ms [1.328 ms, 1.366 ms] -
appsec 1.718 ms [1.693 ms, 1.742 ms] 370.502 µs (27.5%)
iast 1.476 ms [1.452 ms, 1.5 ms] 128.676 µs (9.6%)
profiling 1.483 ms [1.455 ms, 1.51 ms] 135.504 µs (10.1%)
tracing 1.451 ms [1.427 ms, 1.475 ms] 103.473 µs (7.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.324 ms [1.306 ms, 1.343 ms] -
appsec 1.715 ms [1.69 ms, 1.74 ms] 390.518 µs (29.5%)
iast 1.48 ms [1.457 ms, 1.504 ms] 156.163 µs (11.8%)
profiling 1.475 ms [1.45 ms, 1.5 ms] 150.914 µs (11.4%)
tracing 1.455 ms [1.431 ms, 1.479 ms] 130.339 µs (9.8%)

OmerRaviv
OmerRaviv approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@OmerRaviv OmerRaviv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpbempel jpbempel merged commit 28b8ba2 into master Nov 3, 2023
69 of 71 checks passed
@jpbempel jpbempel deleted the jpbempel/fix-default-trace-config branch November 3, 2023 17:32
@github-actions github-actions bot added this to the 1.23.0 milestone Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmerRaviv OmerRaviv OmerRaviv approved these changes

@cimi cimi Awaiting requested review from cimi cimi is a code owner automatically assigned from DataDog/debugger-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation type: bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @OmerRaviv