report profiling context integration on root span #6163

richardstartin · 2023-11-07T12:31:35Z

What Does This Do

Records the profiling context integration in use on the root span, which helps with trace to profile correlation.

Motivation

Additional Notes

Jira ticket: PROF-8581

pr-commenter · 2023-11-07T13:16:24Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
commit	1.23.0-SNAPSHOT~d3871dd321	1.23.0-SNAPSHOT~3e3e9e4e48
config	baseline	candidate

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 cases.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.23.0-SNAPSHOT~3e3e9e4e48, baseline=1.23.0-SNAPSHOT~d3871dd321

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043839
Total [baseline] (9.311 s) : 0, 9310727
Agent [candidate] (1.038 s) : 0, 1038078
Total [candidate] (9.398 s) : 0, 9397854
section appsec
Agent [baseline] (1.121 s) : 0, 1121156
Total [baseline] (9.458 s) : 0, 9458488
Agent [candidate] (1.126 s) : 0, 1126407
Total [candidate] (9.459 s) : 0, 9459463
section iast
Agent [baseline] (1.154 s) : 0, 1153965
Total [baseline] (9.497 s) : 0, 9496510
Agent [candidate] (1.157 s) : 0, 1156929
Total [candidate] (9.543 s) : 0, 9542526
section profiling
Agent [baseline] (1.218 s) : 0, 1218216
Total [baseline] (9.491 s) : 0, 9490786
Agent [candidate] (1.23 s) : 0, 1230324
Total [candidate] (9.483 s) : 0, 9483000

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.044 s	-
Agent	appsec	1.121 s	77.317 ms (7.4%)
Agent	iast	1.154 s	110.126 ms (10.6%)
Agent	profiling	1.218 s	174.377 ms (16.7%)
Total	tracing	9.311 s	-
Total	appsec	9.458 s	147.761 ms (1.6%)
Total	iast	9.497 s	185.783 ms (2.0%)
Total	profiling	9.491 s	180.059 ms (1.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.038 s	-
Agent	appsec	1.126 s	88.329 ms (8.5%)
Agent	iast	1.157 s	118.85 ms (11.4%)
Agent	profiling	1.23 s	192.246 ms (18.5%)
Total	tracing	9.398 s	-
Total	appsec	9.459 s	61.609 ms (0.7%)
Total	iast	9.543 s	144.672 ms (1.5%)
Total	profiling	9.483 s	85.146 ms (0.9%)

gantt
    title petclinic - break down per module: candidate=1.23.0-SNAPSHOT~3e3e9e4e48, baseline=1.23.0-SNAPSHOT~d3871dd321

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (651.081 ms) : 0, 651081
BytebuddyAgent [candidate] (646.93 ms) : 0, 646930
GlobalTracer [baseline] (296.453 ms) : 0, 296453
GlobalTracer [candidate] (295.657 ms) : 0, 295657
AppSec [baseline] (49.308 ms) : 0, 49308
AppSec [candidate] (48.997 ms) : 0, 48997
Remote Config [baseline] (702.787 µs) : 0, 703
Remote Config [candidate] (686.491 µs) : 0, 686
Telemetry [baseline] (11.563 ms) : 0, 11563
Telemetry [candidate] (11.4 ms) : 0, 11400
section appsec
BytebuddyAgent [baseline] (646.298 ms) : 0, 646298
BytebuddyAgent [candidate] (650.335 ms) : 0, 650335
GlobalTracer [baseline] (294.14 ms) : 0, 294140
GlobalTracer [candidate] (295.232 ms) : 0, 295232
AppSec [baseline] (138.779 ms) : 0, 138779
AppSec [candidate] (138.651 ms) : 0, 138651
Remote Config [baseline] (645.858 µs) : 0, 646
Remote Config [candidate] (653.405 µs) : 0, 653
Telemetry [baseline] (6.871 ms) : 0, 6871
Telemetry [candidate] (6.888 ms) : 0, 6888
section iast
BytebuddyAgent [baseline] (766.228 ms) : 0, 766228
BytebuddyAgent [candidate] (768.7 ms) : 0, 768700
GlobalTracer [baseline] (274.54 ms) : 0, 274540
GlobalTracer [candidate] (275.612 ms) : 0, 275612
AppSec [baseline] (46.59 ms) : 0, 46590
AppSec [candidate] (46.78 ms) : 0, 46780
Remote Config [baseline] (591.822 µs) : 0, 592
Remote Config [candidate] (578.977 µs) : 0, 579
Telemetry [baseline] (12.464 ms) : 0, 12464
Telemetry [candidate] (13.175 ms) : 0, 13175
IAST [baseline] (18.941 ms) : 0, 18941
IAST [candidate] (17.514 ms) : 0, 17514
section profiling
ProfilingAgent [baseline] (87.994 ms) : 0, 87994
ProfilingAgent [candidate] (89.388 ms) : 0, 89388
BytebuddyAgent [baseline] (655.472 ms) : 0, 655472
BytebuddyAgent [candidate] (662.641 ms) : 0, 662641
GlobalTracer [baseline] (359.151 ms) : 0, 359151
GlobalTracer [candidate] (361.573 ms) : 0, 361573
AppSec [baseline] (49.331 ms) : 0, 49331
AppSec [candidate] (49.824 ms) : 0, 49824
Remote Config [baseline] (659.398 µs) : 0, 659
Remote Config [candidate] (655.196 µs) : 0, 655
Telemetry [baseline] (11.321 ms) : 0, 11321
Telemetry [candidate] (11.427 ms) : 0, 11427
Profiling [baseline] (88.017 ms) : 0, 88017
Profiling [candidate] (89.412 ms) : 0, 89412

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.23.0-SNAPSHOT~3e3e9e4e48, baseline=1.23.0-SNAPSHOT~d3871dd321

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.034 s) : 0, 1034400
Total [baseline] (8.772 s) : 0, 8771636
Agent [candidate] (1.045 s) : 0, 1044710
Total [candidate] (8.844 s) : 0, 8843676
section iast
Agent [baseline] (1.153 s) : 0, 1152919
Total [baseline] (9.328 s) : 0, 9327706
Agent [candidate] (1.154 s) : 0, 1153841
Total [candidate] (9.338 s) : 0, 9337786
section iast_TELEMETRY_OFF
Agent [baseline] (1.164 s) : 0, 1164374
Total [baseline] (9.347 s) : 0, 9347499
Agent [candidate] (1.168 s) : 0, 1167848
Total [candidate] (9.383 s) : 0, 9382800

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.034 s	-
Agent	iast	1.153 s	118.52 ms (11.5%)
Agent	iast_TELEMETRY_OFF	1.164 s	129.975 ms (12.6%)
Total	tracing	8.772 s	-
Total	iast	9.328 s	556.069 ms (6.3%)
Total	iast_TELEMETRY_OFF	9.347 s	575.862 ms (6.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.045 s	-
Agent	iast	1.154 s	109.13 ms (10.4%)
Agent	iast_TELEMETRY_OFF	1.168 s	123.137 ms (11.8%)
Total	tracing	8.844 s	-
Total	iast	9.338 s	494.11 ms (5.6%)
Total	iast_TELEMETRY_OFF	9.383 s	539.123 ms (6.1%)

gantt
    title insecure-bank - break down per module: candidate=1.23.0-SNAPSHOT~3e3e9e4e48, baseline=1.23.0-SNAPSHOT~d3871dd321

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (645.552 ms) : 0, 645552
BytebuddyAgent [candidate] (651.473 ms) : 0, 651473
GlobalTracer [baseline] (293.996 ms) : 0, 293996
GlobalTracer [candidate] (297.094 ms) : 0, 297094
AppSec [baseline] (48.492 ms) : 0, 48492
AppSec [candidate] (49.32 ms) : 0, 49320
Remote Config [baseline] (694.198 µs) : 0, 694
Remote Config [candidate] (707.901 µs) : 0, 708
Telemetry [baseline] (11.208 ms) : 0, 11208
Telemetry [candidate] (11.342 ms) : 0, 11342
section iast
BytebuddyAgent [baseline] (765.805 ms) : 0, 765805
BytebuddyAgent [candidate] (766.698 ms) : 0, 766698
GlobalTracer [baseline] (274.712 ms) : 0, 274712
GlobalTracer [candidate] (275.225 ms) : 0, 275225
AppSec [baseline] (46.599 ms) : 0, 46599
AppSec [candidate] (46.894 ms) : 0, 46894
Remote Config [baseline] (576.867 µs) : 0, 577
Remote Config [candidate] (569.352 µs) : 0, 569
Telemetry [baseline] (12.571 ms) : 0, 12571
Telemetry [candidate] (11.812 ms) : 0, 11812
IAST [baseline] (18.145 ms) : 0, 18145
IAST [candidate] (18.019 ms) : 0, 18019
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (773.144 ms) : 0, 773144
BytebuddyAgent [candidate] (776.74 ms) : 0, 776740
GlobalTracer [baseline] (278.942 ms) : 0, 278942
GlobalTracer [candidate] (280.056 ms) : 0, 280056
AppSec [baseline] (47.278 ms) : 0, 47278
AppSec [candidate] (47.385 ms) : 0, 47385
Remote Config [baseline] (580.266 µs) : 0, 580
Remote Config [candidate] (577.497 µs) : 0, 577
Telemetry [baseline] (12.886 ms) : 0, 12886
Telemetry [candidate] (12.708 ms) : 0, 12708
IAST [baseline] (16.441 ms) : 0, 16441
IAST [candidate] (15.087 ms) : 0, 15087

Load

Parameters

	Baseline	Candidate
commit	1.23.0-SNAPSHOT~d3871dd321	1.23.0-SNAPSHOT~3e3e9e4e48
config	baseline	candidate
end_time	2023-11-07T16:07:59	2023-11-07T16:24:29
start_time	2023-11-07T16:07:46	2023-11-07T16:24:16

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.23.0-SNAPSHOT~3e3e9e4e48, baseline=1.23.0-SNAPSHOT~d3871dd321
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.338 ms) : 1319, 1357
.   : milestone, 1338,
appsec (1.722 ms) : 1698, 1747
.   : milestone, 1722,
iast (1.452 ms) : 1428, 1476
.   : milestone, 1452,
profiling (1.492 ms) : 1466, 1518
.   : milestone, 1492,
tracing (1.433 ms) : 1408, 1457
.   : milestone, 1433,
section candidate
no_agent (1.321 ms) : 1301, 1340
.   : milestone, 1321,
appsec (1.689 ms) : 1664, 1714
.   : milestone, 1689,
iast (1.451 ms) : 1427, 1475
.   : milestone, 1451,
profiling (1.467 ms) : 1440, 1495
.   : milestone, 1467,
tracing (1.473 ms) : 1448, 1499
.   : milestone, 1473,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.338 ms [1.319 ms, 1.357 ms]	-
appsec	1.722 ms [1.698 ms, 1.747 ms]	384.065 µs (28.7%)
iast	1.452 ms [1.428 ms, 1.476 ms]	113.894 µs (8.5%)
profiling	1.492 ms [1.466 ms, 1.518 ms]	153.713 µs (11.5%)
tracing	1.433 ms [1.408 ms, 1.457 ms]	94.205 µs (7.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.321 ms [1.301 ms, 1.34 ms]	-
appsec	1.689 ms [1.664 ms, 1.714 ms]	368.303 µs (27.9%)
iast	1.451 ms [1.427 ms, 1.475 ms]	130.394 µs (9.9%)
profiling	1.467 ms [1.44 ms, 1.495 ms]	146.638 µs (11.1%)
tracing	1.473 ms [1.448 ms, 1.499 ms]	152.661 µs (11.6%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.23.0-SNAPSHOT~3e3e9e4e48, baseline=1.23.0-SNAPSHOT~d3871dd321
    dateFormat X
    axisFormat %s
section baseline
no_agent (363.068 µs) : 343, 384
.   : milestone, 363,
iast (457.239 µs) : 436, 478
.   : milestone, 457,
iast_FULL (515.288 µs) : 495, 536
.   : milestone, 515,
iast_INACTIVE (435.282 µs) : 413, 457
.   : milestone, 435,
iast_TELEMETRY_OFF (457.017 µs) : 436, 478
.   : milestone, 457,
tracing (430.421 µs) : 410, 451
.   : milestone, 430,
section candidate
no_agent (362.952 µs) : 342, 383
.   : milestone, 363,
iast (456.11 µs) : 436, 477
.   : milestone, 456,
iast_FULL (524.028 µs) : 503, 545
.   : milestone, 524,
iast_INACTIVE (433.121 µs) : 412, 454
.   : milestone, 433,
iast_TELEMETRY_OFF (455.606 µs) : 435, 476
.   : milestone, 456,
tracing (434.321 µs) : 413, 456
.   : milestone, 434,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	363.068 µs [342.549 µs, 383.586 µs]	-
iast	457.239 µs [436.257 µs, 478.221 µs]	94.171 µs (25.9%)
iast_FULL	515.288 µs [494.718 µs, 535.858 µs]	152.22 µs (41.9%)
iast_INACTIVE	435.282 µs [413.309 µs, 457.255 µs]	72.214 µs (19.9%)
iast_TELEMETRY_OFF	457.017 µs [435.798 µs, 478.236 µs]	93.949 µs (25.9%)
tracing	430.421 µs [409.803 µs, 451.038 µs]	67.353 µs (18.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	362.952 µs [342.465 µs, 383.44 µs]	-
iast	456.11 µs [435.518 µs, 476.703 µs]	93.158 µs (25.7%)
iast_FULL	524.028 µs [503.251 µs, 544.806 µs]	161.076 µs (44.4%)
iast_INACTIVE	433.121 µs [411.871 µs, 454.371 µs]	70.169 µs (19.3%)
iast_TELEMETRY_OFF	455.606 µs [434.841 µs, 476.372 µs]	92.654 µs (25.5%)
tracing	434.321 µs [412.704 µs, 455.938 µs]	71.369 µs (19.7%)

dd-trace-core/src/main/java/datadog/trace/core/CoreTracer.java

richardstartin force-pushed the rgs/profiler-engine-tag branch 2 times, most recently from 1a66369 to 9757760 Compare November 7, 2023 13:15

richardstartin marked this pull request as ready for review November 7, 2023 13:44

richardstartin requested review from a team as code owners November 7, 2023 13:44

richardstartin requested review from PerfectSlayer, nayeem-kamal and jbachorik November 7, 2023 13:44

jbachorik approved these changes Nov 7, 2023

View reviewed changes

mcculls reviewed Nov 7, 2023

View reviewed changes

dd-trace-core/src/main/java/datadog/trace/core/CoreTracer.java Outdated Show resolved Hide resolved

report profiling context integration on root span

3e3e9e4

richardstartin force-pushed the rgs/profiler-engine-tag branch from 9757760 to 3e3e9e4 Compare November 7, 2023 15:44

mcculls approved these changes Nov 7, 2023

View reviewed changes

richardstartin enabled auto-merge November 7, 2023 16:32

richardstartin merged commit 0a61383 into master Nov 7, 2023
66 of 68 checks passed

richardstartin deleted the rgs/profiler-engine-tag branch November 7, 2023 16:36

github-actions bot added this to the 1.23.0 milestone Nov 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

report profiling context integration on root span #6163

report profiling context integration on root span #6163

richardstartin commented Nov 7, 2023 •

edited by jira bot

Loading

pr-commenter bot commented Nov 7, 2023 •

edited

Loading

report profiling context integration on root span #6163

report profiling context integration on root span #6163

Conversation

richardstartin commented Nov 7, 2023 • edited by jira bot Loading

What Does This Do

Motivation

Additional Notes

pr-commenter bot commented Nov 7, 2023 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

richardstartin commented Nov 7, 2023 •

edited by jira bot

Loading

pr-commenter bot commented Nov 7, 2023 •

edited

Loading