-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable DSM bucket duration #6171
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.25.0-SNAPSHOT~d47fb2241a, baseline=1.25.0-SNAPSHOT~d1eda60b66
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1040855
Total [baseline] (8.699 s) : 0, 8698971
Agent [candidate] (1.041 s) : 0, 1040704
Total [candidate] (8.684 s) : 0, 8683614
section iast
Agent [baseline] (1.156 s) : 0, 1155662
Total [baseline] (9.236 s) : 0, 9235610
Agent [candidate] (1.165 s) : 0, 1164517
Total [candidate] (9.249 s) : 0, 9248773
section iast_TELEMETRY_OFF
Agent [baseline] (1.149 s) : 0, 1148572
Total [baseline] (9.243 s) : 0, 9243008
Agent [candidate] (1.152 s) : 0, 1152186
Total [candidate] (9.218 s) : 0, 9218110
gantt
title insecure-bank - break down per module: candidate=1.25.0-SNAPSHOT~d47fb2241a, baseline=1.25.0-SNAPSHOT~d1eda60b66
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (644.51 ms) : 0, 644510
BytebuddyAgent [candidate] (644.685 ms) : 0, 644685
GlobalTracer [baseline] (305.64 ms) : 0, 305640
GlobalTracer [candidate] (305.587 ms) : 0, 305587
AppSec [baseline] (48.797 ms) : 0, 48797
AppSec [candidate] (48.507 ms) : 0, 48507
Remote Config [baseline] (663.472 µs) : 0, 663
Remote Config [candidate] (672.954 µs) : 0, 673
Telemetry [baseline] (7.034 ms) : 0, 7034
Telemetry [candidate] (7.006 ms) : 0, 7006
section iast
BytebuddyAgent [baseline] (764.021 ms) : 0, 764021
BytebuddyAgent [candidate] (769.026 ms) : 0, 769026
GlobalTracer [baseline] (283.901 ms) : 0, 283901
GlobalTracer [candidate] (285.368 ms) : 0, 285368
AppSec [baseline] (46.125 ms) : 0, 46125
AppSec [candidate] (46.589 ms) : 0, 46589
IAST [baseline] (18.708 ms) : 0, 18708
IAST [candidate] (21.728 ms) : 0, 21728
Remote Config [baseline] (600.495 µs) : 0, 600
Remote Config [candidate] (596.766 µs) : 0, 597
Telemetry [baseline] (8.079 ms) : 0, 8079
Telemetry [candidate] (6.621 ms) : 0, 6621
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (756.545 ms) : 0, 756545
BytebuddyAgent [candidate] (758.184 ms) : 0, 758184
GlobalTracer [baseline] (284.259 ms) : 0, 284259
GlobalTracer [candidate] (285.255 ms) : 0, 285255
AppSec [baseline] (47.138 ms) : 0, 47138
AppSec [candidate] (48.64 ms) : 0, 48640
IAST [baseline] (18.843 ms) : 0, 18843
IAST [candidate] (17.441 ms) : 0, 17441
Remote Config [baseline] (581.851 µs) : 0, 582
Remote Config [candidate] (585.915 µs) : 0, 586
Telemetry [baseline] (7.041 ms) : 0, 7041
Telemetry [candidate] (7.837 ms) : 0, 7837
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.25.0-SNAPSHOT~d47fb2241a, baseline=1.25.0-SNAPSHOT~d1eda60b66
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.039 s) : 0, 1039471
Total [baseline] (9.266 s) : 0, 9266032
Agent [candidate] (1.044 s) : 0, 1044325
Total [candidate] (9.265 s) : 0, 9264685
section appsec
Agent [baseline] (1.132 s) : 0, 1131544
Total [baseline] (9.422 s) : 0, 9422027
Agent [candidate] (1.13 s) : 0, 1130447
Total [candidate] (9.443 s) : 0, 9443277
section iast
Agent [baseline] (1.159 s) : 0, 1158878
Total [baseline] (9.551 s) : 0, 9550598
Agent [candidate] (1.158 s) : 0, 1158371
Total [candidate] (9.594 s) : 0, 9594009
section profiling
Agent [baseline] (1.231 s) : 0, 1231420
Total [baseline] (9.619 s) : 0, 9619181
Agent [candidate] (1.23 s) : 0, 1229805
Total [candidate] (9.591 s) : 0, 9590515
gantt
title petclinic - break down per module: candidate=1.25.0-SNAPSHOT~d47fb2241a, baseline=1.25.0-SNAPSHOT~d1eda60b66
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (643.496 ms) : 0, 643496
BytebuddyAgent [candidate] (645.834 ms) : 0, 645834
GlobalTracer [baseline] (305.365 ms) : 0, 305365
GlobalTracer [candidate] (307.645 ms) : 0, 307645
AppSec [baseline] (48.56 ms) : 0, 48560
AppSec [candidate] (48.716 ms) : 0, 48716
Remote Config [baseline] (674.954 µs) : 0, 675
Remote Config [candidate] (667.222 µs) : 0, 667
Telemetry [baseline] (7.117 ms) : 0, 7117
Telemetry [candidate] (7.111 ms) : 0, 7111
section appsec
BytebuddyAgent [baseline] (645.005 ms) : 0, 645005
BytebuddyAgent [candidate] (645.128 ms) : 0, 645128
GlobalTracer [baseline] (306.212 ms) : 0, 306212
GlobalTracer [candidate] (305.761 ms) : 0, 305761
AppSec [baseline] (136.806 ms) : 0, 136806
AppSec [candidate] (137.235 ms) : 0, 137235
Remote Config [baseline] (639.779 µs) : 0, 640
Remote Config [candidate] (649.204 µs) : 0, 649
Telemetry [baseline] (8.64 ms) : 0, 8640
Telemetry [candidate] (7.501 ms) : 0, 7501
section iast
BytebuddyAgent [baseline] (766.199 ms) : 0, 766199
BytebuddyAgent [candidate] (765.948 ms) : 0, 765948
GlobalTracer [baseline] (284.681 ms) : 0, 284681
GlobalTracer [candidate] (284.545 ms) : 0, 284545
AppSec [baseline] (46.384 ms) : 0, 46384
AppSec [candidate] (46.229 ms) : 0, 46229
Remote Config [baseline] (643.579 µs) : 0, 644
Remote Config [candidate] (663.662 µs) : 0, 664
Telemetry [baseline] (6.599 ms) : 0, 6599
Telemetry [candidate] (6.593 ms) : 0, 6593
IAST [baseline] (20.102 ms) : 0, 20102
IAST [candidate] (20.21 ms) : 0, 20210
section profiling
ProfilingAgent [baseline] (88.782 ms) : 0, 88782
ProfilingAgent [candidate] (88.65 ms) : 0, 88650
BytebuddyAgent [baseline] (655.479 ms) : 0, 655479
BytebuddyAgent [candidate] (654.686 ms) : 0, 654686
GlobalTracer [baseline] (376.441 ms) : 0, 376441
GlobalTracer [candidate] (376.046 ms) : 0, 376046
AppSec [baseline] (48.574 ms) : 0, 48574
AppSec [candidate] (48.374 ms) : 0, 48374
Remote Config [baseline] (686.039 µs) : 0, 686
Remote Config [candidate] (684.272 µs) : 0, 684
Telemetry [baseline] (7.318 ms) : 0, 7318
Telemetry [candidate] (7.351 ms) : 0, 7351
Profiling [baseline] (88.807 ms) : 0, 88807
Profiling [candidate] (88.676 ms) : 0, 88676
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 14 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.25.0-SNAPSHOT~d47fb2241a, baseline=1.25.0-SNAPSHOT~d1eda60b66
dateFormat X
axisFormat %s
section baseline
no_agent (363.384 µs) : 344, 383
. : milestone, 363,
iast (482.822 µs) : 462, 504
. : milestone, 483,
iast_FULL (529.972 µs) : 510, 550
. : milestone, 530,
iast_INACTIVE (440.464 µs) : 420, 461
. : milestone, 440,
iast_TELEMETRY_OFF (468.968 µs) : 448, 490
. : milestone, 469,
tracing (434.624 µs) : 414, 455
. : milestone, 435,
section candidate
no_agent (364.733 µs) : 344, 385
. : milestone, 365,
iast (468.668 µs) : 448, 489
. : milestone, 469,
iast_FULL (533.17 µs) : 513, 554
. : milestone, 533,
iast_INACTIVE (445.49 µs) : 425, 466
. : milestone, 445,
iast_TELEMETRY_OFF (469.675 µs) : 448, 491
. : milestone, 470,
tracing (442.058 µs) : 421, 463
. : milestone, 442,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.25.0-SNAPSHOT~d47fb2241a, baseline=1.25.0-SNAPSHOT~d1eda60b66
dateFormat X
axisFormat %s
section baseline
no_agent (1.346 ms) : 1327, 1365
. : milestone, 1346,
appsec (1.741 ms) : 1716, 1767
. : milestone, 1741,
iast (1.524 ms) : 1499, 1548
. : milestone, 1524,
profiling (1.538 ms) : 1512, 1565
. : milestone, 1538,
tracing (1.484 ms) : 1460, 1509
. : milestone, 1484,
section candidate
no_agent (1.355 ms) : 1336, 1375
. : milestone, 1355,
appsec (1.756 ms) : 1731, 1782
. : milestone, 1756,
iast (1.521 ms) : 1496, 1545
. : milestone, 1521,
profiling (1.513 ms) : 1488, 1539
. : milestone, 1513,
tracing (1.493 ms) : 1469, 1518
. : milestone, 1493,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi 👋
Do you plan to add this settings to the public documentation too?
dd-trace-api/src/main/java/datadog/trace/api/ConfigDefaults.java
Outdated
Show resolved
Hide resolved
dd-trace-core/src/test/groovy/datadog/trace/core/datastreams/DataStreamsWritingTest.groovy
Outdated
Show resolved
Hide resolved
...-core/src/test/groovy/datadog/trace/core/datastreams/DefaultDataStreamsMonitoringTest.groovy
Outdated
Show resolved
Hide resolved
dd-trace-core/src/test/groovy/datadog/trace/core/datastreams/DefaultPathwayContextTest.groovy
Outdated
Show resolved
Hide resolved
…efaultPathwayContextTest.groovy Co-authored-by: Bruce Bujon <PerfectSlayer@users.noreply.github.com>
…ataStreamsWritingTest.groovy Co-authored-by: Bruce Bujon <PerfectSlayer@users.noreply.github.com>
…efaultDataStreamsMonitoringTest.groovy Co-authored-by: Bruce Bujon <PerfectSlayer@users.noreply.github.com>
No, it's really just for testing. Very small bucket sizes would created additional processing load on the backend |
What Does This Do
Allows the bucket duration for datastreams monitoring to be configurable
Motivation
To support future testing. The default of 10 seconds is too slow to test things like dynamic config.