Remove retransformation on failed resolution #6423
Merged
+29
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, in case of failed resolution from probe id we retransformed the current class to make sure the code is in sync with probe definitions. if a loop was still executing instrumented code, this can lead to a storm of retransformation which can hurt significantly performance of the application (retransform is STW). we now do nothing except log a warning and send it as telemetry.
shatzi
approved these changes
Dec 29, 2023
| retransformClasses(Collections.singletonList(callingClass)); | ||
| return null; | ||
| if (definition == null) { | ||
| LOGGER.warn(SEND_TELEMETRY, "Cannot resolve probe id=" + encodedProbeId); |
There was a problem hiding this comment.
does LOGGER.warn is sent to instrumentation telemetry? or that would be on a different PR
There was a problem hiding this comment.
yes it is sent only if DD_TELEMETRY_LOG_COLLECTION_ENABLED is set to true for the moment.
it will be turned to true by default once they assess the volume of log sent with that
| @@ -240,15 +242,10 @@ private void storeDebuggerDefinitions(ConfigurationComparer changes) { | |||
|
|
|||
| // /!\ This is called potentially by multiple threads from the instrumented code /!\ | |||
| @Override | |||
| public ProbeImplementation resolve(String encodedProbeId, Class<?> callingClass) { | |||
| public ProbeImplementation resolve(String encodedProbeId) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Previously, in case of failed resolution from probe id we retransformed the current class to make sure the code is in sync with probe definitions. if a loop was still executing instrumented code, this can lead to a storm of retransformation which can hurt significantly performance of the application (retransform is STW). we now do nothing except log a warning and send it as telemetry.
Motivation
avoid performance issue in rare cases
Additional Notes
Jira ticket: DEBUG-2022