-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add requested and completed times to flare_info.txt #6531
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
added
comp: core
Tracer core
tag: diagnostics
Diagnostics related changes
labels
Jan 22, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 10 unstable metrics. LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.29.0-SNAPSHOT~565a37dc18, baseline=1.29.0-SNAPSHOT~281e492170
dateFormat X
axisFormat %s
section baseline
no_agent (375.259 µs) : 353, 398
. : milestone, 375,
iast (473.673 µs) : 453, 495
. : milestone, 474,
iast_FULL (535.145 µs) : 514, 556
. : milestone, 535,
iast_GLOBAL (508.837 µs) : 486, 531
. : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (476.817 µs) : 456, 498
. : milestone, 477,
iast_INACTIVE (444.617 µs) : 424, 465
. : milestone, 445,
iast_TELEMETRY_OFF (471.199 µs) : 450, 493
. : milestone, 471,
tracing (456.989 µs) : 436, 478
. : milestone, 457,
section candidate
no_agent (369.094 µs) : 349, 389
. : milestone, 369,
iast (469.555 µs) : 449, 490
. : milestone, 470,
iast_FULL (538.561 µs) : 518, 559
. : milestone, 539,
iast_GLOBAL (493.162 µs) : 472, 514
. : milestone, 493,
iast_HARDCODED_SECRET_DISABLED (478.735 µs) : 458, 500
. : milestone, 479,
iast_INACTIVE (445.195 µs) : 424, 466
. : milestone, 445,
iast_TELEMETRY_OFF (466.605 µs) : 446, 487
. : milestone, 467,
tracing (436.09 µs) : 415, 457
. : milestone, 436,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.29.0-SNAPSHOT~565a37dc18, baseline=1.29.0-SNAPSHOT~281e492170
dateFormat X
axisFormat %s
section baseline
no_agent (1.347 ms) : 1328, 1367
. : milestone, 1347,
appsec (1.768 ms) : 1744, 1793
. : milestone, 1768,
iast (1.531 ms) : 1507, 1556
. : milestone, 1531,
profiling (1.583 ms) : 1557, 1609
. : milestone, 1583,
tracing (1.508 ms) : 1483, 1534
. : milestone, 1508,
section candidate
no_agent (1.354 ms) : 1335, 1373
. : milestone, 1354,
appsec (1.755 ms) : 1729, 1780
. : milestone, 1755,
iast (1.53 ms) : 1505, 1555
. : milestone, 1530,
profiling (1.506 ms) : 1480, 1532
. : milestone, 1506,
tracing (1.508 ms) : 1483, 1533
. : milestone, 1508,
|
mcculls
force-pushed
the
mcculls/tracer-flare-record-times
branch
2 times, most recently
from
January 22, 2024 16:55
a835bba
to
295ffbc
Compare
mcculls
force-pushed
the
mcculls/tracer-flare-record-times
branch
from
January 24, 2024 22:01
295ffbc
to
15e086a
Compare
mcculls
force-pushed
the
mcculls/tracer-flare-record-times
branch
from
January 29, 2024 17:10
15e086a
to
8998d4a
Compare
mcculls
force-pushed
the
mcculls/tracer-flare-record-times
branch
from
January 29, 2024 21:32
8998d4a
to
565a37d
Compare
PerfectSlayer
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Makes it easier to identify what period the tracer flare covers.
Jira ticket: APMJAVA-1078