Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requested and completed times to flare_info.txt #6531

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Jan 22, 2024

Motivation

Makes it easier to identify what period the tracer flare covers.

Jira ticket: APMJAVA-1078

@mcculls mcculls added comp: core Tracer core tag: diagnostics Diagnostics related changes labels Jan 22, 2024
@mcculls mcculls marked this pull request as ready for review January 22, 2024 12:08
@mcculls mcculls requested a review from a team as a code owner January 22, 2024 12:08
@mcculls mcculls requested review from dougqh and am312 January 22, 2024 12:08
@pr-commenter
Copy link

pr-commenter bot commented Jan 22, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/tracer-flare-record-times
git_commit_date 1706562398 1706563785
git_commit_sha 281e492 565a37d
release_version 1.29.0-SNAPSHOT~281e492170 1.29.0-SNAPSHOT~565a37dc18
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1706566777 1706566777
ci_job_id 421142369 421142369
ci_pipeline_id 27356762 27356762
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 10 unstable metrics.

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-01-29T21:55:40 2024-01-29T22:14:35
git_branch master mcculls/tracer-flare-record-times
git_commit_date 1706562398 1706563785
git_commit_sha 281e492 565a37d
release_version 1.29.0-SNAPSHOT~281e492170 1.29.0-SNAPSHOT~565a37dc18
start_time 2024-01-29T21:55:27 2024-01-29T22:14:22
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1706566777 1706566777
ci_job_id 421142369 421142369
ci_pipeline_id 27356762 27356762
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 15 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling better
[-105.379µs; -49.332µs] or [-6.656%; -3.116%]
unstable
[-445.375op/s; +673.295op/s] or [-15.031%; +22.724%]
1.506ms 3076.923op/s 1.583ms 2962.963op/s
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.29.0-SNAPSHOT~565a37dc18, baseline=1.29.0-SNAPSHOT~281e492170
    dateFormat X
    axisFormat %s
section baseline
no_agent (375.259 µs) : 353, 398
.   : milestone, 375,
iast (473.673 µs) : 453, 495
.   : milestone, 474,
iast_FULL (535.145 µs) : 514, 556
.   : milestone, 535,
iast_GLOBAL (508.837 µs) : 486, 531
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (476.817 µs) : 456, 498
.   : milestone, 477,
iast_INACTIVE (444.617 µs) : 424, 465
.   : milestone, 445,
iast_TELEMETRY_OFF (471.199 µs) : 450, 493
.   : milestone, 471,
tracing (456.989 µs) : 436, 478
.   : milestone, 457,
section candidate
no_agent (369.094 µs) : 349, 389
.   : milestone, 369,
iast (469.555 µs) : 449, 490
.   : milestone, 470,
iast_FULL (538.561 µs) : 518, 559
.   : milestone, 539,
iast_GLOBAL (493.162 µs) : 472, 514
.   : milestone, 493,
iast_HARDCODED_SECRET_DISABLED (478.735 µs) : 458, 500
.   : milestone, 479,
iast_INACTIVE (445.195 µs) : 424, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (466.605 µs) : 446, 487
.   : milestone, 467,
tracing (436.09 µs) : 415, 457
.   : milestone, 436,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 375.259 µs [352.956 µs, 397.562 µs] -
iast 473.673 µs [452.597 µs, 494.749 µs] 98.414 µs (26.2%)
iast_FULL 535.145 µs [514.493 µs, 555.798 µs] 159.887 µs (42.6%)
iast_GLOBAL 508.837 µs [486.221 µs, 531.453 µs] 133.578 µs (35.6%)
iast_HARDCODED_SECRET_DISABLED 476.817 µs [455.757 µs, 497.877 µs] 101.558 µs (27.1%)
iast_INACTIVE 444.617 µs [423.961 µs, 465.272 µs] 69.358 µs (18.5%)
iast_TELEMETRY_OFF 471.199 µs [449.75 µs, 492.649 µs] 95.94 µs (25.6%)
tracing 456.989 µs [435.843 µs, 478.134 µs] 81.73 µs (21.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.094 µs [349.141 µs, 389.046 µs] -
iast 469.555 µs [449.147 µs, 489.963 µs] 100.462 µs (27.2%)
iast_FULL 538.561 µs [517.873 µs, 559.249 µs] 169.467 µs (45.9%)
iast_GLOBAL 493.162 µs [472.359 µs, 513.966 µs] 124.069 µs (33.6%)
iast_HARDCODED_SECRET_DISABLED 478.735 µs [457.693 µs, 499.777 µs] 109.642 µs (29.7%)
iast_INACTIVE 445.195 µs [424.296 µs, 466.094 µs] 76.101 µs (20.6%)
iast_TELEMETRY_OFF 466.605 µs [446.136 µs, 487.074 µs] 97.511 µs (26.4%)
tracing 436.09 µs [415.436 µs, 456.744 µs] 66.996 µs (18.2%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.29.0-SNAPSHOT~565a37dc18, baseline=1.29.0-SNAPSHOT~281e492170
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.347 ms) : 1328, 1367
.   : milestone, 1347,
appsec (1.768 ms) : 1744, 1793
.   : milestone, 1768,
iast (1.531 ms) : 1507, 1556
.   : milestone, 1531,
profiling (1.583 ms) : 1557, 1609
.   : milestone, 1583,
tracing (1.508 ms) : 1483, 1534
.   : milestone, 1508,
section candidate
no_agent (1.354 ms) : 1335, 1373
.   : milestone, 1354,
appsec (1.755 ms) : 1729, 1780
.   : milestone, 1755,
iast (1.53 ms) : 1505, 1555
.   : milestone, 1530,
profiling (1.506 ms) : 1480, 1532
.   : milestone, 1506,
tracing (1.508 ms) : 1483, 1533
.   : milestone, 1508,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.347 ms [1.328 ms, 1.367 ms] -
appsec 1.768 ms [1.744 ms, 1.793 ms] 420.812 µs (31.2%)
iast 1.531 ms [1.507 ms, 1.556 ms] 183.933 µs (13.7%)
profiling 1.583 ms [1.557 ms, 1.609 ms] 235.834 µs (17.5%)
tracing 1.508 ms [1.483 ms, 1.534 ms] 160.895 µs (11.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.335 ms, 1.373 ms] -
appsec 1.755 ms [1.729 ms, 1.78 ms] 400.323 µs (29.6%)
iast 1.53 ms [1.505 ms, 1.555 ms] 175.754 µs (13.0%)
profiling 1.506 ms [1.48 ms, 1.532 ms] 151.769 µs (11.2%)
tracing 1.508 ms [1.483 ms, 1.533 ms] 153.706 µs (11.4%)

@mcculls mcculls force-pushed the mcculls/tracer-flare-record-times branch 2 times, most recently from a835bba to 295ffbc Compare January 22, 2024 16:55
@mcculls mcculls force-pushed the mcculls/tracer-flare-record-times branch from 295ffbc to 15e086a Compare January 24, 2024 22:01
@mcculls mcculls force-pushed the mcculls/tracer-flare-record-times branch from 15e086a to 8998d4a Compare January 29, 2024 17:10
@mcculls mcculls force-pushed the mcculls/tracer-flare-record-times branch from 8998d4a to 565a37d Compare January 29, 2024 21:32
@mcculls mcculls merged commit fe0f79e into master Feb 1, 2024
80 checks passed
@mcculls mcculls deleted the mcculls/tracer-flare-record-times branch February 1, 2024 13:37
@github-actions github-actions bot added this to the 1.29.0 milestone Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: core Tracer core tag: diagnostics Diagnostics related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants