-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WAF bindings to 9.0.2 (fixes segmentation fault) (v1.30.x backport of #6705) #6710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smola
changed the title
Update WAF bindings to 9.0.2 (#6705) (v1.30.x backport)
Update WAF bindings to 9.0.2 (fixes segmentation fault) (v1.30.x backport of #6705)
Feb 21, 2024
ValentinZakharov
approved these changes
Feb 21, 2024
smola
force-pushed
the
smola/pr-6705-backport-v1.30.x
branch
from
February 21, 2024 16:43
f2c072d
to
fb879df
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 41 metrics, 11 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.31.0-SNAPSHOT~fb879df433, baseline=1.31.0-SNAPSHOT~82bc109a42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1083276
Total [baseline] (9.216 s) : 0, 9216458
Agent [candidate] (1.075 s) : 0, 1075342
Total [candidate] (9.461 s) : 0, 9461010
section appsec
Agent [baseline] (1.185 s) : 0, 1185131
Total [baseline] (9.359 s) : 0, 9359429
Agent [candidate] (1.175 s) : 0, 1174623
Total [candidate] (9.489 s) : 0, 9488997
section iast
Agent [baseline] (1.211 s) : 0, 1210625
Total [baseline] (9.41 s) : 0, 9409644
Agent [candidate] (1.186 s) : 0, 1186162
Total [candidate] (9.689 s) : 0, 9689094
section profiling
Agent [baseline] (1.29 s) : 0, 1289508
Total [baseline] (9.389 s) : 0, 9389208
Agent [candidate] (1.28 s) : 0, 1279741
Total [candidate] (9.592 s) : 0, 9591977
gantt
title petclinic - break down per module: candidate=1.31.0-SNAPSHOT~fb879df433, baseline=1.31.0-SNAPSHOT~82bc109a42
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.038 ms) : 0, 690038
BytebuddyAgent [candidate] (676.925 ms) : 0, 676925
GlobalTracer [baseline] (298.468 ms) : 0, 298468
GlobalTracer [candidate] (302.654 ms) : 0, 302654
AppSec [baseline] (51.757 ms) : 0, 51757
AppSec [candidate] (52.584 ms) : 0, 52584
Remote Config [baseline] (723.064 µs) : 0, 723
Remote Config [candidate] (709.551 µs) : 0, 710
Telemetry [baseline] (7.824 ms) : 0, 7824
Telemetry [candidate] (7.711 ms) : 0, 7711
section appsec
BytebuddyAgent [baseline] (691.612 ms) : 0, 691612
BytebuddyAgent [candidate] (677.752 ms) : 0, 677752
GlobalTracer [baseline] (299.719 ms) : 0, 299719
GlobalTracer [candidate] (302.511 ms) : 0, 302511
AppSec [baseline] (151.599 ms) : 0, 151599
AppSec [candidate] (152.007 ms) : 0, 152007
Remote Config [baseline] (642.4 µs) : 0, 642
Remote Config [candidate] (642.752 µs) : 0, 643
Telemetry [baseline] (6.954 ms) : 0, 6954
Telemetry [candidate] (6.921 ms) : 0, 6921
section iast
BytebuddyAgent [baseline] (802.224 ms) : 0, 802224
BytebuddyAgent [candidate] (779.423 ms) : 0, 779423
GlobalTracer [baseline] (290.229 ms) : 0, 290229
GlobalTracer [candidate] (290.53 ms) : 0, 290530
AppSec [baseline] (54.923 ms) : 0, 54923
AppSec [candidate] (54.651 ms) : 0, 54651
Remote Config [baseline] (623.741 µs) : 0, 624
Remote Config [candidate] (604.508 µs) : 0, 605
Telemetry [baseline] (6.582 ms) : 0, 6582
Telemetry [candidate] (6.594 ms) : 0, 6594
IAST [baseline] (21.413 ms) : 0, 21413
IAST [candidate] (19.965 ms) : 0, 19965
section profiling
ProfilingAgent [baseline] (111.72 ms) : 0, 111720
ProfilingAgent [candidate] (110.491 ms) : 0, 110491
BytebuddyAgent [baseline] (678.536 ms) : 0, 678536
BytebuddyAgent [candidate] (666.817 ms) : 0, 666817
GlobalTracer [baseline] (379.37 ms) : 0, 379370
GlobalTracer [candidate] (383.139 ms) : 0, 383139
AppSec [baseline] (53.035 ms) : 0, 53035
AppSec [candidate] (51.931 ms) : 0, 51931
Remote Config [baseline] (826.693 µs) : 0, 827
Remote Config [candidate] (657.466 µs) : 0, 657
Telemetry [baseline] (10.182 ms) : 0, 10182
Telemetry [candidate] (12.045 ms) : 0, 12045
Profiling [baseline] (111.744 ms) : 0, 111744
Profiling [candidate] (110.515 ms) : 0, 110515
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 14 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~fb879df433, baseline=1.31.0-SNAPSHOT~82bc109a42
dateFormat X
axisFormat %s
section baseline
no_agent (1.372 ms) : 1353, 1391
. : milestone, 1372,
appsec (1.77 ms) : 1746, 1794
. : milestone, 1770,
iast (1.548 ms) : 1524, 1571
. : milestone, 1548,
profiling (1.528 ms) : 1502, 1553
. : milestone, 1528,
tracing (1.534 ms) : 1511, 1557
. : milestone, 1534,
section candidate
no_agent (1.352 ms) : 1333, 1370
. : milestone, 1352,
appsec (1.769 ms) : 1743, 1794
. : milestone, 1769,
iast (1.529 ms) : 1505, 1554
. : milestone, 1529,
profiling (1.526 ms) : 1500, 1552
. : milestone, 1526,
tracing (1.514 ms) : 1489, 1539
. : milestone, 1514,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~fb879df433, baseline=1.31.0-SNAPSHOT~82bc109a42
dateFormat X
axisFormat %s
section baseline
no_agent (368.074 µs) : 348, 388
. : milestone, 368,
iast (483.106 µs) : 463, 504
. : milestone, 483,
iast_FULL (549.023 µs) : 528, 570
. : milestone, 549,
iast_GLOBAL (506.167 µs) : 486, 527
. : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (486.824 µs) : 466, 508
. : milestone, 487,
iast_INACTIVE (452.805 µs) : 432, 474
. : milestone, 453,
iast_TELEMETRY_OFF (480.332 µs) : 460, 501
. : milestone, 480,
tracing (450.23 µs) : 430, 471
. : milestone, 450,
section candidate
no_agent (376.698 µs) : 355, 398
. : milestone, 377,
iast (472.835 µs) : 452, 493
. : milestone, 473,
iast_FULL (539.833 µs) : 519, 560
. : milestone, 540,
iast_GLOBAL (490.233 µs) : 470, 511
. : milestone, 490,
iast_HARDCODED_SECRET_DISABLED (481.437 µs) : 461, 502
. : milestone, 481,
iast_INACTIVE (451.907 µs) : 431, 473
. : milestone, 452,
iast_TELEMETRY_OFF (477.181 µs) : 456, 498
. : milestone, 477,
tracing (445.348 µs) : 425, 466
. : milestone, 445,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Backport of #6705
Motivation
Fix libddwaf segmentation fault in dd-trace-java v1.30.x when
DD_APPSEC_ENABLED=true
.Additional Notes
Jira ticket: APPSEC-51827