Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JUnit 4 method name extraction logic to properly handle Kotlin test names #6751

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Update JUnit 4 method name extraction logic to properly handle Kotlin test names #6751

merged 4 commits into from
Feb 29, 2024

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Feb 28, 2024 •
edited
Loading

What Does This Do

Updates method name extraction logic for JUnit 4 test cases to properly handle Kotlin test names that contain ( and ) characters.

Jira ticket: CIVIS-9263

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the comp: ci visibility Continuous Integration Visibility label Feb 28, 2024
@pr-commenter
Copy link

pr-commenter bot commented Feb 28, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/fix-junit4-kotlin-method-names
git_commit_date 1709151180 1709197307
git_commit_sha ac4e2fc 69efc6e
release_version 1.31.0-SNAPSHOT~ac4e2fceec 1.31.0-SNAPSHOT~69efc6e7d1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1709200310 1709200310
ci_job_id 446734478 446734478
ci_pipeline_id 29187636 29187636
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 8 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.31.0-SNAPSHOT~69efc6e7d1, baseline=1.31.0-SNAPSHOT~ac4e2fceec

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1085810
Total [baseline] (9.159 s) : 0, 9159273
Agent [candidate] (1.086 s) : 0, 1086076
Total [candidate] (9.191 s) : 0, 9190614
section appsec
Agent [baseline] (1.182 s) : 0, 1182271
Total [baseline] (9.336 s) : 0, 9336252
Agent [candidate] (1.182 s) : 0, 1182177
Total [candidate] (9.353 s) : 0, 9353439
section iast
Agent [baseline] (1.205 s) : 0, 1205292
Total [baseline] (9.361 s) : 0, 9360681
Agent [candidate] (1.213 s) : 0, 1213122
Total [candidate] (9.478 s) : 0, 9478211
section profiling
Agent [baseline] (1.277 s) : 0, 1277314
Total [baseline] (9.343 s) : 0, 9342519
Agent [candidate] (1.282 s) : 0, 1281852
Total [candidate] (9.415 s) : 0, 9414762
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent appsec 1.182 s 96.461 ms (8.9%)
Agent iast 1.205 s 119.482 ms (11.0%)
Agent profiling 1.277 s 191.505 ms (17.6%)
Total tracing 9.159 s -
Total appsec 9.336 s 176.979 ms (1.9%)
Total iast 9.361 s 201.408 ms (2.2%)
Total profiling 9.343 s 183.246 ms (2.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent appsec 1.182 s 96.101 ms (8.8%)
Agent iast 1.213 s 127.046 ms (11.7%)
Agent profiling 1.282 s 195.776 ms (18.0%)
Total tracing 9.191 s -
Total appsec 9.353 s 162.824 ms (1.8%)
Total iast 9.478 s 287.597 ms (3.1%)
Total profiling 9.415 s 224.148 ms (2.4%) 
gantt
    title petclinic - break down per module: candidate=1.31.0-SNAPSHOT~69efc6e7d1, baseline=1.31.0-SNAPSHOT~ac4e2fceec

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.07 ms) : 0, 692070
BytebuddyAgent [candidate] (692.374 ms) : 0, 692374
GlobalTracer [baseline] (299.026 ms) : 0, 299026
GlobalTracer [candidate] (299.132 ms) : 0, 299132
AppSec [baseline] (51.598 ms) : 0, 51598
AppSec [candidate] (51.441 ms) : 0, 51441
Remote Config [baseline] (722.911 µs) : 0, 723
Remote Config [candidate] (725.344 µs) : 0, 725
Telemetry [baseline] (7.873 ms) : 0, 7873
Telemetry [candidate] (7.9 ms) : 0, 7900
section appsec
BytebuddyAgent [baseline] (690.819 ms) : 0, 690819
BytebuddyAgent [candidate] (691.241 ms) : 0, 691241
GlobalTracer [baseline] (298.412 ms) : 0, 298412
GlobalTracer [candidate] (297.636 ms) : 0, 297636
AppSec [baseline] (151.027 ms) : 0, 151027
AppSec [candidate] (151.201 ms) : 0, 151201
Remote Config [baseline] (634.147 µs) : 0, 634
Remote Config [candidate] (643.385 µs) : 0, 643
Telemetry [baseline] (6.919 ms) : 0, 6919
Telemetry [candidate] (6.944 ms) : 0, 6944
section iast
BytebuddyAgent [baseline] (798.923 ms) : 0, 798923
BytebuddyAgent [candidate] (806.583 ms) : 0, 806583
GlobalTracer [baseline] (288.736 ms) : 0, 288736
GlobalTracer [candidate] (289.793 ms) : 0, 289793
AppSec [baseline] (51.089 ms) : 0, 51089
AppSec [candidate] (52.303 ms) : 0, 52303
Remote Config [baseline] (595.037 µs) : 0, 595
Remote Config [candidate] (604.862 µs) : 0, 605
Telemetry [baseline] (6.64 ms) : 0, 6640
Telemetry [candidate] (6.728 ms) : 0, 6728
IAST [baseline] (24.909 ms) : 0, 24909
IAST [candidate] (22.498 ms) : 0, 22498
section profiling
BytebuddyAgent [baseline] (682.961 ms) : 0, 682961
BytebuddyAgent [candidate] (684.828 ms) : 0, 684828
GlobalTracer [baseline] (381.072 ms) : 0, 381072
GlobalTracer [candidate] (383.434 ms) : 0, 383434
AppSec [baseline] (52.945 ms) : 0, 52945
AppSec [candidate] (52.823 ms) : 0, 52823
Remote Config [baseline] (775.104 µs) : 0, 775
Remote Config [candidate] (776.99 µs) : 0, 777
Telemetry [baseline] (11.61 ms) : 0, 11610
Telemetry [candidate] (9.796 ms) : 0, 9796
ProfilingAgent [baseline] (91.406 ms) : 0, 91406
ProfilingAgent [candidate] (93.747 ms) : 0, 93747
Profiling [baseline] (91.43 ms) : 0, 91430
Profiling [candidate] (93.771 ms) : 0, 93771
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-02-29T09:28:13 2024-02-29T09:46:50
git_branch master nikita-tkachenko/fix-junit4-kotlin-method-names
git_commit_date 1709151180 1709197307
git_commit_sha ac4e2fc 69efc6e
release_version 1.31.0-SNAPSHOT~ac4e2fceec 1.31.0-SNAPSHOT~69efc6e7d1
start_time 2024-02-29T09:28:00 2024-02-29T09:46:37
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1709200310 1709200310
ci_job_id 446734478 446734478
ci_pipeline_id 29187636 29187636
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 15 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~69efc6e7d1, baseline=1.31.0-SNAPSHOT~ac4e2fceec
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.348 ms) : 1329, 1367
.   : milestone, 1348,
appsec (1.79 ms) : 1766, 1813
.   : milestone, 1790,
iast (1.55 ms) : 1527, 1573
.   : milestone, 1550,
profiling (1.518 ms) : 1494, 1541
.   : milestone, 1518,
tracing (1.508 ms) : 1485, 1532
.   : milestone, 1508,
section candidate
no_agent (1.353 ms) : 1334, 1372
.   : milestone, 1353,
appsec (1.8 ms) : 1776, 1823
.   : milestone, 1800,
iast (1.509 ms) : 1486, 1533
.   : milestone, 1509,
profiling (1.561 ms) : 1536, 1585
.   : milestone, 1561,
tracing (1.494 ms) : 1470, 1517
.   : milestone, 1494,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.348 ms [1.329 ms, 1.367 ms] -
appsec 1.79 ms [1.766 ms, 1.813 ms] 441.659 µs (32.8%)
iast 1.55 ms [1.527 ms, 1.573 ms] 201.965 µs (15.0%)
profiling 1.518 ms [1.494 ms, 1.541 ms] 169.823 µs (12.6%)
tracing 1.508 ms [1.485 ms, 1.532 ms] 160.525 µs (11.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.353 ms [1.334 ms, 1.372 ms] -
appsec 1.8 ms [1.776 ms, 1.823 ms] 447.173 µs (33.1%)
iast 1.509 ms [1.486 ms, 1.533 ms] 156.773 µs (11.6%)
profiling 1.561 ms [1.536 ms, 1.585 ms] 207.841 µs (15.4%)
tracing 1.494 ms [1.47 ms, 1.517 ms] 140.946 µs (10.4%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~69efc6e7d1, baseline=1.31.0-SNAPSHOT~ac4e2fceec
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.513 µs) : 346, 387
.   : milestone, 367,
iast (472.679 µs) : 452, 493
.   : milestone, 473,
iast_FULL (533.387 µs) : 513, 554
.   : milestone, 533,
iast_GLOBAL (492.543 µs) : 471, 514
.   : milestone, 493,
iast_HARDCODED_SECRET_DISABLED (468.135 µs) : 448, 489
.   : milestone, 468,
iast_INACTIVE (451.743 µs) : 431, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (475.523 µs) : 454, 497
.   : milestone, 476,
tracing (450.933 µs) : 430, 472
.   : milestone, 451,
section candidate
no_agent (365.152 µs) : 344, 386
.   : milestone, 365,
iast (473.401 µs) : 452, 494
.   : milestone, 473,
iast_FULL (537.962 µs) : 517, 558
.   : milestone, 538,
iast_GLOBAL (491.153 µs) : 471, 511
.   : milestone, 491,
iast_HARDCODED_SECRET_DISABLED (474.805 µs) : 454, 496
.   : milestone, 475,
iast_INACTIVE (451.086 µs) : 430, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (465.37 µs) : 445, 486
.   : milestone, 465,
tracing (444.26 µs) : 424, 465
.   : milestone, 444,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.513 µs [346.289 µs, 386.738 µs] -
iast 472.679 µs [452.111 µs, 493.248 µs] 106.166 µs (29.0%)
iast_FULL 533.387 µs [512.896 µs, 553.879 µs] 166.874 µs (45.5%)
iast_GLOBAL 492.543 µs [471.08 µs, 514.005 µs] 126.029 µs (34.4%)
iast_HARDCODED_SECRET_DISABLED 468.135 µs [447.748 µs, 488.522 µs] 101.622 µs (27.7%)
iast_INACTIVE 451.743 µs [430.896 µs, 472.59 µs] 85.229 µs (23.3%)
iast_TELEMETRY_OFF 475.523 µs [454.456 µs, 496.589 µs] 109.009 µs (29.7%)
tracing 450.933 µs [430.094 µs, 471.773 µs] 84.42 µs (23.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.152 µs [343.999 µs, 386.305 µs] -
iast 473.401 µs [452.468 µs, 494.334 µs] 108.249 µs (29.6%)
iast_FULL 537.962 µs [517.481 µs, 558.442 µs] 172.81 µs (47.3%)
iast_GLOBAL 491.153 µs [470.843 µs, 511.464 µs] 126.002 µs (34.5%)
iast_HARDCODED_SECRET_DISABLED 474.805 µs [453.756 µs, 495.855 µs] 109.654 µs (30.0%)
iast_INACTIVE 451.086 µs [429.778 µs, 472.394 µs] 85.934 µs (23.5%)
iast_TELEMETRY_OFF 465.37 µs [444.781 µs, 485.959 µs] 100.218 µs (27.4%)
tracing 444.26 µs [423.986 µs, 464.534 µs] 79.108 µs (21.7%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review February 28, 2024 14:16
@nikita-tkachenko-datadog nikita-tkachenko-datadog force-pushed the nikita-tkachenko/fix-junit4-kotlin-method-names branch from 491e80b to 69efc6e Compare February 29, 2024 09:02
@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 487a9e0 into master Feb 29, 2024
129 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/fix-junit4-kotlin-method-names branch February 29, 2024 12:27
@github-actions github-actions bot added this to the 1.31.0 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan-fernandez juan-fernandez juan-fernandez approved these changes

Assignees
No one assigned
Labels
comp: ci visibility Continuous Integration Visibility run-tests: all Run all tests
Projects
None yet
Milestone
1.31.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nikita-tkachenko-datadog @juan-fernandez