Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use real time threshold for queue times #6976

Merged
merged 1 commit into from
May 1, 2024
Merged

use real time threshold for queue times #6976

merged 1 commit into from
May 1, 2024

Conversation

richardstartin
Copy link
Member

What Does This Do

This fixes a design flaw where RDTSC derived values are compared across cores which can have frequency scaling applied differently, and just uses the system time instead for the sake of computing the threshold.

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

@pr-commenter
Copy link

pr-commenter bot commented Apr 30, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master rgs/real-queuetime-threshold
git_commit_date 1714499775 1714504044
git_commit_sha 16c56bf 78012cf
release_version 1.34.0-SNAPSHOT~16c56bf74f 1.34.0-SNAPSHOT~78012cfa5d
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1714506723 1714506723
ci_job_id 501279853 501279853
ci_pipeline_id 33297671 33297671
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 16 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~78012cfa5d, baseline=1.34.0-SNAPSHOT~16c56bf74f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1083794
Total [baseline] (10.37 s) : 0, 10369559
Agent [candidate] (1.078 s) : 0, 1077526
Total [candidate] (10.398 s) : 0, 10397602
section appsec
Agent [baseline] (1.192 s) : 0, 1192363
Total [baseline] (10.423 s) : 0, 10423466
Agent [candidate] (1.195 s) : 0, 1194746
Total [candidate] (10.466 s) : 0, 10466179
section iast
Agent [baseline] (1.202 s) : 0, 1202051
Total [baseline] (10.7 s) : 0, 10700403
Agent [candidate] (1.219 s) : 0, 1219398
Total [candidate] (10.765 s) : 0, 10764648
section profiling
Agent [baseline] (1.27 s) : 0, 1269780
Total [baseline] (10.631 s) : 0, 10631005
Agent [candidate] (1.28 s) : 0, 1280056
Total [candidate] (10.62 s) : 0, 10620013
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent appsec 1.192 s 108.569 ms (10.0%)
Agent iast 1.202 s 118.258 ms (10.9%)
Agent profiling 1.27 s 185.986 ms (17.2%)
Total tracing 10.37 s -
Total appsec 10.423 s 53.907 ms (0.5%)
Total iast 10.7 s 330.844 ms (3.2%)
Total profiling 10.631 s 261.446 ms (2.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent appsec 1.195 s 117.22 ms (10.9%)
Agent iast 1.219 s 141.872 ms (13.2%)
Agent profiling 1.28 s 202.531 ms (18.8%)
Total tracing 10.398 s -
Total appsec 10.466 s 68.577 ms (0.7%)
Total iast 10.765 s 367.045 ms (3.5%)
Total profiling 10.62 s 222.41 ms (2.1%) 
gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~78012cfa5d, baseline=1.34.0-SNAPSHOT~16c56bf74f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (678.988 ms) : 0, 678988
BytebuddyAgent [candidate] (674.982 ms) : 0, 674982
GlobalTracer [baseline] (312.256 ms) : 0, 312256
GlobalTracer [candidate] (310.554 ms) : 0, 310554
AppSec [baseline] (49.754 ms) : 0, 49754
AppSec [candidate] (49.36 ms) : 0, 49360
Remote Config [baseline] (663.42 µs) : 0, 663
Remote Config [candidate] (658.915 µs) : 0, 659
Telemetry [baseline] (7.541 ms) : 0, 7541
Telemetry [candidate] (7.546 ms) : 0, 7546
section appsec
BytebuddyAgent [baseline] (697.048 ms) : 0, 697048
BytebuddyAgent [candidate] (698.984 ms) : 0, 698984
GlobalTracer [baseline] (292.134 ms) : 0, 292134
GlobalTracer [candidate] (292.85 ms) : 0, 292850
AppSec [baseline] (149.375 ms) : 0, 149375
AppSec [candidate] (149.325 ms) : 0, 149325
IAST [baseline] (19.303 ms) : 0, 19303
IAST [candidate] (19.193 ms) : 0, 19193
Remote Config [baseline] (622.851 µs) : 0, 623
Remote Config [candidate] (636.416 µs) : 0, 636
Telemetry [baseline] (9.075 ms) : 0, 9075
Telemetry [candidate] (8.825 ms) : 0, 8825
section iast
BytebuddyAgent [baseline] (796.33 ms) : 0, 796330
BytebuddyAgent [candidate] (808.178 ms) : 0, 808178
GlobalTracer [baseline] (289.256 ms) : 0, 289256
GlobalTracer [candidate] (292.868 ms) : 0, 292868
AppSec [baseline] (50.334 ms) : 0, 50334
AppSec [candidate] (49.535 ms) : 0, 49535
IAST [baseline] (23.155 ms) : 0, 23155
IAST [candidate] (25.865 ms) : 0, 25865
Remote Config [baseline] (1.303 ms) : 0, 1303
Remote Config [candidate] (1.369 ms) : 0, 1369
Telemetry [baseline] (7.345 ms) : 0, 7345
Telemetry [candidate] (6.669 ms) : 0, 6669
section profiling
BytebuddyAgent [baseline] (679.145 ms) : 0, 679145
BytebuddyAgent [candidate] (684.293 ms) : 0, 684293
GlobalTracer [baseline] (381.22 ms) : 0, 381220
GlobalTracer [candidate] (383.303 ms) : 0, 383303
AppSec [baseline] (49.898 ms) : 0, 49898
AppSec [candidate] (50.452 ms) : 0, 50452
Remote Config [baseline] (716.246 µs) : 0, 716
Remote Config [candidate] (709.198 µs) : 0, 709
Telemetry [baseline] (7.473 ms) : 0, 7473
Telemetry [candidate] (7.602 ms) : 0, 7602
ProfilingAgent [baseline] (95.002 ms) : 0, 95002
ProfilingAgent [candidate] (96.738 ms) : 0, 96738
Profiling [baseline] (95.026 ms) : 0, 95026
Profiling [candidate] (96.761 ms) : 0, 96761
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~78012cfa5d, baseline=1.34.0-SNAPSHOT~16c56bf74f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.077 s) : 0, 1076920
Total [baseline] (8.545 s) : 0, 8544576
Agent [candidate] (1.078 s) : 0, 1077700
Total [candidate] (8.553 s) : 0, 8552748
section iast
Agent [baseline] (1.202 s) : 0, 1201973
Total [baseline] (9.003 s) : 0, 9002686
Agent [candidate] (1.201 s) : 0, 1201239
Total [candidate] (9.017 s) : 0, 9016589
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.199 s) : 0, 1198867
Total [baseline] (8.992 s) : 0, 8991877
Agent [candidate] (1.21 s) : 0, 1210381
Total [candidate] (9.034 s) : 0, 9033670
section iast_TELEMETRY_OFF
Agent [baseline] (1.201 s) : 0, 1200611
Total [baseline] (8.997 s) : 0, 8997410
Agent [candidate] (1.208 s) : 0, 1208362
Total [candidate] (9.023 s) : 0, 9023338
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent iast 1.202 s 125.054 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.199 s 121.948 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.201 s 123.691 ms (11.5%)
Total tracing 8.545 s -
Total iast 9.003 s 458.11 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.992 s 447.302 ms (5.2%)
Total iast_TELEMETRY_OFF 8.997 s 452.834 ms (5.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent iast 1.201 s 123.539 ms (11.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.21 s 132.681 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.208 s 130.662 ms (12.1%)
Total tracing 8.553 s -
Total iast 9.017 s 463.841 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.034 s 480.923 ms (5.6%)
Total iast_TELEMETRY_OFF 9.023 s 470.59 ms (5.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~78012cfa5d, baseline=1.34.0-SNAPSHOT~16c56bf74f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.56 ms) : 0, 674560
BytebuddyAgent [candidate] (675.155 ms) : 0, 675155
GlobalTracer [baseline] (310.331 ms) : 0, 310331
GlobalTracer [candidate] (310.471 ms) : 0, 310471
AppSec [baseline] (49.37 ms) : 0, 49370
AppSec [candidate] (49.398 ms) : 0, 49398
Remote Config [baseline] (654.382 µs) : 0, 654
Remote Config [candidate] (663.425 µs) : 0, 663
Telemetry [baseline] (7.559 ms) : 0, 7559
Telemetry [candidate] (7.619 ms) : 0, 7619
section iast
BytebuddyAgent [baseline] (795.992 ms) : 0, 795992
BytebuddyAgent [candidate] (795.534 ms) : 0, 795534
GlobalTracer [baseline] (288.602 ms) : 0, 288602
GlobalTracer [candidate] (289.049 ms) : 0, 289049
AppSec [baseline] (49.973 ms) : 0, 49973
AppSec [candidate] (49.022 ms) : 0, 49022
IAST [baseline] (25.821 ms) : 0, 25821
IAST [candidate] (25.894 ms) : 0, 25894
Remote Config [baseline] (654.657 µs) : 0, 655
Remote Config [candidate] (733.127 µs) : 0, 733
Telemetry [baseline] (6.617 ms) : 0, 6617
Telemetry [candidate] (6.654 ms) : 0, 6654
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (793.936 ms) : 0, 793936
BytebuddyAgent [candidate] (800.944 ms) : 0, 800944
GlobalTracer [baseline] (288.258 ms) : 0, 288258
GlobalTracer [candidate] (290.784 ms) : 0, 290784
AppSec [baseline] (50.157 ms) : 0, 50157
AppSec [candidate] (51.124 ms) : 0, 51124
IAST [baseline] (23.572 ms) : 0, 23572
IAST [candidate] (24.723 ms) : 0, 24723
Remote Config [baseline] (1.255 ms) : 0, 1255
Remote Config [candidate] (586.723 µs) : 0, 587
Telemetry [baseline] (7.308 ms) : 0, 7308
Telemetry [candidate] (7.509 ms) : 0, 7509
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (795.342 ms) : 0, 795342
BytebuddyAgent [candidate] (799.889 ms) : 0, 799889
GlobalTracer [baseline] (289.231 ms) : 0, 289231
GlobalTracer [candidate] (291.242 ms) : 0, 291242
AppSec [baseline] (52.004 ms) : 0, 52004
AppSec [candidate] (50.943 ms) : 0, 50943
IAST [baseline] (22.315 ms) : 0, 22315
IAST [candidate] (22.97 ms) : 0, 22970
Remote Config [baseline] (588.586 µs) : 0, 589
Remote Config [candidate] (581.139 µs) : 0, 581
Telemetry [baseline] (6.666 ms) : 0, 6666
Telemetry [candidate] (8.11 ms) : 0, 8110

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-04-30T19:24:51 2024-04-30T19:31:43
git_branch master rgs/real-queuetime-threshold
git_commit_date 1714499775 1714504044
git_commit_sha 16c56bf 78012cf
release_version 1.34.0-SNAPSHOT~16c56bf74f 1.34.0-SNAPSHOT~78012cfa5d
start_time 2024-04-30T19:24:38 2024-04-30T19:31:30
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1714505850 1714505850
ci_job_id 501279854 501279854
ci_pipeline_id 33297671 33297671
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 15 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling better
[-86.051µs; -31.309µs] or [-5.554%; -2.021%]		 unstable
[-391.453op/s; +637.606op/s] or [-12.722%; +20.722%]		 1.491ms 3200.000op/s 1.549ms 3076.923op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~78012cfa5d, baseline=1.34.0-SNAPSHOT~16c56bf74f
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.965 µs) : 355, 395
.   : milestone, 375,
iast (483.443 µs) : 463, 504
.   : milestone, 483,
iast_FULL (560.471 µs) : 540, 581
.   : milestone, 560,
iast_GLOBAL (502.892 µs) : 482, 524
.   : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (480.898 µs) : 460, 501
.   : milestone, 481,
iast_INACTIVE (457.762 µs) : 437, 478
.   : milestone, 458,
iast_TELEMETRY_OFF (483.167 µs) : 462, 504
.   : milestone, 483,
tracing (459.432 µs) : 439, 480
.   : milestone, 459,
section candidate
no_agent (370.468 µs) : 351, 390
.   : milestone, 370,
iast (481.89 µs) : 461, 503
.   : milestone, 482,
iast_FULL (552.063 µs) : 532, 573
.   : milestone, 552,
iast_GLOBAL (504.141 µs) : 484, 525
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (481.325 µs) : 460, 503
.   : milestone, 481,
iast_INACTIVE (469.476 µs) : 449, 490
.   : milestone, 469,
iast_TELEMETRY_OFF (475.843 µs) : 455, 497
.   : milestone, 476,
tracing (449.924 µs) : 430, 470
.   : milestone, 450,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.965 µs [354.887 µs, 395.042 µs] -
iast 483.443 µs [462.732 µs, 504.155 µs] 108.479 µs (28.9%)
iast_FULL 560.471 µs [539.757 µs, 581.185 µs] 185.507 µs (49.5%)
iast_GLOBAL 502.892 µs [482.276 µs, 523.507 µs] 127.927 µs (34.1%)
iast_HARDCODED_SECRET_DISABLED 480.898 µs [460.377 µs, 501.42 µs] 105.934 µs (28.3%)
iast_INACTIVE 457.762 µs [437.119 µs, 478.406 µs] 82.798 µs (22.1%)
iast_TELEMETRY_OFF 483.167 µs [461.947 µs, 504.387 µs] 108.202 µs (28.9%)
tracing 459.432 µs [438.987 µs, 479.877 µs] 84.468 µs (22.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.468 µs [350.722 µs, 390.215 µs] -
iast 481.89 µs [461.178 µs, 502.603 µs] 111.422 µs (30.1%)
iast_FULL 552.063 µs [531.5 µs, 572.625 µs] 181.595 µs (49.0%)
iast_GLOBAL 504.141 µs [483.658 µs, 524.624 µs] 133.673 µs (36.1%)
iast_HARDCODED_SECRET_DISABLED 481.325 µs [459.956 µs, 502.693 µs] 110.857 µs (29.9%)
iast_INACTIVE 469.476 µs [448.646 µs, 490.305 µs] 99.007 µs (26.7%)
iast_TELEMETRY_OFF 475.843 µs [454.655 µs, 497.032 µs] 105.375 µs (28.4%)
tracing 449.924 µs [429.774 µs, 470.073 µs] 79.455 µs (21.4%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~78012cfa5d, baseline=1.34.0-SNAPSHOT~16c56bf74f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.339 ms) : 1318, 1359
.   : milestone, 1339,
appsec (1.744 ms) : 1719, 1768
.   : milestone, 1744,
appsec_no_iast (1.726 ms) : 1701, 1751
.   : milestone, 1726,
iast (1.507 ms) : 1484, 1530
.   : milestone, 1507,
profiling (1.549 ms) : 1523, 1575
.   : milestone, 1549,
tracing (1.472 ms) : 1449, 1495
.   : milestone, 1472,
section candidate
no_agent (1.358 ms) : 1339, 1377
.   : milestone, 1358,
appsec (1.741 ms) : 1717, 1765
.   : milestone, 1741,
appsec_no_iast (1.742 ms) : 1718, 1767
.   : milestone, 1742,
iast (1.497 ms) : 1475, 1520
.   : milestone, 1497,
profiling (1.491 ms) : 1466, 1515
.   : milestone, 1491,
tracing (1.491 ms) : 1466, 1515
.   : milestone, 1491,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.339 ms [1.318 ms, 1.359 ms] -
appsec 1.744 ms [1.719 ms, 1.768 ms] 404.732 µs (30.2%)
appsec_no_iast 1.726 ms [1.701 ms, 1.751 ms] 386.75 µs (28.9%)
iast 1.507 ms [1.484 ms, 1.53 ms] 168.255 µs (12.6%)
profiling 1.549 ms [1.523 ms, 1.575 ms] 210.405 µs (15.7%)
tracing 1.472 ms [1.449 ms, 1.495 ms] 133.198 µs (9.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.358 ms [1.339 ms, 1.377 ms] -
appsec 1.741 ms [1.717 ms, 1.765 ms] 382.639 µs (28.2%)
appsec_no_iast 1.742 ms [1.718 ms, 1.767 ms] 383.779 µs (28.3%)
iast 1.497 ms [1.475 ms, 1.52 ms] 139.032 µs (10.2%)
profiling 1.491 ms [1.466 ms, 1.515 ms] 132.308 µs (9.7%)
tracing 1.491 ms [1.466 ms, 1.515 ms] 132.18 µs (9.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master rgs/real-queuetime-threshold
git_commit_date 1714499775 1714504044
git_commit_sha 16c56bf 78012cf
release_version 1.34.0-SNAPSHOT~16c56bf74f 1.34.0-SNAPSHOT~78012cfa5d
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1714506362 1714506362
ci_job_id 501279855 501279855
ci_pipeline_id 33297671 33297671
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~78012cfa5d, baseline=1.34.0-SNAPSHOT~16c56bf74f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.463 ms) : 1451, 1474
.   : milestone, 1463,
appsec (2.203 ms) : 2170, 2237
.   : milestone, 2203,
iast (1.87 ms) : 1835, 1904
.   : milestone, 1870,
iast_GLOBAL (1.92 ms) : 1885, 1955
.   : milestone, 1920,
profiling (1.868 ms) : 1834, 1902
.   : milestone, 1868,
tracing (1.827 ms) : 1795, 1858
.   : milestone, 1827,
section candidate
no_agent (1.464 ms) : 1453, 1476
.   : milestone, 1464,
appsec (2.208 ms) : 2174, 2241
.   : milestone, 2208,
iast (1.883 ms) : 1848, 1917
.   : milestone, 1883,
iast_GLOBAL (1.913 ms) : 1878, 1948
.   : milestone, 1913,
profiling (2.291 ms) : 2058, 2525
.   : milestone, 2291,
tracing (1.83 ms) : 1798, 1862
.   : milestone, 1830,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.451 ms, 1.474 ms] -
appsec 2.203 ms [2.17 ms, 2.237 ms] 740.638 µs (50.6%)
iast 1.87 ms [1.835 ms, 1.904 ms] 407.255 µs (27.8%)
iast_GLOBAL 1.92 ms [1.885 ms, 1.955 ms] 457.39 µs (31.3%)
profiling 1.868 ms [1.834 ms, 1.902 ms] 405.073 µs (27.7%)
tracing 1.827 ms [1.795 ms, 1.858 ms] 364.278 µs (24.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.464 ms [1.453 ms, 1.476 ms] -
appsec 2.208 ms [2.174 ms, 2.241 ms] 743.269 µs (50.8%)
iast 1.883 ms [1.848 ms, 1.917 ms] 418.196 µs (28.6%)
iast_GLOBAL 1.913 ms [1.878 ms, 1.948 ms] 448.823 µs (30.6%)
profiling 2.291 ms [2.058 ms, 2.525 ms] 826.897 µs (56.5%)
tracing 1.83 ms [1.798 ms, 1.862 ms] 365.349 µs (24.9%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~78012cfa5d, baseline=1.34.0-SNAPSHOT~16c56bf74f
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.571 s) : 15571000, 15571000
.   : milestone, 15571000,
appsec (14.968 s) : 14968000, 14968000
.   : milestone, 14968000,
iast (18.747 s) : 18747000, 18747000
.   : milestone, 18747000,
iast_GLOBAL (17.86 s) : 17860000, 17860000
.   : milestone, 17860000,
profiling (15.017 s) : 15017000, 15017000
.   : milestone, 15017000,
tracing (14.97 s) : 14970000, 14970000
.   : milestone, 14970000,
section candidate
no_agent (15.011 s) : 15011000, 15011000
.   : milestone, 15011000,
appsec (15.268 s) : 15268000, 15268000
.   : milestone, 15268000,
iast (19.095 s) : 19095000, 19095000
.   : milestone, 19095000,
iast_GLOBAL (18.118 s) : 18118000, 18118000
.   : milestone, 18118000,
profiling (15.106 s) : 15106000, 15106000
.   : milestone, 15106000,
tracing (14.897 s) : 14897000, 14897000
.   : milestone, 14897000,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.571 s [15.571 s, 15.571 s] -
appsec 14.968 s [14.968 s, 14.968 s] -603.0 ms (-3.9%)
iast 18.747 s [18.747 s, 18.747 s] 3.176 s (20.4%)
iast_GLOBAL 17.86 s [17.86 s, 17.86 s] 2.289 s (14.7%)
profiling 15.017 s [15.017 s, 15.017 s] -554.0 ms (-3.6%)
tracing 14.97 s [14.97 s, 14.97 s] -601.0 ms (-3.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.011 s [15.011 s, 15.011 s] -
appsec 15.268 s [15.268 s, 15.268 s] 257.0 ms (1.7%)
iast 19.095 s [19.095 s, 19.095 s] 4.084 s (27.2%)
iast_GLOBAL 18.118 s [18.118 s, 18.118 s] 3.107 s (20.7%)
profiling 15.106 s [15.106 s, 15.106 s] 95.0 ms (0.6%)
tracing 14.897 s [14.897 s, 14.897 s] -114.0 ms (-0.8%)

@richardstartin richardstartin added the comp: profiling Profiling label May 1, 2024
@richardstartin richardstartin marked this pull request as ready for review May 1, 2024 09:34
@richardstartin richardstartin requested a review from a team as a code owner May 1, 2024 09:34
@richardstartin richardstartin merged commit 20e8b14 into master May 1, 2024
82 checks passed
@richardstartin richardstartin deleted the rgs/real-queuetime-threshold branch May 1, 2024 11:47
@github-actions github-actions bot added this to the 1.34.0 milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbachorik jbachorik jbachorik approved these changes

Assignees
No one assigned
Labels
comp: profiling Profiling
Projects
None yet
Milestone
1.34.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@richardstartin @jbachorik