Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fingerprint info into Tracer flare #7043

Merged
merged 1 commit into from
May 17, 2024
Merged

Add fingerprint info into Tracer flare #7043

merged 1 commit into from
May 17, 2024

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented May 16, 2024 •
edited by jira bot

What Does This Do

Having fingerprint maps into the DI flare helps to know how many exceptions are tracked and when are the last time the snapshots were reported.
Exception probes are reported in Probe definitions section.

Example:

Snapshot url: 
http://localhost:8126/debugger/v1/input
Diagnostic url: 
http://localhost:8126/debugger/v1/diagnostics
SymbolDB url: 
http://localhost:8126/symdb/v1/input
Probe definitions:
{893f0968-5f64-4eb8-b86f-02339c801aba:0=ExceptionProbe{language='java', id='893f0968-5f64-4eb8-b86f-02339c801aba', version=0, tags=null, tagMap={}, where=Where{typeName='org.springframework.samples.petclinic.vet.VetController', methodName='processUUId', sourceFile='null', signature='null', lines=[240]}, evaluateAt=EXIT, template='null', segments=null, captureSnapshot=true, when=null, capture=null, sampling=null} , 966709d5-76e3-4a95-b536-e1e4675b7a7f:0=ExceptionProbe{language='java', id='966709d5-76e3-4a95-b536-e1e4675b7a7f', version=0, tags=null, tagMap={}, where=Where{typeName='org.springframework.samples.petclinic.vet.VetController', methodName='showVetList', sourceFile='null', signature='null', lines=[190]}, evaluateAt=EXIT, template='null', segments=null, captureSnapshot=true, when=null, capture=null, sampling=null} , d4659b32-ae68-44ab-a8cd-68a18415f659:1=LogProbe{language='java', id='d4659b32-ae68-44ab-a8cd-68a18415f659', version=1, tags=[], tagMap={}, where=Where{typeName='null', methodName='null', sourceFile='VetController.java', signature='null', lines=[224]}, evaluateAt=EXIT, template='In VetController.java, line 201', segments=[Segment{str='In VetController.java, line 201', parsedExr=null}], captureSnapshot=true, when=ProbeCondition{dslExpression='serviceDefinitionHasChanged1 < 0'}, capture=Capture{maxReferenceDepth=3, maxCollectionSize=100, maxLength=255, maxFieldCount=20}, sampling=Sampling{snapshotsPerSecond=1.0}} , d31c5021-2fa8-454a-a278-1ffdbff9782c:0=ExceptionProbe{language='java', id='d31c5021-2fa8-454a-a278-1ffdbff9782c', version=0, tags=null, tagMap={}, where=Where{typeName='org.springframework.samples.petclinic.vet.VetController', methodName='processArguments', sourceFile='null', signature='null', lines=[230]}, evaluateAt=EXIT, template='null', segments=null, captureSnapshot=true, when=null, capture=null, sampling=null} , f8e0c43d-2bc5-4f09-8bb1-046ef3529592:2=LogProbe{language='java', id='f8e0c43d-2bc5-4f09-8bb1-046ef3529592', version=2, tags=[], tagMap={}, where=Where{typeName='VetController', methodName='showVetList', sourceFile='null', signature='null', lines=null}, evaluateAt=EXIT, template='Executed VetController.showVetList, it took {@duration}ms', segments=[Segment{str='Executed VetController.showVetList, it took ', parsedExr=null}, Segment{str='null', parsedExr=ValueScript{dsl='@duration'}}, Segment{str='ms', parsedExr=null}], captureSnapshot=true, when=ProbeCondition{dslExpression='@return == 'true''}, capture=Capture{maxReferenceDepth=3, maxCollectionSize=100, maxLength=255, maxFieldCount=20}, sampling=Sampling{snapshotsPerSecond=1.0}} }
Instrumented probes:
{893f0968-5f64-4eb8-b86f-02339c801aba:0=InstrumentationResult{status=INSTALLED, diagnostics={ProbeId{id='893f0968-5f64-4eb8-b86f-02339c801aba', version=0}=[]}, typeName='org.springframework.samples.petclinic.vet.VetController', methodName='processUUId'}, 966709d5-76e3-4a95-b536-e1e4675b7a7f:0=InstrumentationResult{status=INSTALLED, diagnostics={ProbeId{id='966709d5-76e3-4a95-b536-e1e4675b7a7f', version=0}=[]}, typeName='org.springframework.samples.petclinic.vet.VetController', methodName='showVetList'}, d4659b32-ae68-44ab-a8cd-68a18415f659:1=InstrumentationResult{status=INSTALLED, diagnostics={ProbeId{id='d4659b32-ae68-44ab-a8cd-68a18415f659', version=1}=[]}, typeName='org.springframework.samples.petclinic.vet.VetController', methodName='addOverhead'}, d31c5021-2fa8-454a-a278-1ffdbff9782c:0=InstrumentationResult{status=INSTALLED, diagnostics={ProbeId{id='d31c5021-2fa8-454a-a278-1ffdbff9782c', version=0}=[]}, typeName='org.springframework.samples.petclinic.vet.VetController', methodName='processArguments'}, f8e0c43d-2bc5-4f09-8bb1-046ef3529592:2=InstrumentationResult{status=INSTALLED, diagnostics={ProbeId{id='f8e0c43d-2bc5-4f09-8bb1-046ef3529592', version=2}=[]}, typeName='org.springframework.samples.petclinic.vet.VetController', methodName='showVetList'}}
Probe statuses:
{893f0968-5f64-4eb8-b86f-02339c801aba:0=ProbeDiagnosticMessage{ddSource='dd_debugger', service='petclinic-benchmark', timestamp='2024-05-15T13:56:35.762Z', message='Probe 893f0968-5f64-4eb8-b86f-02339c801aba:0 is emitting.', debugger=Diagnostics{probeId='893f0968-5f64-4eb8-b86f-02339c801aba', probeVersion=0, runtimeId='c095fad0-bc8c-4561-b299-2a47343c6088', status=EMITTING, exception=null}}, 966709d5-76e3-4a95-b536-e1e4675b7a7f:0=ProbeDiagnosticMessage{ddSource='dd_debugger', service='petclinic-benchmark', timestamp='2024-05-15T13:56:35.762Z', message='Probe 966709d5-76e3-4a95-b536-e1e4675b7a7f:0 is emitting.', debugger=Diagnostics{probeId='966709d5-76e3-4a95-b536-e1e4675b7a7f', probeVersion=0, runtimeId='c095fad0-bc8c-4561-b299-2a47343c6088', status=EMITTING, exception=null}}, d4659b32-ae68-44ab-a8cd-68a18415f659:1=ProbeDiagnosticMessage{ddSource='dd_debugger', service='petclinic-benchmark', timestamp='2024-05-15T13:56:07.776Z', message='Installed probe ProbeId{id='d4659b32-ae68-44ab-a8cd-68a18415f659', version=1}.', debugger=Diagnostics{probeId='d4659b32-ae68-44ab-a8cd-68a18415f659', probeVersion=1, runtimeId='c095fad0-bc8c-4561-b299-2a47343c6088', status=INSTALLED, exception=null}}, d31c5021-2fa8-454a-a278-1ffdbff9782c:0=ProbeDiagnosticMessage{ddSource='dd_debugger', service='petclinic-benchmark', timestamp='2024-05-15T13:56:35.762Z', message='Probe d31c5021-2fa8-454a-a278-1ffdbff9782c:0 is emitting.', debugger=Diagnostics{probeId='d31c5021-2fa8-454a-a278-1ffdbff9782c', probeVersion=0, runtimeId='c095fad0-bc8c-4561-b299-2a47343c6088', status=EMITTING, exception=null}}, f8e0c43d-2bc5-4f09-8bb1-046ef3529592:2=ProbeDiagnosticMessage{ddSource='dd_debugger', service='petclinic-benchmark', timestamp='2024-05-15T13:56:35.762Z', message='Probe f8e0c43d-2bc5-4f09-8bb1-046ef3529592:2 is emitting.', debugger=Diagnostics{probeId='f8e0c43d-2bc5-4f09-8bb1-046ef3529592', probeVersion=2, runtimeId='c095fad0-bc8c-4561-b299-2a47343c6088', status=EMITTING, exception=null}}}
SymbolDB stats:
Stats{totalClassScopes=34, totalSize=149104}
Exception Fingerprints:
{96e1a213c523a5a87ca5ff2e9ce4a31c94622184e8780e51bdd1fff2cbf5=2024-05-15T13:56:35.793Z}

Motivation

Improve troubleshooting for Exception debugging feature

Additional Notes

Jira ticket: DEBUG-2068

@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label May 16, 2024
@jpbempel jpbempel requested a review from a team as a code owner May 16, 2024 13:06
@jpbempel jpbempel requested review from ojung and removed request for a team May 16, 2024 13:06
@pr-commenter
Copy link

pr-commenter bot commented May 16, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/flare-exception-debugging
git_commit_date 1715856651 1715864666
git_commit_sha d0bd085 d328570
release_version 1.35.0-SNAPSHOT~d0bd085303 1.35.0-SNAPSHOT~d3285706a3
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715867447 1715867447
ci_job_id 514035981 514035981
ci_pipeline_id 34445010 34445010
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~d3285706a3, baseline=1.35.0-SNAPSHOT~d0bd085303

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.077 s) : 0, 1076913
Total [baseline] (8.541 s) : 0, 8540964
Agent [candidate] (1.075 s) : 0, 1075057
Total [candidate] (8.579 s) : 0, 8579171
section iast
Agent [baseline] (1.204 s) : 0, 1204388
Total [baseline] (9.058 s) : 0, 9058066
Agent [candidate] (1.211 s) : 0, 1210528
Total [candidate] (9.039 s) : 0, 9039428
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.203 s) : 0, 1202900
Total [baseline] (8.986 s) : 0, 8986085
Agent [candidate] (1.204 s) : 0, 1203590
Total [candidate] (8.995 s) : 0, 8994736
section iast_TELEMETRY_OFF
Agent [baseline] (1.205 s) : 0, 1204910
Total [baseline] (9.029 s) : 0, 9029323
Agent [candidate] (1.199 s) : 0, 1199360
Total [candidate] (8.993 s) : 0, 8992762
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent iast 1.204 s 127.475 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.203 s 125.987 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.205 s 127.997 ms (11.9%)
Total tracing 8.541 s -
Total iast 9.058 s 517.102 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 8.986 s 445.12 ms (5.2%)
Total iast_TELEMETRY_OFF 9.029 s 488.359 ms (5.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.075 s -
Agent iast 1.211 s 135.471 ms (12.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.204 s 128.533 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.199 s 124.303 ms (11.6%)
Total tracing 8.579 s -
Total iast 9.039 s 460.257 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.995 s 415.565 ms (4.8%)
Total iast_TELEMETRY_OFF 8.993 s 413.591 ms (4.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~d3285706a3, baseline=1.35.0-SNAPSHOT~d0bd085303

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.23 ms) : 0, 674230
BytebuddyAgent [candidate] (673.185 ms) : 0, 673185
GlobalTracer [baseline] (310.57 ms) : 0, 310570
GlobalTracer [candidate] (310.017 ms) : 0, 310017
AppSec [baseline] (49.399 ms) : 0, 49399
AppSec [candidate] (49.324 ms) : 0, 49324
Remote Config [baseline] (663.576 µs) : 0, 664
Remote Config [candidate] (662.052 µs) : 0, 662
Telemetry [baseline] (7.631 ms) : 0, 7631
Telemetry [candidate] (7.583 ms) : 0, 7583
section iast
BytebuddyAgent [baseline] (797.981 ms) : 0, 797981
BytebuddyAgent [candidate] (801.642 ms) : 0, 801642
GlobalTracer [baseline] (291.28 ms) : 0, 291280
GlobalTracer [candidate] (292.592 ms) : 0, 292592
AppSec [baseline] (50.734 ms) : 0, 50734
AppSec [candidate] (53.275 ms) : 0, 53275
IAST [baseline] (22.832 ms) : 0, 22832
IAST [candidate] (21.298 ms) : 0, 21298
Remote Config [baseline] (581.901 µs) : 0, 582
Remote Config [candidate] (582.863 µs) : 0, 583
Telemetry [baseline] (6.626 ms) : 0, 6626
Telemetry [candidate] (6.627 ms) : 0, 6627
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (796.767 ms) : 0, 796767
BytebuddyAgent [candidate] (796.826 ms) : 0, 796826
GlobalTracer [baseline] (290.367 ms) : 0, 290367
GlobalTracer [candidate] (290.815 ms) : 0, 290815
AppSec [baseline] (52.263 ms) : 0, 52263
AppSec [candidate] (50.135 ms) : 0, 50135
IAST [baseline] (21.833 ms) : 0, 21833
IAST [candidate] (24.307 ms) : 0, 24307
Remote Config [baseline] (601.205 µs) : 0, 601
Remote Config [candidate] (596.906 µs) : 0, 597
Telemetry [baseline] (6.63 ms) : 0, 6630
Telemetry [candidate] (6.527 ms) : 0, 6527
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (795.971 ms) : 0, 795971
BytebuddyAgent [candidate] (792.694 ms) : 0, 792694
GlobalTracer [baseline] (292.729 ms) : 0, 292729
GlobalTracer [candidate] (290.794 ms) : 0, 290794
AppSec [baseline] (50.843 ms) : 0, 50843
AppSec [candidate] (50.225 ms) : 0, 50225
IAST [baseline] (22.107 ms) : 0, 22107
IAST [candidate] (23.392 ms) : 0, 23392
Remote Config [baseline] (1.366 ms) : 0, 1366
Remote Config [candidate] (619.953 µs) : 0, 620
Telemetry [baseline] (7.352 ms) : 0, 7352
Telemetry [candidate] (7.291 ms) : 0, 7291
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~d3285706a3, baseline=1.35.0-SNAPSHOT~d0bd085303

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1076399
Total [baseline] (10.404 s) : 0, 10404278
Agent [candidate] (1.08 s) : 0, 1079579
Total [candidate] (10.387 s) : 0, 10386826
section appsec
Agent [baseline] (1.196 s) : 0, 1196039
Total [baseline] (10.476 s) : 0, 10475819
Agent [candidate] (1.199 s) : 0, 1199412
Total [candidate] (10.577 s) : 0, 10577045
section iast
Agent [baseline] (1.211 s) : 0, 1210815
Total [baseline] (10.763 s) : 0, 10762526
Agent [candidate] (1.205 s) : 0, 1205167
Total [candidate] (10.811 s) : 0, 10811389
section profiling
Agent [baseline] (1.272 s) : 0, 1271681
Total [baseline] (10.618 s) : 0, 10618461
Agent [candidate] (1.269 s) : 0, 1269083
Total [candidate] (10.623 s) : 0, 10622530
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent appsec 1.196 s 119.64 ms (11.1%)
Agent iast 1.211 s 134.416 ms (12.5%)
Agent profiling 1.272 s 195.282 ms (18.1%)
Total tracing 10.404 s -
Total appsec 10.476 s 71.541 ms (0.7%)
Total iast 10.763 s 358.248 ms (3.4%)
Total profiling 10.618 s 214.183 ms (2.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent appsec 1.199 s 119.833 ms (11.1%)
Agent iast 1.205 s 125.588 ms (11.6%)
Agent profiling 1.269 s 189.504 ms (17.6%)
Total tracing 10.387 s -
Total appsec 10.577 s 190.22 ms (1.8%)
Total iast 10.811 s 424.563 ms (4.1%)
Total profiling 10.623 s 235.704 ms (2.3%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~d3285706a3, baseline=1.35.0-SNAPSHOT~d0bd085303

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.605 ms) : 0, 673605
BytebuddyAgent [candidate] (676.207 ms) : 0, 676207
GlobalTracer [baseline] (310.606 ms) : 0, 310606
GlobalTracer [candidate] (311.483 ms) : 0, 311483
AppSec [baseline] (49.568 ms) : 0, 49568
AppSec [candidate] (49.326 ms) : 0, 49326
Remote Config [baseline] (668.334 µs) : 0, 668
Remote Config [candidate] (651.435 µs) : 0, 651
Telemetry [baseline] (7.691 ms) : 0, 7691
Telemetry [candidate] (7.582 ms) : 0, 7582
section appsec
BytebuddyAgent [baseline] (698.391 ms) : 0, 698391
BytebuddyAgent [candidate] (698.817 ms) : 0, 698817
GlobalTracer [baseline] (293.458 ms) : 0, 293458
GlobalTracer [candidate] (294.305 ms) : 0, 294305
AppSec [baseline] (152.301 ms) : 0, 152301
AppSec [candidate] (152.942 ms) : 0, 152942
Remote Config [baseline] (620.745 µs) : 0, 621
Remote Config [candidate] (625.335 µs) : 0, 625
Telemetry [baseline] (7.505 ms) : 0, 7505
Telemetry [candidate] (8.809 ms) : 0, 8809
IAST [baseline] (18.838 ms) : 0, 18838
IAST [candidate] (18.862 ms) : 0, 18862
section iast
BytebuddyAgent [baseline] (802.595 ms) : 0, 802595
BytebuddyAgent [candidate] (797.4 ms) : 0, 797400
GlobalTracer [baseline] (292.478 ms) : 0, 292478
GlobalTracer [candidate] (291.636 ms) : 0, 291636
AppSec [baseline] (49.077 ms) : 0, 49077
AppSec [candidate] (51.424 ms) : 0, 51424
Remote Config [baseline] (591.005 µs) : 0, 591
Remote Config [candidate] (592.502 µs) : 0, 593
Telemetry [baseline] (6.703 ms) : 0, 6703
Telemetry [candidate] (6.688 ms) : 0, 6688
IAST [baseline] (24.866 ms) : 0, 24866
IAST [candidate] (22.843 ms) : 0, 22843
section profiling
BytebuddyAgent [baseline] (679.061 ms) : 0, 679061
BytebuddyAgent [candidate] (677.287 ms) : 0, 677287
GlobalTracer [baseline] (382.53 ms) : 0, 382530
GlobalTracer [candidate] (381.115 ms) : 0, 381115
AppSec [baseline] (50.413 ms) : 0, 50413
AppSec [candidate] (50.123 ms) : 0, 50123
Remote Config [baseline] (699.061 µs) : 0, 699
Remote Config [candidate] (714.418 µs) : 0, 714
Telemetry [baseline] (7.387 ms) : 0, 7387
Telemetry [candidate] (7.489 ms) : 0, 7489
ProfilingAgent [baseline] (95.145 ms) : 0, 95145
ProfilingAgent [candidate] (95.946 ms) : 0, 95946
Profiling [baseline] (95.169 ms) : 0, 95169
Profiling [candidate] (95.97 ms) : 0, 95970

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-16T13:23:25 2024-05-16T13:30:16
git_branch master jpbempel/flare-exception-debugging
git_commit_date 1715856651 1715864666
git_commit_sha d0bd085 d328570
release_version 1.35.0-SNAPSHOT~d0bd085303 1.35.0-SNAPSHOT~d3285706a3
start_time 2024-05-16T13:23:12 2024-05-16T13:30:03
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715866562 1715866562
ci_job_id 514035982 514035982
ci_pipeline_id 34445010 34445010
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~d3285706a3, baseline=1.35.0-SNAPSHOT~d0bd085303
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.338 ms) : 1318, 1358
.   : milestone, 1338,
appsec (1.713 ms) : 1689, 1737
.   : milestone, 1713,
appsec_no_iast (1.716 ms) : 1692, 1740
.   : milestone, 1716,
iast (1.486 ms) : 1464, 1509
.   : milestone, 1486,
profiling (1.527 ms) : 1501, 1553
.   : milestone, 1527,
tracing (1.48 ms) : 1456, 1504
.   : milestone, 1480,
section candidate
no_agent (1.353 ms) : 1333, 1372
.   : milestone, 1353,
appsec (1.706 ms) : 1681, 1731
.   : milestone, 1706,
appsec_no_iast (1.707 ms) : 1683, 1731
.   : milestone, 1707,
iast (1.473 ms) : 1451, 1496
.   : milestone, 1473,
profiling (1.535 ms) : 1509, 1561
.   : milestone, 1535,
tracing (1.477 ms) : 1453, 1501
.   : milestone, 1477,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.338 ms [1.318 ms, 1.358 ms] -
appsec 1.713 ms [1.689 ms, 1.737 ms] 374.959 µs (28.0%)
appsec_no_iast 1.716 ms [1.692 ms, 1.74 ms] 377.76 µs (28.2%)
iast 1.486 ms [1.464 ms, 1.509 ms] 148.029 µs (11.1%)
profiling 1.527 ms [1.501 ms, 1.553 ms] 188.533 µs (14.1%)
tracing 1.48 ms [1.456 ms, 1.504 ms] 142.066 µs (10.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.353 ms [1.333 ms, 1.372 ms] -
appsec 1.706 ms [1.681 ms, 1.731 ms] 353.605 µs (26.1%)
appsec_no_iast 1.707 ms [1.683 ms, 1.731 ms] 354.361 µs (26.2%)
iast 1.473 ms [1.451 ms, 1.496 ms] 120.892 µs (8.9%)
profiling 1.535 ms [1.509 ms, 1.561 ms] 182.263 µs (13.5%)
tracing 1.477 ms [1.453 ms, 1.501 ms] 124.737 µs (9.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~d3285706a3, baseline=1.35.0-SNAPSHOT~d0bd085303
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.298 µs) : 353, 392
.   : milestone, 372,
iast (481.124 µs) : 460, 502
.   : milestone, 481,
iast_FULL (556.447 µs) : 535, 578
.   : milestone, 556,
iast_GLOBAL (515.143 µs) : 492, 538
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (479.489 µs) : 459, 500
.   : milestone, 479,
iast_INACTIVE (455.534 µs) : 434, 477
.   : milestone, 456,
iast_TELEMETRY_OFF (476.472 µs) : 455, 498
.   : milestone, 476,
tracing (443.354 µs) : 422, 464
.   : milestone, 443,
section candidate
no_agent (364.797 µs) : 345, 385
.   : milestone, 365,
iast (480.685 µs) : 460, 502
.   : milestone, 481,
iast_FULL (546.911 µs) : 526, 568
.   : milestone, 547,
iast_GLOBAL (515.566 µs) : 493, 538
.   : milestone, 516,
iast_HARDCODED_SECRET_DISABLED (477.197 µs) : 456, 498
.   : milestone, 477,
iast_INACTIVE (452.104 µs) : 431, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (470.648 µs) : 450, 492
.   : milestone, 471,
tracing (440.568 µs) : 420, 461
.   : milestone, 441,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.298 µs [352.91 µs, 391.685 µs] -
iast 481.124 µs [459.932 µs, 502.317 µs] 108.826 µs (29.2%)
iast_FULL 556.447 µs [535.335 µs, 577.56 µs] 184.15 µs (49.5%)
iast_GLOBAL 515.143 µs [492.103 µs, 538.184 µs] 142.846 µs (38.4%)
iast_HARDCODED_SECRET_DISABLED 479.489 µs [458.642 µs, 500.337 µs] 107.192 µs (28.8%)
iast_INACTIVE 455.534 µs [433.899 µs, 477.169 µs] 83.236 µs (22.4%)
iast_TELEMETRY_OFF 476.472 µs [454.588 µs, 498.357 µs] 104.174 µs (28.0%)
tracing 443.354 µs [422.32 µs, 464.389 µs] 71.057 µs (19.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.797 µs [344.809 µs, 384.786 µs] -
iast 480.685 µs [459.626 µs, 501.744 µs] 115.888 µs (31.8%)
iast_FULL 546.911 µs [525.986 µs, 567.836 µs] 182.114 µs (49.9%)
iast_GLOBAL 515.566 µs [492.913 µs, 538.218 µs] 150.769 µs (41.3%)
iast_HARDCODED_SECRET_DISABLED 477.197 µs [456.457 µs, 497.938 µs] 112.4 µs (30.8%)
iast_INACTIVE 452.104 µs [431.121 µs, 473.086 µs] 87.306 µs (23.9%)
iast_TELEMETRY_OFF 470.648 µs [449.589 µs, 491.707 µs] 105.851 µs (29.0%)
tracing 440.568 µs [420.218 µs, 460.917 µs] 75.771 µs (20.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/flare-exception-debugging
git_commit_date 1715856651 1715864666
git_commit_sha d0bd085 d328570
release_version 1.35.0-SNAPSHOT~d0bd085303 1.35.0-SNAPSHOT~d3285706a3
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1715867074 1715867074
ci_job_id 514035983 514035983
ci_pipeline_id 34445010 34445010
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~d3285706a3, baseline=1.35.0-SNAPSHOT~d0bd085303
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.231 s) : 15231000, 15231000
.   : milestone, 15231000,
appsec (14.829 s) : 14829000, 14829000
.   : milestone, 14829000,
iast (18.782 s) : 18782000, 18782000
.   : milestone, 18782000,
iast_GLOBAL (17.857 s) : 17857000, 17857000
.   : milestone, 17857000,
profiling (15.267 s) : 15267000, 15267000
.   : milestone, 15267000,
tracing (14.932 s) : 14932000, 14932000
.   : milestone, 14932000,
section candidate
no_agent (15.422 s) : 15422000, 15422000
.   : milestone, 15422000,
appsec (15.173 s) : 15173000, 15173000
.   : milestone, 15173000,
iast (18.956 s) : 18956000, 18956000
.   : milestone, 18956000,
iast_GLOBAL (17.912 s) : 17912000, 17912000
.   : milestone, 17912000,
profiling (15.775 s) : 15775000, 15775000
.   : milestone, 15775000,
tracing (15.012 s) : 15012000, 15012000
.   : milestone, 15012000,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.231 s [15.231 s, 15.231 s] -
appsec 14.829 s [14.829 s, 14.829 s] -402.0 ms (-2.6%)
iast 18.782 s [18.782 s, 18.782 s] 3.551 s (23.3%)
iast_GLOBAL 17.857 s [17.857 s, 17.857 s] 2.626 s (17.2%)
profiling 15.267 s [15.267 s, 15.267 s] 36.0 ms (0.2%)
tracing 14.932 s [14.932 s, 14.932 s] -299.0 ms (-2.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.422 s [15.422 s, 15.422 s] -
appsec 15.173 s [15.173 s, 15.173 s] -249.0 ms (-1.6%)
iast 18.956 s [18.956 s, 18.956 s] 3.534 s (22.9%)
iast_GLOBAL 17.912 s [17.912 s, 17.912 s] 2.49 s (16.1%)
profiling 15.775 s [15.775 s, 15.775 s] 353.0 ms (2.3%)
tracing 15.012 s [15.012 s, 15.012 s] -410.0 ms (-2.7%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~d3285706a3, baseline=1.35.0-SNAPSHOT~d0bd085303
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.462 ms) : 1451, 1473
.   : milestone, 1462,
appsec (2.205 ms) : 2171, 2239
.   : milestone, 2205,
iast (1.946 ms) : 1906, 1986
.   : milestone, 1946,
iast_GLOBAL (1.997 ms) : 1956, 2038
.   : milestone, 1997,
profiling (1.849 ms) : 1815, 1883
.   : milestone, 1849,
tracing (1.822 ms) : 1791, 1854
.   : milestone, 1822,
section candidate
no_agent (1.467 ms) : 1455, 1479
.   : milestone, 1467,
appsec (2.201 ms) : 2167, 2235
.   : milestone, 2201,
iast (1.952 ms) : 1911, 1992
.   : milestone, 1952,
iast_GLOBAL (1.978 ms) : 1938, 2019
.   : milestone, 1978,
profiling (1.848 ms) : 1816, 1881
.   : milestone, 1848,
tracing (1.824 ms) : 1792, 1855
.   : milestone, 1824,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.451 ms, 1.473 ms] -
appsec 2.205 ms [2.171 ms, 2.239 ms] 743.362 µs (50.8%)
iast 1.946 ms [1.906 ms, 1.986 ms] 484.194 µs (33.1%)
iast_GLOBAL 1.997 ms [1.956 ms, 2.038 ms] 534.941 µs (36.6%)
profiling 1.849 ms [1.815 ms, 1.883 ms] 386.697 µs (26.5%)
tracing 1.822 ms [1.791 ms, 1.854 ms] 360.366 µs (24.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.455 ms, 1.479 ms] -
appsec 2.201 ms [2.167 ms, 2.235 ms] 733.594 µs (50.0%)
iast 1.952 ms [1.911 ms, 1.992 ms] 484.788 µs (33.0%)
iast_GLOBAL 1.978 ms [1.938 ms, 2.019 ms] 511.468 µs (34.9%)
profiling 1.848 ms [1.816 ms, 1.881 ms] 381.188 µs (26.0%)
tracing 1.824 ms [1.792 ms, 1.855 ms] 356.541 µs (24.3%)

@jpbempel
Add fingerprint info into Tracer flare
71917d0 
Having fingerprint maps into the DI flare helps to know how many
exceptions are tracked and when are the last time the snapshots were
reported.
Exception probes are reported in Probe definitions section.
@jpbempel jpbempel force-pushed the jpbempel/flare-exception-debugging branch from d328570 to 71917d0 Compare May 16, 2024 15:48
@PerfectSlayer PerfectSlayer added the tag: diagnostics Diagnostics related changes label May 17, 2024
cimi
cimi approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@cimi cimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@jpbempel jpbempel merged commit ede722d into master May 17, 2024
76 of 79 checks passed
@jpbempel jpbempel deleted the jpbempel/flare-exception-debugging branch May 17, 2024 11:48
@github-actions github-actions bot added this to the 1.35.0 milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimi cimi cimi approved these changes

@ojung ojung Awaiting requested review from ojung ojung is a code owner automatically assigned from DataDog/debugger-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation tag: diagnostics Diagnostics related changes
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jpbempel @cimi @PerfectSlayer