Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit rate limited JFR events when RejectedExecutionHandlers run #7076

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Emit rate limited JFR events when RejectedExecutionHandlers run #7076

merged 1 commit into from
Jun 4, 2024

Conversation

richardstartin
Copy link
Member

@richardstartin richardstartin commented May 24, 2024 •
edited by jira bot

What Does This Do

This emits a custom JFR event with the name of the rejected execution handler type and the name of the user's code when execution is rejected. Emission of these events is controlled by a PID controller with the same parameters as the exception profiler. The feature is disabled by default, and given the structure of the project (in particular with respect to JDK8 + JFR), unit testing this feature is difficult. I would like to merge the change as is and iterate on it on internal systems, and undergo the rigmarole of unit tests before enabling it by default.

Motivation

Show task rejection in the profiling timeline and Code Hotspots.

Additional Notes

Jira ticket: PROF-9882

@richardstartin richardstartin requested review from a team as code owners May 24, 2024 15:24
@richardstartin richardstartin force-pushed the rgs/rejected-execution-events branch 3 times, most recently from 5ce19eb to 395eb06 Compare May 24, 2024 16:43
@richardstartin richardstartin added the comp: profiling Profiling label Jun 4, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jun 4, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master rgs/rejected-execution-events
git_commit_date 1717501423 1717500608
git_commit_sha 87dc120 460eca9
release_version 1.35.0-SNAPSHOT~87dc12035d 1.35.0-SNAPSHOT~460eca9f39
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717504464 1717504464
ci_job_id 531557050 531557050
ci_pipeline_id 35784633 35784633
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~460eca9f39, baseline=1.35.0-SNAPSHOT~87dc12035d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.572 s) : 0, 1572008
Total [baseline] (12.01 s) : 0, 12009805
Agent [candidate] (1.585 s) : 0, 1584883
Total [candidate] (11.954 s) : 0, 11954310
section iast
Agent [baseline] (1.712 s) : 0, 1711633
Total [baseline] (12.539 s) : 0, 12538590
Agent [candidate] (1.708 s) : 0, 1707959
Total [candidate] (12.499 s) : 0, 12499034
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.706 s) : 0, 1706062
Total [baseline] (12.509 s) : 0, 12508927
Agent [candidate] (1.708 s) : 0, 1707819
Total [candidate] (12.498 s) : 0, 12497906
section iast_TELEMETRY_OFF
Agent [baseline] (1.696 s) : 0, 1696424
Total [baseline] (12.559 s) : 0, 12559412
Agent [candidate] (1.702 s) : 0, 1702452
Total [candidate] (12.582 s) : 0, 12581626
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.572 s -
Agent iast 1.712 s 139.625 ms (8.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.706 s 134.054 ms (8.5%)
Agent iast_TELEMETRY_OFF 1.696 s 124.416 ms (7.9%)
Total tracing 12.01 s -
Total iast 12.539 s 528.784 ms (4.4%)
Total iast_HARDCODED_SECRET_DISABLED 12.509 s 499.122 ms (4.2%)
Total iast_TELEMETRY_OFF 12.559 s 549.607 ms (4.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.585 s -
Agent iast 1.708 s 123.076 ms (7.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.708 s 122.937 ms (7.8%)
Agent iast_TELEMETRY_OFF 1.702 s 117.569 ms (7.4%)
Total tracing 11.954 s -
Total iast 12.499 s 544.724 ms (4.6%)
Total iast_HARDCODED_SECRET_DISABLED 12.498 s 543.596 ms (4.5%)
Total iast_TELEMETRY_OFF 12.582 s 627.316 ms (5.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~460eca9f39, baseline=1.35.0-SNAPSHOT~87dc12035d

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (967.148 ms) : 0, 967148
BytebuddyAgent [candidate] (975.227 ms) : 0, 975227
GlobalTracer [baseline] (462.05 ms) : 0, 462050
GlobalTracer [candidate] (465.995 ms) : 0, 465995
AppSec [baseline] (71.683 ms) : 0, 71683
AppSec [candidate] (71.987 ms) : 0, 71987
Remote Config [baseline] (834.393 µs) : 0, 834
Remote Config [candidate] (851.648 µs) : 0, 852
Telemetry [baseline] (9.818 ms) : 0, 9818
Telemetry [candidate] (9.861 ms) : 0, 9861
section iast
BytebuddyAgent [baseline] (1.15 s) : 0, 1150149
BytebuddyAgent [candidate] (1.144 s) : 0, 1144167
GlobalTracer [baseline] (432.819 ms) : 0, 432819
GlobalTracer [candidate] (431.26 ms) : 0, 431260
AppSec [baseline] (67.32 ms) : 0, 67320
AppSec [candidate] (67.19 ms) : 0, 67190
IAST [baseline] (29.113 ms) : 0, 29113
IAST [candidate] (34.142 ms) : 0, 34142
Remote Config [baseline] (774.273 µs) : 0, 774
Remote Config [candidate] (777.863 µs) : 0, 778
Telemetry [baseline] (11.683 ms) : 0, 11683
Telemetry [candidate] (10.616 ms) : 0, 10616
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.144 s) : 0, 1144155
BytebuddyAgent [candidate] (1.145 s) : 0, 1144869
GlobalTracer [baseline] (430.824 ms) : 0, 430824
GlobalTracer [candidate] (432.029 ms) : 0, 432029
AppSec [baseline] (65.906 ms) : 0, 65906
AppSec [candidate] (67.725 ms) : 0, 67725
IAST [baseline] (33.141 ms) : 0, 33141
IAST [candidate] (33.401 ms) : 0, 33401
Remote Config [baseline] (769.756 µs) : 0, 770
Remote Config [candidate] (790.007 µs) : 0, 790
Telemetry [baseline] (11.451 ms) : 0, 11451
Telemetry [candidate] (9.163 ms) : 0, 9163
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.138 s) : 0, 1137524
BytebuddyAgent [candidate] (1.141 s) : 0, 1141171
GlobalTracer [baseline] (429.818 ms) : 0, 429818
GlobalTracer [candidate] (431.314 ms) : 0, 431314
AppSec [baseline] (67.3 ms) : 0, 67300
AppSec [candidate] (68.417 ms) : 0, 68417
IAST [baseline] (31.324 ms) : 0, 31324
IAST [candidate] (31.071 ms) : 0, 31071
Remote Config [baseline] (788.366 µs) : 0, 788
Remote Config [candidate] (771.31 µs) : 0, 771
Telemetry [baseline] (9.902 ms) : 0, 9902
Telemetry [candidate] (9.763 ms) : 0, 9763
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~460eca9f39, baseline=1.35.0-SNAPSHOT~87dc12035d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.575 s) : 0, 1575484
Total [baseline] (14.147 s) : 0, 14146501
Agent [candidate] (1.575 s) : 0, 1574835
Total [candidate] (14.266 s) : 0, 14266330
section appsec
Agent [baseline] (1.751 s) : 0, 1751245
Total [baseline] (14.383 s) : 0, 14382843
Agent [candidate] (1.756 s) : 0, 1756238
Total [candidate] (14.392 s) : 0, 14391850
section iast
Agent [baseline] (1.704 s) : 0, 1703916
Total [baseline] (14.764 s) : 0, 14763826
Agent [candidate] (1.707 s) : 0, 1707087
Total [candidate] (14.715 s) : 0, 14715037
section profiling
Agent [baseline] (1.891 s) : 0, 1890790
Total [baseline] (14.661 s) : 0, 14661283
Agent [candidate] (1.896 s) : 0, 1896218
Total [candidate] (14.75 s) : 0, 14750465
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.575 s -
Agent appsec 1.751 s 175.761 ms (11.2%)
Agent iast 1.704 s 128.432 ms (8.2%)
Agent profiling 1.891 s 315.306 ms (20.0%)
Total tracing 14.147 s -
Total appsec 14.383 s 236.343 ms (1.7%)
Total iast 14.764 s 617.325 ms (4.4%)
Total profiling 14.661 s 514.782 ms (3.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.575 s -
Agent appsec 1.756 s 181.403 ms (11.5%)
Agent iast 1.707 s 132.252 ms (8.4%)
Agent profiling 1.896 s 321.383 ms (20.4%)
Total tracing 14.266 s -
Total appsec 14.392 s 125.52 ms (0.9%)
Total iast 14.715 s 448.706 ms (3.1%)
Total profiling 14.75 s 484.135 ms (3.4%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~460eca9f39, baseline=1.35.0-SNAPSHOT~87dc12035d

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (969.259 ms) : 0, 969259
BytebuddyAgent [candidate] (969.11 ms) : 0, 969110
GlobalTracer [baseline] (463.45 ms) : 0, 463450
GlobalTracer [candidate] (463.122 ms) : 0, 463122
AppSec [baseline] (71.613 ms) : 0, 71613
AppSec [candidate] (71.376 ms) : 0, 71376
Remote Config [baseline] (830.751 µs) : 0, 831
Remote Config [candidate] (841.035 µs) : 0, 841
Telemetry [baseline] (9.811 ms) : 0, 9811
Telemetry [candidate] (9.778 ms) : 0, 9778
section appsec
BytebuddyAgent [baseline] (1.0 s) : 0, 1000488
BytebuddyAgent [candidate] (1.003 s) : 0, 1002552
GlobalTracer [baseline] (436.85 ms) : 0, 436850
GlobalTracer [candidate] (439.104 ms) : 0, 439104
AppSec [baseline] (231.369 ms) : 0, 231369
AppSec [candidate] (231.713 ms) : 0, 231713
IAST [baseline] (23.932 ms) : 0, 23932
IAST [candidate] (24.191 ms) : 0, 24191
Remote Config [baseline] (785.905 µs) : 0, 786
Remote Config [candidate] (792.66 µs) : 0, 793
Telemetry [baseline] (9.248 ms) : 0, 9248
Telemetry [candidate] (9.27 ms) : 0, 9270
section iast
BytebuddyAgent [baseline] (1.145 s) : 0, 1144966
BytebuddyAgent [candidate] (1.144 s) : 0, 1144483
GlobalTracer [baseline] (430.592 ms) : 0, 430592
GlobalTracer [candidate] (430.997 ms) : 0, 430997
AppSec [baseline] (67.195 ms) : 0, 67195
AppSec [candidate] (66.977 ms) : 0, 66977
IAST [baseline] (29.868 ms) : 0, 29868
IAST [candidate] (34.222 ms) : 0, 34222
Remote Config [baseline] (767.461 µs) : 0, 767
Remote Config [candidate] (781.406 µs) : 0, 781
Telemetry [baseline] (10.836 ms) : 0, 10836
Telemetry [candidate] (9.89 ms) : 0, 9890
section profiling
BytebuddyAgent [baseline] (983.321 ms) : 0, 983321
BytebuddyAgent [candidate] (982.725 ms) : 0, 982725
GlobalTracer [baseline] (579.172 ms) : 0, 579172
GlobalTracer [candidate] (579.509 ms) : 0, 579509
AppSec [baseline] (73.135 ms) : 0, 73135
AppSec [candidate] (73.709 ms) : 0, 73709
Remote Config [baseline] (954.587 µs) : 0, 955
Remote Config [candidate] (959.559 µs) : 0, 960
Telemetry [baseline] (9.514 ms) : 0, 9514
Telemetry [candidate] (9.536 ms) : 0, 9536
ProfilingAgent [baseline] (151.39 ms) : 0, 151390
ProfilingAgent [candidate] (156.295 ms) : 0, 156295
Profiling [baseline] (151.459 ms) : 0, 151459
Profiling [candidate] (156.351 ms) : 0, 156351

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-04T11:47:14 2024-06-04T11:54:03
git_branch master rgs/rejected-execution-events
git_commit_date 1717493892 1717500608
git_commit_sha ad2cc7a 460eca9
release_version 1.35.0-SNAPSHOT~ad2cc7a93e 1.35.0-SNAPSHOT~460eca9f39
start_time 2024-06-04T11:47:01 2024-06-04T11:53:50
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717502388 1717502388
ci_job_id 531530291 531530291
ci_pipeline_id 35784633 35784633
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~460eca9f39, baseline=1.35.0-SNAPSHOT~ad2cc7a93e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.351 ms) : 1332, 1370
.   : milestone, 1351,
appsec (1.713 ms) : 1690, 1737
.   : milestone, 1713,
appsec_no_iast (1.729 ms) : 1705, 1753
.   : milestone, 1729,
iast (1.485 ms) : 1462, 1508
.   : milestone, 1485,
profiling (1.494 ms) : 1470, 1518
.   : milestone, 1494,
tracing (1.475 ms) : 1451, 1500
.   : milestone, 1475,
section candidate
no_agent (1.332 ms) : 1312, 1351
.   : milestone, 1332,
appsec (1.698 ms) : 1674, 1722
.   : milestone, 1698,
appsec_no_iast (1.732 ms) : 1708, 1755
.   : milestone, 1732,
iast (1.482 ms) : 1459, 1505
.   : milestone, 1482,
profiling (1.534 ms) : 1508, 1560
.   : milestone, 1534,
tracing (1.459 ms) : 1435, 1483
.   : milestone, 1459,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.351 ms [1.332 ms, 1.37 ms] -
appsec 1.713 ms [1.69 ms, 1.737 ms] 362.346 µs (26.8%)
appsec_no_iast 1.729 ms [1.705 ms, 1.753 ms] 378.461 µs (28.0%)
iast 1.485 ms [1.462 ms, 1.508 ms] 134.504 µs (10.0%)
profiling 1.494 ms [1.47 ms, 1.518 ms] 143.238 µs (10.6%)
tracing 1.475 ms [1.451 ms, 1.5 ms] 124.258 µs (9.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.332 ms [1.312 ms, 1.351 ms] -
appsec 1.698 ms [1.674 ms, 1.722 ms] 365.938 µs (27.5%)
appsec_no_iast 1.732 ms [1.708 ms, 1.755 ms] 399.737 µs (30.0%)
iast 1.482 ms [1.459 ms, 1.505 ms] 150.231 µs (11.3%)
profiling 1.534 ms [1.508 ms, 1.56 ms] 202.302 µs (15.2%)
tracing 1.459 ms [1.435 ms, 1.483 ms] 127.463 µs (9.6%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~460eca9f39, baseline=1.35.0-SNAPSHOT~ad2cc7a93e
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.465 µs) : 353, 392
.   : milestone, 372,
iast (480.202 µs) : 459, 502
.   : milestone, 480,
iast_FULL (555.689 µs) : 535, 576
.   : milestone, 556,
iast_GLOBAL (502.901 µs) : 481, 525
.   : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (475.413 µs) : 455, 496
.   : milestone, 475,
iast_INACTIVE (448.49 µs) : 427, 470
.   : milestone, 448,
iast_TELEMETRY_OFF (475.841 µs) : 454, 498
.   : milestone, 476,
tracing (441.049 µs) : 420, 462
.   : milestone, 441,
section candidate
no_agent (368.063 µs) : 347, 389
.   : milestone, 368,
iast (488.612 µs) : 467, 510
.   : milestone, 489,
iast_FULL (546.062 µs) : 525, 567
.   : milestone, 546,
iast_GLOBAL (508.526 µs) : 487, 530
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (488.987 µs) : 467, 511
.   : milestone, 489,
iast_INACTIVE (449.99 µs) : 429, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (472.7 µs) : 451, 494
.   : milestone, 473,
tracing (436.952 µs) : 417, 457
.   : milestone, 437,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.465 µs [352.656 µs, 392.275 µs] -
iast 480.202 µs [458.605 µs, 501.8 µs] 107.737 µs (28.9%)
iast_FULL 555.689 µs [534.914 µs, 576.465 µs] 183.224 µs (49.2%)
iast_GLOBAL 502.901 µs [481.102 µs, 524.699 µs] 130.435 µs (35.0%)
iast_HARDCODED_SECRET_DISABLED 475.413 µs [454.566 µs, 496.26 µs] 102.948 µs (27.6%)
iast_INACTIVE 448.49 µs [427.138 µs, 469.841 µs] 76.025 µs (20.4%)
iast_TELEMETRY_OFF 475.841 µs [454.101 µs, 497.581 µs] 103.376 µs (27.8%)
tracing 441.049 µs [420.231 µs, 461.867 µs] 68.584 µs (18.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.063 µs [347.093 µs, 389.033 µs] -
iast 488.612 µs [466.898 µs, 510.326 µs] 120.549 µs (32.8%)
iast_FULL 546.062 µs [524.966 µs, 567.158 µs] 177.999 µs (48.4%)
iast_GLOBAL 508.526 µs [486.586 µs, 530.467 µs] 140.463 µs (38.2%)
iast_HARDCODED_SECRET_DISABLED 488.987 µs [467.11 µs, 510.864 µs] 120.924 µs (32.9%)
iast_INACTIVE 449.99 µs [429.325 µs, 470.655 µs] 81.927 µs (22.3%)
iast_TELEMETRY_OFF 472.7 µs [451.461 µs, 493.939 µs] 104.637 µs (28.4%)
tracing 436.952 µs [416.785 µs, 457.118 µs] 68.889 µs (18.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master rgs/rejected-execution-events
git_commit_date 1717493892 1717500608
git_commit_sha ad2cc7a 460eca9
release_version 1.35.0-SNAPSHOT~ad2cc7a93e 1.35.0-SNAPSHOT~460eca9f39
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1717503036 1717503036
ci_job_id 531530292 531530292
ci_pipeline_id 35784633 35784633
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~460eca9f39, baseline=1.35.0-SNAPSHOT~ad2cc7a93e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.457 ms) : 1446, 1468
.   : milestone, 1457,
appsec (2.193 ms) : 2159, 2227
.   : milestone, 2193,
iast (1.959 ms) : 1917, 2000
.   : milestone, 1959,
iast_GLOBAL (1.989 ms) : 1949, 2030
.   : milestone, 1989,
profiling (1.833 ms) : 1799, 1867
.   : milestone, 1833,
tracing (1.83 ms) : 1797, 1862
.   : milestone, 1830,
section candidate
no_agent (1.458 ms) : 1447, 1470
.   : milestone, 1458,
appsec (2.189 ms) : 2156, 2223
.   : milestone, 2189,
iast (1.961 ms) : 1920, 2003
.   : milestone, 1961,
iast_GLOBAL (1.974 ms) : 1934, 2015
.   : milestone, 1974,
profiling (1.838 ms) : 1804, 1872
.   : milestone, 1838,
tracing (1.831 ms) : 1799, 1863
.   : milestone, 1831,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.457 ms [1.446 ms, 1.468 ms] -
appsec 2.193 ms [2.159 ms, 2.227 ms] 735.949 µs (50.5%)
iast 1.959 ms [1.917 ms, 2.0 ms] 501.615 µs (34.4%)
iast_GLOBAL 1.989 ms [1.949 ms, 2.03 ms] 532.396 µs (36.5%)
profiling 1.833 ms [1.799 ms, 1.867 ms] 376.21 µs (25.8%)
tracing 1.83 ms [1.797 ms, 1.862 ms] 372.624 µs (25.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.447 ms, 1.47 ms] -
appsec 2.189 ms [2.156 ms, 2.223 ms] 730.809 µs (50.1%)
iast 1.961 ms [1.92 ms, 2.003 ms] 503.062 µs (34.5%)
iast_GLOBAL 1.974 ms [1.934 ms, 2.015 ms] 516.035 µs (35.4%)
profiling 1.838 ms [1.804 ms, 1.872 ms] 379.768 µs (26.0%)
tracing 1.831 ms [1.799 ms, 1.863 ms] 372.606 µs (25.5%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~460eca9f39, baseline=1.35.0-SNAPSHOT~ad2cc7a93e
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.835 s) : 14835000, 14835000
.   : milestone, 14835000,
appsec (15.344 s) : 15344000, 15344000
.   : milestone, 15344000,
iast (18.738 s) : 18738000, 18738000
.   : milestone, 18738000,
iast_GLOBAL (17.969 s) : 17969000, 17969000
.   : milestone, 17969000,
profiling (15.072 s) : 15072000, 15072000
.   : milestone, 15072000,
tracing (15.16 s) : 15160000, 15160000
.   : milestone, 15160000,
section candidate
no_agent (14.896 s) : 14896000, 14896000
.   : milestone, 14896000,
appsec (15.248 s) : 15248000, 15248000
.   : milestone, 15248000,
iast (18.838 s) : 18838000, 18838000
.   : milestone, 18838000,
iast_GLOBAL (17.731 s) : 17731000, 17731000
.   : milestone, 17731000,
profiling (15.328 s) : 15328000, 15328000
.   : milestone, 15328000,
tracing (15.058 s) : 15058000, 15058000
.   : milestone, 15058000,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.835 s [14.835 s, 14.835 s] -
appsec 15.344 s [15.344 s, 15.344 s] 509.0 ms (3.4%)
iast 18.738 s [18.738 s, 18.738 s] 3.903 s (26.3%)
iast_GLOBAL 17.969 s [17.969 s, 17.969 s] 3.134 s (21.1%)
profiling 15.072 s [15.072 s, 15.072 s] 237.0 ms (1.6%)
tracing 15.16 s [15.16 s, 15.16 s] 325.0 ms (2.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.896 s [14.896 s, 14.896 s] -
appsec 15.248 s [15.248 s, 15.248 s] 352.0 ms (2.4%)
iast 18.838 s [18.838 s, 18.838 s] 3.942 s (26.5%)
iast_GLOBAL 17.731 s [17.731 s, 17.731 s] 2.835 s (19.0%)
profiling 15.328 s [15.328 s, 15.328 s] 432.0 ms (2.9%)
tracing 15.058 s [15.058 s, 15.058 s] 162.0 ms (1.1%)

@richardstartin richardstartin enabled auto-merge (squash) June 4, 2024 13:13
@richardstartin richardstartin merged commit 8a0a406 into master Jun 4, 2024
80 of 81 checks passed
@richardstartin richardstartin deleted the rgs/rejected-execution-events branch June 4, 2024 13:26
@github-actions github-actions bot added this to the 1.35.0 milestone Jun 4, 2024
@PerfectSlayer PerfectSlayer changed the title emit rate limited JFR events when RejectedExecutionHandlers run Emit rate limited JFR events when RejectedExecutionHandlers run Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbachorik jbachorik jbachorik approved these changes

@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java

@am312 am312 Awaiting requested review from am312 am312 is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: profiling Profiling
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@richardstartin @jbachorik