Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement agentless log submission for Log4j2 #7082

Merged
merged 6 commits into from
Jun 7, 2024
Merged

Implement agentless log submission for Log4j2 #7082

merged 6 commits into from
Jun 7, 2024

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented May 28, 2024 •
edited by jira bot

What Does This Do

Implements agentless log submission for Log4j2: instead of tailing log files to Datadog agent, the users may configure the tracer to submit logs directly to Datadog backend.

Motivation

The majority of CI Visibility users run the tracer in agentless mode.

Jira ticket: CIVIS-10104

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the tag: experimental Experimental changes label May 28, 2024
@pr-commenter
Copy link

pr-commenter bot commented May 28, 2024 •
edited

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/agentless-log-submission
git_commit_date 1716978697 1716989101
git_commit_sha 86231f4 e482cd7
release_version 1.35.0-SNAPSHOT~86231f4e3c 1.35.0-SNAPSHOT~e482cd7b6d
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1716992172 1716992172
ci_job_id 525822552 525822552
ci_pipeline_id 35340771 35340771
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 2 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 16 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:tracing:GlobalTracer better
[-11.496ms; -9.742ms] or [-3.681%; -3.119%]		 301.730ms 312.349ms
scenario:startup:petclinic:tracing:GlobalTracer better
[-21.132ms; -10.095ms] or [-6.665%; -3.184%]		 301.458ms 317.071ms
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~e482cd7b6d, baseline=1.35.0-SNAPSHOT~86231f4e3c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.073 s) : 0, 1072635
Total [baseline] (10.439 s) : 0, 10438927
Agent [candidate] (1.058 s) : 0, 1058329
Total [candidate] (10.334 s) : 0, 10334025
section appsec
Agent [baseline] (1.175 s) : 0, 1175365
Total [baseline] (10.56 s) : 0, 10560466
Agent [candidate] (1.176 s) : 0, 1175876
Total [candidate] (10.507 s) : 0, 10506890
section iast
Agent [baseline] (1.188 s) : 0, 1187679
Total [baseline] (10.91 s) : 0, 10909702
Agent [candidate] (1.187 s) : 0, 1186641
Total [candidate] (10.759 s) : 0, 10758505
section profiling
Agent [baseline] (1.274 s) : 0, 1273837
Total [baseline] (10.61 s) : 0, 10610027
Agent [candidate] (1.258 s) : 0, 1258458
Total [candidate] (10.625 s) : 0, 10624678
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.073 s -
Agent appsec 1.175 s 102.73 ms (9.6%)
Agent iast 1.188 s 115.044 ms (10.7%)
Agent profiling 1.274 s 201.202 ms (18.8%)
Total tracing 10.439 s -
Total appsec 10.56 s 121.539 ms (1.2%)
Total iast 10.91 s 470.775 ms (4.5%)
Total profiling 10.61 s 171.1 ms (1.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.058 s -
Agent appsec 1.176 s 117.547 ms (11.1%)
Agent iast 1.187 s 128.312 ms (12.1%)
Agent profiling 1.258 s 200.13 ms (18.9%)
Total tracing 10.334 s -
Total appsec 10.507 s 172.865 ms (1.7%)
Total iast 10.759 s 424.48 ms (4.1%)
Total profiling 10.625 s 290.653 ms (2.8%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~e482cd7b6d, baseline=1.35.0-SNAPSHOT~86231f4e3c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (661.921 ms) : 0, 661921
BytebuddyAgent [candidate] (664.228 ms) : 0, 664228
GlobalTracer [baseline] (317.071 ms) : 0, 317071
GlobalTracer [candidate] (301.458 ms) : 0, 301458
AppSec [baseline] (50.385 ms) : 0, 50385
AppSec [candidate] (49.67 ms) : 0, 49670
Logs Intake [candidate] (338.547 µs) : 0, 339
Remote Config [baseline] (687.317 µs) : 0, 687
Remote Config [candidate] (636.913 µs) : 0, 637
Telemetry [baseline] (7.727 ms) : 0, 7727
Telemetry [candidate] (7.65 ms) : 0, 7650
section appsec
BytebuddyAgent [baseline] (674.561 ms) : 0, 674561
BytebuddyAgent [candidate] (674.251 ms) : 0, 674251
GlobalTracer [baseline] (295.723 ms) : 0, 295723
GlobalTracer [candidate] (295.837 ms) : 0, 295837
AppSec [baseline] (152.305 ms) : 0, 152305
AppSec [candidate] (152.635 ms) : 0, 152635
Logs Intake [candidate] (330.808 µs) : 0, 331
Remote Config [baseline] (625.476 µs) : 0, 625
Remote Config [candidate] (609.638 µs) : 0, 610
Telemetry [baseline] (8.449 ms) : 0, 8449
Telemetry [candidate] (8.418 ms) : 0, 8418
IAST [baseline] (18.733 ms) : 0, 18733
IAST [candidate] (18.768 ms) : 0, 18768
section iast
BytebuddyAgent [baseline] (778.243 ms) : 0, 778243
BytebuddyAgent [candidate] (777.662 ms) : 0, 777662
GlobalTracer [baseline] (293.069 ms) : 0, 293069
GlobalTracer [candidate] (292.49 ms) : 0, 292490
AppSec [baseline] (49.151 ms) : 0, 49151
AppSec [candidate] (49.831 ms) : 0, 49831
Logs Intake [candidate] (304.461 µs) : 0, 304
Remote Config [baseline] (594.801 µs) : 0, 595
Remote Config [candidate] (570.415 µs) : 0, 570
Telemetry [baseline] (7.479 ms) : 0, 7479
Telemetry [candidate] (8.921 ms) : 0, 8921
IAST [baseline] (24.783 ms) : 0, 24783
IAST [candidate] (22.458 ms) : 0, 22458
section profiling
BytebuddyAgent [baseline] (670.637 ms) : 0, 670637
BytebuddyAgent [candidate] (661.282 ms) : 0, 661282
GlobalTracer [baseline] (389.486 ms) : 0, 389486
GlobalTracer [candidate] (385.549 ms) : 0, 385549
AppSec [baseline] (51.269 ms) : 0, 51269
AppSec [candidate] (50.651 ms) : 0, 50651
Logs Intake [candidate] (345.085 µs) : 0, 345
Remote Config [baseline] (781.126 µs) : 0, 781
Remote Config [candidate] (846.949 µs) : 0, 847
Telemetry [baseline] (7.573 ms) : 0, 7573
Telemetry [candidate] (7.459 ms) : 0, 7459
ProfilingAgent [baseline] (96.742 ms) : 0, 96742
ProfilingAgent [candidate] (95.651 ms) : 0, 95651
Profiling [baseline] (96.766 ms) : 0, 96766
Profiling [candidate] (95.675 ms) : 0, 95675
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~e482cd7b6d, baseline=1.35.0-SNAPSHOT~86231f4e3c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056336
Total [baseline] (8.531 s) : 0, 8531037
Agent [candidate] (1.059 s) : 0, 1059219
Total [candidate] (8.553 s) : 0, 8552588
section iast
Agent [baseline] (1.186 s) : 0, 1186240
Total [baseline] (9.027 s) : 0, 9027177
Agent [candidate] (1.189 s) : 0, 1189083
Total [candidate] (9.057 s) : 0, 9056915
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.191 s) : 0, 1191433
Total [baseline] (9.042 s) : 0, 9042169
Agent [candidate] (1.195 s) : 0, 1195226
Total [candidate] (9.017 s) : 0, 9016821
section iast_TELEMETRY_OFF
Agent [baseline] (1.189 s) : 0, 1189184
Total [baseline] (9.071 s) : 0, 9071404
Agent [candidate] (1.191 s) : 0, 1190687
Total [candidate] (9.07 s) : 0, 9070096
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent iast 1.186 s 129.904 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.191 s 135.097 ms (12.8%)
Agent iast_TELEMETRY_OFF 1.189 s 132.848 ms (12.6%)
Total tracing 8.531 s -
Total iast 9.027 s 496.14 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.042 s 511.132 ms (6.0%)
Total iast_TELEMETRY_OFF 9.071 s 540.367 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.059 s -
Agent iast 1.189 s 129.863 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.195 s 136.006 ms (12.8%)
Agent iast_TELEMETRY_OFF 1.191 s 131.467 ms (12.4%)
Total tracing 8.553 s -
Total iast 9.057 s 504.327 ms (5.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.017 s 464.232 ms (5.4%)
Total iast_TELEMETRY_OFF 9.07 s 517.508 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~e482cd7b6d, baseline=1.35.0-SNAPSHOT~86231f4e3c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (651.732 ms) : 0, 651732
BytebuddyAgent [candidate] (664.62 ms) : 0, 664620
GlobalTracer [baseline] (312.349 ms) : 0, 312349
GlobalTracer [candidate] (301.73 ms) : 0, 301730
AppSec [baseline] (49.674 ms) : 0, 49674
AppSec [candidate] (49.828 ms) : 0, 49828
Logs Intake [candidate] (329.945 µs) : 0, 330
Remote Config [baseline] (660.377 µs) : 0, 660
Remote Config [candidate] (645.101 µs) : 0, 645
Telemetry [baseline] (7.61 ms) : 0, 7610
Telemetry [candidate] (7.641 ms) : 0, 7641
section iast
BytebuddyAgent [baseline] (778.15 ms) : 0, 778150
BytebuddyAgent [candidate] (779.176 ms) : 0, 779176
GlobalTracer [baseline] (292.411 ms) : 0, 292411
GlobalTracer [candidate] (293.7 ms) : 0, 293700
AppSec [baseline] (47.586 ms) : 0, 47586
AppSec [candidate] (47.871 ms) : 0, 47871
IAST [baseline] (26.473 ms) : 0, 26473
IAST [candidate] (25.474 ms) : 0, 25474
Logs Intake [candidate] (305.55 µs) : 0, 306
Remote Config [baseline] (592.427 µs) : 0, 592
Remote Config [candidate] (574.876 µs) : 0, 575
Telemetry [baseline] (6.612 ms) : 0, 6612
Telemetry [candidate] (7.331 ms) : 0, 7331
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (782.138 ms) : 0, 782138
BytebuddyAgent [candidate] (783.745 ms) : 0, 783745
GlobalTracer [baseline] (294.05 ms) : 0, 294050
GlobalTracer [candidate] (294.834 ms) : 0, 294834
AppSec [baseline] (50.056 ms) : 0, 50056
AppSec [candidate] (47.692 ms) : 0, 47692
IAST [baseline] (23.247 ms) : 0, 23247
IAST [candidate] (25.102 ms) : 0, 25102
Logs Intake [candidate] (314.021 µs) : 0, 314
Remote Config [baseline] (592.895 µs) : 0, 593
Remote Config [candidate] (576.021 µs) : 0, 576
Telemetry [baseline] (6.691 ms) : 0, 6691
Telemetry [candidate] (8.27 ms) : 0, 8270
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (777.046 ms) : 0, 777046
BytebuddyAgent [candidate] (780.47 ms) : 0, 780470
GlobalTracer [baseline] (295.343 ms) : 0, 295343
GlobalTracer [candidate] (294.689 ms) : 0, 294689
AppSec [baseline] (48.581 ms) : 0, 48581
AppSec [candidate] (48.533 ms) : 0, 48533
IAST [baseline] (24.806 ms) : 0, 24806
IAST [candidate] (23.208 ms) : 0, 23208
Logs Intake [candidate] (297.763 µs) : 0, 298
Remote Config [baseline] (633.451 µs) : 0, 633
Remote Config [candidate] (607.32 µs) : 0, 607
Telemetry [baseline] (8.159 ms) : 0, 8159
Telemetry [candidate] (8.138 ms) : 0, 8138

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-29T13:45:10 2024-05-29T13:51:58
git_branch master nikita-tkachenko/agentless-log-submission
git_commit_date 1716978697 1716989101
git_commit_sha 86231f4 e482cd7
release_version 1.35.0-SNAPSHOT~86231f4e3c 1.35.0-SNAPSHOT~e482cd7b6d
start_time 2024-05-29T13:44:57 2024-05-29T13:51:45
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1716991061 1716991061
ci_job_id 525822553 525822553
ci_pipeline_id 35340771 35340771
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~e482cd7b6d, baseline=1.35.0-SNAPSHOT~86231f4e3c
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.127 µs) : 347, 386
.   : milestone, 366,
iast (481.985 µs) : 461, 503
.   : milestone, 482,
iast_FULL (545.517 µs) : 524, 567
.   : milestone, 546,
iast_GLOBAL (507.317 µs) : 484, 530
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (477.695 µs) : 456, 500
.   : milestone, 478,
iast_INACTIVE (455.772 µs) : 434, 477
.   : milestone, 456,
iast_TELEMETRY_OFF (472.351 µs) : 451, 494
.   : milestone, 472,
tracing (438.449 µs) : 418, 459
.   : milestone, 438,
section candidate
no_agent (363.302 µs) : 344, 383
.   : milestone, 363,
iast (477.707 µs) : 456, 499
.   : milestone, 478,
iast_FULL (552.722 µs) : 531, 574
.   : milestone, 553,
iast_GLOBAL (500.333 µs) : 479, 521
.   : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (475.235 µs) : 454, 496
.   : milestone, 475,
iast_INACTIVE (447.268 µs) : 426, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (473.729 µs) : 452, 495
.   : milestone, 474,
tracing (440.848 µs) : 420, 461
.   : milestone, 441,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.127 µs [346.712 µs, 385.542 µs] -
iast 481.985 µs [461.186 µs, 502.785 µs] 115.858 µs (31.6%)
iast_FULL 545.517 µs [524.325 µs, 566.709 µs] 179.389 µs (49.0%)
iast_GLOBAL 507.317 µs [484.318 µs, 530.317 µs] 141.19 µs (38.6%)
iast_HARDCODED_SECRET_DISABLED 477.695 µs [455.69 µs, 499.7 µs] 111.568 µs (30.5%)
iast_INACTIVE 455.772 µs [434.21 µs, 477.333 µs] 89.644 µs (24.5%)
iast_TELEMETRY_OFF 472.351 µs [450.724 µs, 493.979 µs] 106.224 µs (29.0%)
tracing 438.449 µs [417.8 µs, 459.099 µs] 72.322 µs (19.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.302 µs [343.503 µs, 383.101 µs] -
iast 477.707 µs [456.427 µs, 498.987 µs] 114.405 µs (31.5%)
iast_FULL 552.722 µs [531.289 µs, 574.156 µs] 189.42 µs (52.1%)
iast_GLOBAL 500.333 µs [479.428 µs, 521.237 µs] 137.031 µs (37.7%)
iast_HARDCODED_SECRET_DISABLED 475.235 µs [454.115 µs, 496.354 µs] 111.933 µs (30.8%)
iast_INACTIVE 447.268 µs [426.413 µs, 468.122 µs] 83.966 µs (23.1%)
iast_TELEMETRY_OFF 473.729 µs [451.972 µs, 495.486 µs] 110.427 µs (30.4%)
tracing 440.848 µs [420.326 µs, 461.371 µs] 77.546 µs (21.3%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~e482cd7b6d, baseline=1.35.0-SNAPSHOT~86231f4e3c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.348 ms) : 1329, 1367
.   : milestone, 1348,
appsec (1.725 ms) : 1701, 1750
.   : milestone, 1725,
appsec_no_iast (1.709 ms) : 1683, 1735
.   : milestone, 1709,
iast (1.476 ms) : 1454, 1499
.   : milestone, 1476,
profiling (1.473 ms) : 1449, 1497
.   : milestone, 1473,
tracing (1.444 ms) : 1420, 1468
.   : milestone, 1444,
section candidate
no_agent (1.339 ms) : 1318, 1359
.   : milestone, 1339,
appsec (1.711 ms) : 1686, 1736
.   : milestone, 1711,
appsec_no_iast (1.708 ms) : 1683, 1732
.   : milestone, 1708,
iast (1.477 ms) : 1455, 1500
.   : milestone, 1477,
profiling (1.475 ms) : 1450, 1499
.   : milestone, 1475,
tracing (1.447 ms) : 1423, 1472
.   : milestone, 1447,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.348 ms [1.329 ms, 1.367 ms] -
appsec 1.725 ms [1.701 ms, 1.75 ms] 377.103 µs (28.0%)
appsec_no_iast 1.709 ms [1.683 ms, 1.735 ms] 361.015 µs (26.8%)
iast 1.476 ms [1.454 ms, 1.499 ms] 127.978 µs (9.5%)
profiling 1.473 ms [1.449 ms, 1.497 ms] 124.826 µs (9.3%)
tracing 1.444 ms [1.42 ms, 1.468 ms] 95.419 µs (7.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.339 ms [1.318 ms, 1.359 ms] -
appsec 1.711 ms [1.686 ms, 1.736 ms] 372.207 µs (27.8%)
appsec_no_iast 1.708 ms [1.683 ms, 1.732 ms] 369.257 µs (27.6%)
iast 1.477 ms [1.455 ms, 1.5 ms] 138.718 µs (10.4%)
profiling 1.475 ms [1.45 ms, 1.499 ms] 136.114 µs (10.2%)
tracing 1.447 ms [1.423 ms, 1.472 ms] 108.65 µs (8.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/agentless-log-submission
git_commit_date 1716978697 1716989101
git_commit_sha 86231f4 e482cd7
release_version 1.35.0-SNAPSHOT~86231f4e3c 1.35.0-SNAPSHOT~e482cd7b6d
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1716991580 1716991580
ci_job_id 525822554 525822554
ci_pipeline_id 35340771 35340771
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~e482cd7b6d, baseline=1.35.0-SNAPSHOT~86231f4e3c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.463 ms) : 1452, 1475
.   : milestone, 1463,
appsec (2.213 ms) : 2179, 2247
.   : milestone, 2213,
iast (1.975 ms) : 1933, 2017
.   : milestone, 1975,
iast_GLOBAL (1.996 ms) : 1955, 2036
.   : milestone, 1996,
profiling (1.847 ms) : 1814, 1879
.   : milestone, 1847,
tracing (1.825 ms) : 1794, 1857
.   : milestone, 1825,
section candidate
no_agent (1.465 ms) : 1453, 1476
.   : milestone, 1465,
appsec (2.199 ms) : 2165, 2233
.   : milestone, 2199,
iast (1.957 ms) : 1917, 1997
.   : milestone, 1957,
iast_GLOBAL (1.998 ms) : 1958, 2039
.   : milestone, 1998,
profiling (1.836 ms) : 1804, 1868
.   : milestone, 1836,
tracing (1.835 ms) : 1802, 1867
.   : milestone, 1835,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.452 ms, 1.475 ms] -
appsec 2.213 ms [2.179 ms, 2.247 ms] 749.476 µs (51.2%)
iast 1.975 ms [1.933 ms, 2.017 ms] 511.55 µs (35.0%)
iast_GLOBAL 1.996 ms [1.955 ms, 2.036 ms] 532.352 µs (36.4%)
profiling 1.847 ms [1.814 ms, 1.879 ms] 383.126 µs (26.2%)
tracing 1.825 ms [1.794 ms, 1.857 ms] 361.719 µs (24.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.465 ms [1.453 ms, 1.476 ms] -
appsec 2.199 ms [2.165 ms, 2.233 ms] 734.681 µs (50.2%)
iast 1.957 ms [1.917 ms, 1.997 ms] 492.606 µs (33.6%)
iast_GLOBAL 1.998 ms [1.958 ms, 2.039 ms] 533.734 µs (36.4%)
profiling 1.836 ms [1.804 ms, 1.868 ms] 371.459 µs (25.4%)
tracing 1.835 ms [1.802 ms, 1.867 ms] 370.191 µs (25.3%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~e482cd7b6d, baseline=1.35.0-SNAPSHOT~86231f4e3c
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.461 s) : 15461000, 15461000
.   : milestone, 15461000,
appsec (14.907 s) : 14907000, 14907000
.   : milestone, 14907000,
iast (18.713 s) : 18713000, 18713000
.   : milestone, 18713000,
iast_GLOBAL (17.854 s) : 17854000, 17854000
.   : milestone, 17854000,
profiling (15.101 s) : 15101000, 15101000
.   : milestone, 15101000,
tracing (15.269 s) : 15269000, 15269000
.   : milestone, 15269000,
section candidate
no_agent (15.157 s) : 15157000, 15157000
.   : milestone, 15157000,
appsec (15.179 s) : 15179000, 15179000
.   : milestone, 15179000,
iast (19.078 s) : 19078000, 19078000
.   : milestone, 19078000,
iast_GLOBAL (17.777 s) : 17777000, 17777000
.   : milestone, 17777000,
profiling (15.187 s) : 15187000, 15187000
.   : milestone, 15187000,
tracing (15.183 s) : 15183000, 15183000
.   : milestone, 15183000,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.461 s [15.461 s, 15.461 s] -
appsec 14.907 s [14.907 s, 14.907 s] -554.0 ms (-3.6%)
iast 18.713 s [18.713 s, 18.713 s] 3.252 s (21.0%)
iast_GLOBAL 17.854 s [17.854 s, 17.854 s] 2.393 s (15.5%)
profiling 15.101 s [15.101 s, 15.101 s] -360.0 ms (-2.3%)
tracing 15.269 s [15.269 s, 15.269 s] -192.0 ms (-1.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.157 s [15.157 s, 15.157 s] -
appsec 15.179 s [15.179 s, 15.179 s] 22.0 ms (0.1%)
iast 19.078 s [19.078 s, 19.078 s] 3.921 s (25.9%)
iast_GLOBAL 17.777 s [17.777 s, 17.777 s] 2.62 s (17.3%)
profiling 15.187 s [15.187 s, 15.187 s] 30.0 ms (0.2%)
tracing 15.183 s [15.183 s, 15.183 s] 26.0 ms (0.2%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog force-pushed the nikita-tkachenko/agentless-log-submission branch from d5b8bff to 0b910b1 Compare May 29, 2024 09:53
@nikita-tkachenko-datadog nikita-tkachenko-datadog force-pushed the nikita-tkachenko/agentless-log-submission branch from 0b910b1 to 1539fb3 Compare May 29, 2024 09:55
@nikita-tkachenko-datadog nikita-tkachenko-datadog changed the title Nikita tkachenko/agentless log submission Implement agentless log submission for Log4j2 May 29, 2024
@nikita-tkachenko-datadog nikita-tkachenko-datadog removed the tag: experimental Experimental changes label May 29, 2024
@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review May 29, 2024 15:14
@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit edb2c3f into master Jun 7, 2024
81 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/agentless-log-submission branch June 7, 2024 08:45
@github-actions github-actions bot added this to the 1.35.0 milestone Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@am312 am312 am312 approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nikita-tkachenko-datadog @am312