-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use same approach as agent-tooling to setup otel-tooling instrumentPluginClasspath #7096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
added
tag: no release notes
Changes to exclude from release notes
comp: tooling
Build & Tooling
labels
May 30, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~0b2b5ae19e, baseline=1.35.0-SNAPSHOT~4b5cad9604
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062753
Total [baseline] (10.369 s) : 0, 10369399
Agent [candidate] (1.059 s) : 0, 1058989
Total [candidate] (10.331 s) : 0, 10331491
section appsec
Agent [baseline] (1.178 s) : 0, 1178345
Total [baseline] (10.543 s) : 0, 10542559
Agent [candidate] (1.183 s) : 0, 1182572
Total [candidate] (10.509 s) : 0, 10509357
section iast
Agent [baseline] (1.181 s) : 0, 1180865
Total [baseline] (10.823 s) : 0, 10822689
Agent [candidate] (1.173 s) : 0, 1172944
Total [candidate] (10.764 s) : 0, 10764407
section profiling
Agent [baseline] (1.259 s) : 0, 1258513
Total [baseline] (10.602 s) : 0, 10602276
Agent [candidate] (1.259 s) : 0, 1258839
Total [candidate] (10.574 s) : 0, 10574114
gantt
title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~0b2b5ae19e, baseline=1.35.0-SNAPSHOT~4b5cad9604
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (655.787 ms) : 0, 655787
BytebuddyAgent [candidate] (653.558 ms) : 0, 653558
GlobalTracer [baseline] (314.159 ms) : 0, 314159
GlobalTracer [candidate] (312.887 ms) : 0, 312887
AppSec [baseline] (50.029 ms) : 0, 50029
AppSec [candidate] (49.804 ms) : 0, 49804
Remote Config [baseline] (673.662 µs) : 0, 674
Remote Config [candidate] (670.576 µs) : 0, 671
Telemetry [baseline] (7.587 ms) : 0, 7587
Telemetry [candidate] (7.672 ms) : 0, 7672
section appsec
BytebuddyAgent [baseline] (676.253 ms) : 0, 676253
BytebuddyAgent [candidate] (679.452 ms) : 0, 679452
GlobalTracer [baseline] (296.193 ms) : 0, 296193
GlobalTracer [candidate] (296.882 ms) : 0, 296882
AppSec [baseline] (152.785 ms) : 0, 152785
AppSec [candidate] (153.107 ms) : 0, 153107
Remote Config [baseline] (621.951 µs) : 0, 622
Remote Config [candidate] (623.152 µs) : 0, 623
Telemetry [baseline] (8.712 ms) : 0, 8712
Telemetry [candidate] (8.456 ms) : 0, 8456
IAST [baseline] (18.663 ms) : 0, 18663
IAST [candidate] (18.65 ms) : 0, 18650
section iast
BytebuddyAgent [baseline] (789.649 ms) : 0, 789649
BytebuddyAgent [candidate] (784.019 ms) : 0, 784019
GlobalTracer [baseline] (296.532 ms) : 0, 296532
GlobalTracer [candidate] (294.062 ms) : 0, 294062
AppSec [baseline] (48.595 ms) : 0, 48595
AppSec [candidate] (49.522 ms) : 0, 49522
Remote Config [baseline] (606.429 µs) : 0, 606
Remote Config [candidate] (590.131 µs) : 0, 590
Telemetry [baseline] (7.784 ms) : 0, 7784
Telemetry [candidate] (8.395 ms) : 0, 8395
IAST [baseline] (24.332 ms) : 0, 24332
IAST [candidate] (23.075 ms) : 0, 23075
section profiling
BytebuddyAgent [baseline] (661.715 ms) : 0, 661715
BytebuddyAgent [candidate] (661.744 ms) : 0, 661744
GlobalTracer [baseline] (385.129 ms) : 0, 385129
GlobalTracer [candidate] (385.483 ms) : 0, 385483
AppSec [baseline] (50.377 ms) : 0, 50377
AppSec [candidate] (50.645 ms) : 0, 50645
Remote Config [baseline] (802.333 µs) : 0, 802
Remote Config [candidate] (889.116 µs) : 0, 889
Telemetry [baseline] (7.506 ms) : 0, 7506
Telemetry [candidate] (7.483 ms) : 0, 7483
ProfilingAgent [baseline] (96.526 ms) : 0, 96526
ProfilingAgent [candidate] (96.004 ms) : 0, 96004
Profiling [baseline] (96.55 ms) : 0, 96550
Profiling [candidate] (96.029 ms) : 0, 96029
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~0b2b5ae19e, baseline=1.35.0-SNAPSHOT~4b5cad9604
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1063069
Total [baseline] (8.56 s) : 0, 8560295
Agent [candidate] (1.058 s) : 0, 1058266
Total [candidate] (8.549 s) : 0, 8549202
section iast
Agent [baseline] (1.166 s) : 0, 1165872
Total [baseline] (8.995 s) : 0, 8994931
Agent [candidate] (1.163 s) : 0, 1162589
Total [candidate] (8.976 s) : 0, 8976228
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.162 s) : 0, 1162430
Total [baseline] (8.95 s) : 0, 8949573
Agent [candidate] (1.18 s) : 0, 1180272
Total [candidate] (9.018 s) : 0, 9018289
section iast_TELEMETRY_OFF
Agent [baseline] (1.161 s) : 0, 1160674
Total [baseline] (8.973 s) : 0, 8973363
Agent [candidate] (1.163 s) : 0, 1163002
Total [candidate] (8.979 s) : 0, 8978539
gantt
title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~0b2b5ae19e, baseline=1.35.0-SNAPSHOT~4b5cad9604
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (656.361 ms) : 0, 656361
BytebuddyAgent [candidate] (652.234 ms) : 0, 652234
GlobalTracer [baseline] (314.018 ms) : 0, 314018
GlobalTracer [candidate] (313.667 ms) : 0, 313667
AppSec [baseline] (49.908 ms) : 0, 49908
AppSec [candidate] (49.786 ms) : 0, 49786
Remote Config [baseline] (669.674 µs) : 0, 670
Remote Config [candidate] (671.805 µs) : 0, 672
Telemetry [baseline] (7.524 ms) : 0, 7524
Telemetry [candidate] (7.577 ms) : 0, 7577
section iast
BytebuddyAgent [baseline] (779.225 ms) : 0, 779225
BytebuddyAgent [candidate] (776.722 ms) : 0, 776722
GlobalTracer [baseline] (291.798 ms) : 0, 291798
GlobalTracer [candidate] (291.537 ms) : 0, 291537
AppSec [baseline] (50.915 ms) : 0, 50915
AppSec [candidate] (49.181 ms) : 0, 49181
IAST [baseline] (23.111 ms) : 0, 23111
IAST [candidate] (23.824 ms) : 0, 23824
Remote Config [baseline] (593.675 µs) : 0, 594
Remote Config [candidate] (586.942 µs) : 0, 587
Telemetry [baseline] (6.904 ms) : 0, 6904
Telemetry [candidate] (7.531 ms) : 0, 7531
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (776.256 ms) : 0, 776256
BytebuddyAgent [candidate] (788.235 ms) : 0, 788235
GlobalTracer [baseline] (291.134 ms) : 0, 291134
GlobalTracer [candidate] (295.434 ms) : 0, 295434
AppSec [baseline] (51.459 ms) : 0, 51459
AppSec [candidate] (50.386 ms) : 0, 50386
IAST [baseline] (22.908 ms) : 0, 22908
IAST [candidate] (25.221 ms) : 0, 25221
Remote Config [baseline] (580.323 µs) : 0, 580
Remote Config [candidate] (614.253 µs) : 0, 614
Telemetry [baseline] (6.818 ms) : 0, 6818
Telemetry [candidate] (6.956 ms) : 0, 6956
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (774.419 ms) : 0, 774419
BytebuddyAgent [candidate] (775.628 ms) : 0, 775628
GlobalTracer [baseline] (291.427 ms) : 0, 291427
GlobalTracer [candidate] (291.9 ms) : 0, 291900
AppSec [baseline] (52.63 ms) : 0, 52630
AppSec [candidate] (49.845 ms) : 0, 49845
IAST [baseline] (20.956 ms) : 0, 20956
IAST [candidate] (23.53 ms) : 0, 23530
Remote Config [baseline] (596.069 µs) : 0, 596
Remote Config [candidate] (577.901 µs) : 0, 578
Telemetry [baseline] (7.378 ms) : 0, 7378
Telemetry [candidate] (8.218 ms) : 0, 8218
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~0b2b5ae19e, baseline=1.35.0-SNAPSHOT~4b5cad9604
dateFormat X
axisFormat %s
section baseline
no_agent (1.335 ms) : 1316, 1354
. : milestone, 1335,
appsec (1.707 ms) : 1682, 1733
. : milestone, 1707,
appsec_no_iast (1.726 ms) : 1701, 1750
. : milestone, 1726,
iast (1.484 ms) : 1461, 1507
. : milestone, 1484,
profiling (1.495 ms) : 1470, 1521
. : milestone, 1495,
tracing (1.468 ms) : 1445, 1492
. : milestone, 1468,
section candidate
no_agent (1.342 ms) : 1322, 1361
. : milestone, 1342,
appsec (1.71 ms) : 1686, 1734
. : milestone, 1710,
appsec_no_iast (1.727 ms) : 1702, 1752
. : milestone, 1727,
iast (1.493 ms) : 1470, 1516
. : milestone, 1493,
profiling (1.477 ms) : 1452, 1501
. : milestone, 1477,
tracing (1.472 ms) : 1448, 1497
. : milestone, 1472,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~0b2b5ae19e, baseline=1.35.0-SNAPSHOT~4b5cad9604
dateFormat X
axisFormat %s
section baseline
no_agent (369.91 µs) : 351, 389
. : milestone, 370,
iast (487.017 µs) : 466, 508
. : milestone, 487,
iast_FULL (552.152 µs) : 531, 573
. : milestone, 552,
iast_GLOBAL (506.342 µs) : 485, 528
. : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (491.113 µs) : 470, 513
. : milestone, 491,
iast_INACTIVE (454.979 µs) : 434, 476
. : milestone, 455,
iast_TELEMETRY_OFF (478.942 µs) : 457, 500
. : milestone, 479,
tracing (448.48 µs) : 428, 469
. : milestone, 448,
section candidate
no_agent (369.75 µs) : 350, 389
. : milestone, 370,
iast (486.86 µs) : 466, 508
. : milestone, 487,
iast_FULL (551.582 µs) : 530, 573
. : milestone, 552,
iast_GLOBAL (504.514 µs) : 483, 526
. : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (485.64 µs) : 464, 507
. : milestone, 486,
iast_INACTIVE (456.116 µs) : 435, 477
. : milestone, 456,
iast_TELEMETRY_OFF (473.287 µs) : 452, 494
. : milestone, 473,
tracing (446.393 µs) : 426, 467
. : milestone, 446,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~0b2b5ae19e, baseline=1.35.0-SNAPSHOT~4b5cad9604
dateFormat X
axisFormat %s
section baseline
no_agent (15.288 s) : 15288000, 15288000
. : milestone, 15288000,
appsec (15.034 s) : 15034000, 15034000
. : milestone, 15034000,
iast (18.74 s) : 18740000, 18740000
. : milestone, 18740000,
iast_GLOBAL (17.871 s) : 17871000, 17871000
. : milestone, 17871000,
profiling (14.97 s) : 14970000, 14970000
. : milestone, 14970000,
tracing (15.113 s) : 15113000, 15113000
. : milestone, 15113000,
section candidate
no_agent (15.507 s) : 15507000, 15507000
. : milestone, 15507000,
appsec (15.187 s) : 15187000, 15187000
. : milestone, 15187000,
iast (19.0 s) : 19000000, 19000000
. : milestone, 19000000,
iast_GLOBAL (17.916 s) : 17916000, 17916000
. : milestone, 17916000,
profiling (15.032 s) : 15032000, 15032000
. : milestone, 15032000,
tracing (14.789 s) : 14789000, 14789000
. : milestone, 14789000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~0b2b5ae19e, baseline=1.35.0-SNAPSHOT~4b5cad9604
dateFormat X
axisFormat %s
section baseline
no_agent (1.461 ms) : 1450, 1473
. : milestone, 1461,
appsec (2.208 ms) : 2174, 2243
. : milestone, 2208,
iast (1.963 ms) : 1923, 2004
. : milestone, 1963,
iast_GLOBAL (2.0 ms) : 1960, 2041
. : milestone, 2000,
profiling (1.846 ms) : 1813, 1880
. : milestone, 1846,
tracing (1.831 ms) : 1798, 1863
. : milestone, 1831,
section candidate
no_agent (1.46 ms) : 1449, 1472
. : milestone, 1460,
appsec (2.2 ms) : 2166, 2234
. : milestone, 2200,
iast (1.969 ms) : 1928, 2010
. : milestone, 1969,
iast_GLOBAL (1.997 ms) : 1956, 2037
. : milestone, 1997,
profiling (1.842 ms) : 1809, 1874
. : milestone, 1842,
tracing (1.834 ms) : 1801, 1866
. : milestone, 1834,
|
PerfectSlayer
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully address the intermittent failure to find
OtelShimGradlePlugin
seen recently in CI