Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detailed debug logging for tracing/profiler context integration #7115

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Add detailed debug logging for tracing/profiler context integration #7115

merged 1 commit into from
Jun 4, 2024

Conversation

richardstartin
Copy link
Member

What Does This Do

Adds a detailed debugging mode for the profiler to diagnose when the tracer sets zero span context unexpectedly.

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

@richardstartin richardstartin requested review from a team as code owners June 3, 2024 18:45
@pr-commenter
Copy link

pr-commenter bot commented Jun 3, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master rgs/debug-logging-null-context
git_commit_date 1717433505 1717440305
git_commit_sha bffe40c 412d6ec
release_version 1.35.0-SNAPSHOT~bffe40c766 1.35.0-SNAPSHOT~412d6ecf01
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717443160 1717443160
ci_job_id 530828917 530828917
ci_pipeline_id 35733516 35733516
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~412d6ecf01, baseline=1.35.0-SNAPSHOT~bffe40c766

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1057699
Total [baseline] (10.308 s) : 0, 10307895
Agent [candidate] (1.066 s) : 0, 1065807
Total [candidate] (10.328 s) : 0, 10327740
section appsec
Agent [baseline] (1.175 s) : 0, 1174643
Total [baseline] (10.543 s) : 0, 10542570
Agent [candidate] (1.181 s) : 0, 1181345
Total [candidate] (10.565 s) : 0, 10564704
section iast
Agent [baseline] (1.169 s) : 0, 1168599
Total [baseline] (10.833 s) : 0, 10832926
Agent [candidate] (1.169 s) : 0, 1168545
Total [candidate] (10.837 s) : 0, 10836943
section profiling
Agent [baseline] (1.258 s) : 0, 1258417
Total [baseline] (10.609 s) : 0, 10609468
Agent [candidate] (1.262 s) : 0, 1261925
Total [candidate] (10.772 s) : 0, 10772436
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.058 s -
Agent appsec 1.175 s 116.945 ms (11.1%)
Agent iast 1.169 s 110.901 ms (10.5%)
Agent profiling 1.258 s 200.718 ms (19.0%)
Total tracing 10.308 s -
Total appsec 10.543 s 234.675 ms (2.3%)
Total iast 10.833 s 525.031 ms (5.1%)
Total profiling 10.609 s 301.573 ms (2.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent appsec 1.181 s 115.538 ms (10.8%)
Agent iast 1.169 s 102.739 ms (9.6%)
Agent profiling 1.262 s 196.119 ms (18.4%)
Total tracing 10.328 s -
Total appsec 10.565 s 236.964 ms (2.3%)
Total iast 10.837 s 509.203 ms (4.9%)
Total profiling 10.772 s 444.696 ms (4.3%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~412d6ecf01, baseline=1.35.0-SNAPSHOT~bffe40c766

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (652.646 ms) : 0, 652646
BytebuddyAgent [candidate] (657.372 ms) : 0, 657372
GlobalTracer [baseline] (313.018 ms) : 0, 313018
GlobalTracer [candidate] (315.518 ms) : 0, 315518
AppSec [baseline] (49.457 ms) : 0, 49457
AppSec [candidate] (49.961 ms) : 0, 49961
Remote Config [baseline] (661.959 µs) : 0, 662
Remote Config [candidate] (680.191 µs) : 0, 680
Telemetry [baseline] (7.5 ms) : 0, 7500
Telemetry [candidate] (7.67 ms) : 0, 7670
section appsec
BytebuddyAgent [baseline] (673.835 ms) : 0, 673835
BytebuddyAgent [candidate] (678.759 ms) : 0, 678759
GlobalTracer [baseline] (296.623 ms) : 0, 296623
GlobalTracer [candidate] (297.548 ms) : 0, 297548
AppSec [baseline] (152.197 ms) : 0, 152197
AppSec [candidate] (152.924 ms) : 0, 152924
Remote Config [baseline] (618.518 µs) : 0, 619
Remote Config [candidate] (627.109 µs) : 0, 627
Telemetry [baseline] (7.76 ms) : 0, 7760
Telemetry [candidate] (7.558 ms) : 0, 7558
IAST [baseline] (18.635 ms) : 0, 18635
IAST [candidate] (18.738 ms) : 0, 18738
section iast
BytebuddyAgent [baseline] (780.515 ms) : 0, 780515
BytebuddyAgent [candidate] (780.853 ms) : 0, 780853
GlobalTracer [baseline] (293.244 ms) : 0, 293244
GlobalTracer [candidate] (292.94 ms) : 0, 292940
AppSec [baseline] (50.087 ms) : 0, 50087
AppSec [candidate] (49.866 ms) : 0, 49866
Remote Config [baseline] (600.607 µs) : 0, 601
Remote Config [candidate] (620.864 µs) : 0, 621
Telemetry [baseline] (7.683 ms) : 0, 7683
Telemetry [candidate] (8.601 ms) : 0, 8601
IAST [baseline] (23.18 ms) : 0, 23180
IAST [candidate] (22.409 ms) : 0, 22409
section profiling
ProfilingAgent [baseline] (95.527 ms) : 0, 95527
ProfilingAgent [candidate] (97.041 ms) : 0, 97041
BytebuddyAgent [baseline] (661.399 ms) : 0, 661399
BytebuddyAgent [candidate] (663.921 ms) : 0, 663921
GlobalTracer [baseline] (386.282 ms) : 0, 386282
GlobalTracer [candidate] (385.797 ms) : 0, 385797
AppSec [baseline] (50.458 ms) : 0, 50458
AppSec [candidate] (50.165 ms) : 0, 50165
Remote Config [baseline] (787.895 µs) : 0, 788
Remote Config [candidate] (824.728 µs) : 0, 825
Telemetry [baseline] (7.439 ms) : 0, 7439
Telemetry [candidate] (7.464 ms) : 0, 7464
Profiling [baseline] (95.551 ms) : 0, 95551
Profiling [candidate] (97.067 ms) : 0, 97067
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~412d6ecf01, baseline=1.35.0-SNAPSHOT~bffe40c766

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062966
Total [baseline] (8.577 s) : 0, 8576629
Agent [candidate] (1.058 s) : 0, 1058182
Total [candidate] (8.552 s) : 0, 8552194
section iast
Agent [baseline] (1.165 s) : 0, 1164943
Total [baseline] (9.006 s) : 0, 9006362
Agent [candidate] (1.168 s) : 0, 1168166
Total [candidate] (9.025 s) : 0, 9025063
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.164 s) : 0, 1164322
Total [baseline] (8.993 s) : 0, 8993424
Agent [candidate] (1.2 s) : 0, 1200310
Total [candidate] (9.097 s) : 0, 9097283
section iast_TELEMETRY_OFF
Agent [baseline] (1.164 s) : 0, 1164071
Total [baseline] (9.002 s) : 0, 9002285
Agent [candidate] (1.174 s) : 0, 1173752
Total [candidate] (9.082 s) : 0, 9081750
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent iast 1.165 s 101.978 ms (9.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.164 s 101.357 ms (9.5%)
Agent iast_TELEMETRY_OFF 1.164 s 101.106 ms (9.5%)
Total tracing 8.577 s -
Total iast 9.006 s 429.732 ms (5.0%)
Total iast_HARDCODED_SECRET_DISABLED 8.993 s 416.795 ms (4.9%)
Total iast_TELEMETRY_OFF 9.002 s 425.656 ms (5.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.058 s -
Agent iast 1.168 s 109.984 ms (10.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.2 s 142.128 ms (13.4%)
Agent iast_TELEMETRY_OFF 1.174 s 115.57 ms (10.9%)
Total tracing 8.552 s -
Total iast 9.025 s 472.868 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.097 s 545.089 ms (6.4%)
Total iast_TELEMETRY_OFF 9.082 s 529.556 ms (6.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~412d6ecf01, baseline=1.35.0-SNAPSHOT~bffe40c766

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (657.197 ms) : 0, 657197
BytebuddyAgent [candidate] (652.277 ms) : 0, 652277
GlobalTracer [baseline] (313.17 ms) : 0, 313170
GlobalTracer [candidate] (313.406 ms) : 0, 313406
AppSec [baseline] (49.633 ms) : 0, 49633
AppSec [candidate] (49.831 ms) : 0, 49831
Remote Config [baseline] (660.961 µs) : 0, 661
Remote Config [candidate] (665.214 µs) : 0, 665
Telemetry [baseline] (7.567 ms) : 0, 7567
Telemetry [candidate] (7.584 ms) : 0, 7584
section iast
BytebuddyAgent [baseline] (777.991 ms) : 0, 777991
BytebuddyAgent [candidate] (779.501 ms) : 0, 779501
GlobalTracer [baseline] (292.408 ms) : 0, 292408
GlobalTracer [candidate] (292.869 ms) : 0, 292869
AppSec [baseline] (47.601 ms) : 0, 47601
AppSec [candidate] (46.109 ms) : 0, 46109
IAST [baseline] (25.528 ms) : 0, 25528
IAST [candidate] (28.109 ms) : 0, 28109
Remote Config [baseline] (586.794 µs) : 0, 587
Remote Config [candidate] (618.769 µs) : 0, 619
Telemetry [baseline] (7.6 ms) : 0, 7600
Telemetry [candidate] (7.672 ms) : 0, 7672
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (776.822 ms) : 0, 776822
BytebuddyAgent [candidate] (799.05 ms) : 0, 799050
GlobalTracer [baseline] (292.579 ms) : 0, 292579
GlobalTracer [candidate] (302.932 ms) : 0, 302932
AppSec [baseline] (49.438 ms) : 0, 49438
AppSec [candidate] (49.561 ms) : 0, 49561
IAST [baseline] (24.671 ms) : 0, 24671
IAST [candidate] (25.799 ms) : 0, 25799
Remote Config [baseline] (600.287 µs) : 0, 600
Remote Config [candidate] (648.961 µs) : 0, 649
Telemetry [baseline] (6.911 ms) : 0, 6911
Telemetry [candidate] (8.683 ms) : 0, 8683
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (776.361 ms) : 0, 776361
BytebuddyAgent [candidate] (783.901 ms) : 0, 783901
GlobalTracer [baseline] (292.991 ms) : 0, 292991
GlobalTracer [candidate] (294.791 ms) : 0, 294791
AppSec [baseline] (49.916 ms) : 0, 49916
AppSec [candidate] (49.131 ms) : 0, 49131
IAST [baseline] (22.641 ms) : 0, 22641
IAST [candidate] (24.149 ms) : 0, 24149
Remote Config [baseline] (603.275 µs) : 0, 603
Remote Config [candidate] (645.294 µs) : 0, 645
Telemetry [baseline] (8.238 ms) : 0, 8238
Telemetry [candidate] (7.708 ms) : 0, 7708

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-03T19:03:19 2024-06-03T19:10:05
git_branch master rgs/debug-logging-null-context
git_commit_date 1717433505 1717440305
git_commit_sha bffe40c 412d6ec
release_version 1.35.0-SNAPSHOT~bffe40c766 1.35.0-SNAPSHOT~412d6ecf01
start_time 2024-06-03T19:03:06 2024-06-03T19:09:52
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717442148 1717442148
ci_job_id 530828918 530828918
ci_pipeline_id 35733516 35733516
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~412d6ecf01, baseline=1.35.0-SNAPSHOT~bffe40c766
    dateFormat X
    axisFormat %s
section baseline
no_agent (363.51 µs) : 343, 384
.   : milestone, 364,
iast (481.26 µs) : 459, 503
.   : milestone, 481,
iast_FULL (541.499 µs) : 520, 563
.   : milestone, 541,
iast_GLOBAL (502.453 µs) : 480, 524
.   : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (476.861 µs) : 456, 498
.   : milestone, 477,
iast_INACTIVE (443.859 µs) : 423, 465
.   : milestone, 444,
iast_TELEMETRY_OFF (472.72 µs) : 450, 495
.   : milestone, 473,
tracing (438.263 µs) : 417, 459
.   : milestone, 438,
section candidate
no_agent (364.873 µs) : 346, 384
.   : milestone, 365,
iast (477.167 µs) : 456, 499
.   : milestone, 477,
iast_FULL (541.031 µs) : 520, 562
.   : milestone, 541,
iast_GLOBAL (507.12 µs) : 485, 529
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (483.038 µs) : 461, 505
.   : milestone, 483,
iast_INACTIVE (446.554 µs) : 426, 467
.   : milestone, 447,
iast_TELEMETRY_OFF (458.639 µs) : 438, 479
.   : milestone, 459,
tracing (436.033 µs) : 416, 456
.   : milestone, 436,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.51 µs [343.428 µs, 383.593 µs] -
iast 481.26 µs [459.172 µs, 503.349 µs] 117.75 µs (32.4%)
iast_FULL 541.499 µs [520.224 µs, 562.775 µs] 177.989 µs (49.0%)
iast_GLOBAL 502.453 µs [480.479 µs, 524.427 µs] 138.943 µs (38.2%)
iast_HARDCODED_SECRET_DISABLED 476.861 µs [455.596 µs, 498.126 µs] 113.351 µs (31.2%)
iast_INACTIVE 443.859 µs [422.81 µs, 464.908 µs] 80.348 µs (22.1%)
iast_TELEMETRY_OFF 472.72 µs [450.363 µs, 495.077 µs] 109.21 µs (30.0%)
tracing 438.263 µs [417.303 µs, 459.223 µs] 74.753 µs (20.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.873 µs [345.569 µs, 384.178 µs] -
iast 477.167 µs [455.691 µs, 498.643 µs] 112.294 µs (30.8%)
iast_FULL 541.031 µs [520.16 µs, 561.901 µs] 176.157 µs (48.3%)
iast_GLOBAL 507.12 µs [485.009 µs, 529.232 µs] 142.247 µs (39.0%)
iast_HARDCODED_SECRET_DISABLED 483.038 µs [461.385 µs, 504.69 µs] 118.164 µs (32.4%)
iast_INACTIVE 446.554 µs [425.674 µs, 467.434 µs] 81.68 µs (22.4%)
iast_TELEMETRY_OFF 458.639 µs [437.928 µs, 479.35 µs] 93.766 µs (25.7%)
tracing 436.033 µs [415.726 µs, 456.34 µs] 71.16 µs (19.5%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~412d6ecf01, baseline=1.35.0-SNAPSHOT~bffe40c766
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.327 ms) : 1307, 1347
.   : milestone, 1327,
appsec (1.712 ms) : 1687, 1737
.   : milestone, 1712,
appsec_no_iast (1.693 ms) : 1667, 1718
.   : milestone, 1693,
iast (1.465 ms) : 1440, 1489
.   : milestone, 1465,
profiling (1.504 ms) : 1480, 1527
.   : milestone, 1504,
tracing (1.449 ms) : 1424, 1473
.   : milestone, 1449,
section candidate
no_agent (1.333 ms) : 1315, 1352
.   : milestone, 1333,
appsec (1.71 ms) : 1686, 1735
.   : milestone, 1710,
appsec_no_iast (1.695 ms) : 1670, 1720
.   : milestone, 1695,
iast (1.471 ms) : 1448, 1494
.   : milestone, 1471,
profiling (1.498 ms) : 1472, 1524
.   : milestone, 1498,
tracing (1.455 ms) : 1431, 1479
.   : milestone, 1455,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.327 ms [1.307 ms, 1.347 ms] -
appsec 1.712 ms [1.687 ms, 1.737 ms] 384.921 µs (29.0%)
appsec_no_iast 1.693 ms [1.667 ms, 1.718 ms] 365.378 µs (27.5%)
iast 1.465 ms [1.44 ms, 1.489 ms] 137.473 µs (10.4%)
profiling 1.504 ms [1.48 ms, 1.527 ms] 176.522 µs (13.3%)
tracing 1.449 ms [1.424 ms, 1.473 ms] 121.682 µs (9.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.333 ms [1.315 ms, 1.352 ms] -
appsec 1.71 ms [1.686 ms, 1.735 ms] 376.72 µs (28.3%)
appsec_no_iast 1.695 ms [1.67 ms, 1.72 ms] 361.737 µs (27.1%)
iast 1.471 ms [1.448 ms, 1.494 ms] 137.492 µs (10.3%)
profiling 1.498 ms [1.472 ms, 1.524 ms] 164.608 µs (12.3%)
tracing 1.455 ms [1.431 ms, 1.479 ms] 121.917 µs (9.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master rgs/debug-logging-null-context
git_commit_date 1717433505 1717440305
git_commit_sha bffe40c 412d6ec
release_version 1.35.0-SNAPSHOT~bffe40c766 1.35.0-SNAPSHOT~412d6ecf01
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1717442651 1717442651
ci_job_id 530828919 530828919
ci_pipeline_id 35733516 35733516
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~412d6ecf01, baseline=1.35.0-SNAPSHOT~bffe40c766
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.952 s) : 14952000, 14952000
.   : milestone, 14952000,
appsec (15.182 s) : 15182000, 15182000
.   : milestone, 15182000,
iast (18.865 s) : 18865000, 18865000
.   : milestone, 18865000,
iast_GLOBAL (17.899 s) : 17899000, 17899000
.   : milestone, 17899000,
profiling (15.106 s) : 15106000, 15106000
.   : milestone, 15106000,
tracing (15.069 s) : 15069000, 15069000
.   : milestone, 15069000,
section candidate
no_agent (14.979 s) : 14979000, 14979000
.   : milestone, 14979000,
appsec (15.178 s) : 15178000, 15178000
.   : milestone, 15178000,
iast (18.735 s) : 18735000, 18735000
.   : milestone, 18735000,
iast_GLOBAL (18.018 s) : 18018000, 18018000
.   : milestone, 18018000,
profiling (15.4 s) : 15400000, 15400000
.   : milestone, 15400000,
tracing (15.096 s) : 15096000, 15096000
.   : milestone, 15096000,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.952 s [14.952 s, 14.952 s] -
appsec 15.182 s [15.182 s, 15.182 s] 230.0 ms (1.5%)
iast 18.865 s [18.865 s, 18.865 s] 3.913 s (26.2%)
iast_GLOBAL 17.899 s [17.899 s, 17.899 s] 2.947 s (19.7%)
profiling 15.106 s [15.106 s, 15.106 s] 154.0 ms (1.0%)
tracing 15.069 s [15.069 s, 15.069 s] 117.0 ms (0.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.979 s [14.979 s, 14.979 s] -
appsec 15.178 s [15.178 s, 15.178 s] 199.0 ms (1.3%)
iast 18.735 s [18.735 s, 18.735 s] 3.756 s (25.1%)
iast_GLOBAL 18.018 s [18.018 s, 18.018 s] 3.039 s (20.3%)
profiling 15.4 s [15.4 s, 15.4 s] 421.0 ms (2.8%)
tracing 15.096 s [15.096 s, 15.096 s] 117.0 ms (0.8%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~412d6ecf01, baseline=1.35.0-SNAPSHOT~bffe40c766
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.46 ms) : 1449, 1472
.   : milestone, 1460,
appsec (2.197 ms) : 2162, 2232
.   : milestone, 2197,
iast (1.961 ms) : 1920, 2002
.   : milestone, 1961,
iast_GLOBAL (1.975 ms) : 1934, 2016
.   : milestone, 1975,
profiling (1.83 ms) : 1797, 1862
.   : milestone, 1830,
tracing (1.821 ms) : 1788, 1854
.   : milestone, 1821,
section candidate
no_agent (1.455 ms) : 1444, 1467
.   : milestone, 1455,
appsec (2.192 ms) : 2158, 2225
.   : milestone, 2192,
iast (1.941 ms) : 1900, 1982
.   : milestone, 1941,
iast_GLOBAL (1.994 ms) : 1953, 2035
.   : milestone, 1994,
profiling (1.836 ms) : 1803, 1869
.   : milestone, 1836,
tracing (1.813 ms) : 1782, 1845
.   : milestone, 1813,
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.449 ms, 1.472 ms] -
appsec 2.197 ms [2.162 ms, 2.232 ms] 736.672 µs (50.4%)
iast 1.961 ms [1.92 ms, 2.002 ms] 500.809 µs (34.3%)
iast_GLOBAL 1.975 ms [1.934 ms, 2.016 ms] 514.522 µs (35.2%)
profiling 1.83 ms [1.797 ms, 1.862 ms] 369.341 µs (25.3%)
tracing 1.821 ms [1.788 ms, 1.854 ms] 360.456 µs (24.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.455 ms [1.444 ms, 1.467 ms] -
appsec 2.192 ms [2.158 ms, 2.225 ms] 736.16 µs (50.6%)
iast 1.941 ms [1.9 ms, 1.982 ms] 485.35 µs (33.3%)
iast_GLOBAL 1.994 ms [1.953 ms, 2.035 ms] 538.699 µs (37.0%)
profiling 1.836 ms [1.803 ms, 1.869 ms] 380.465 µs (26.1%)
tracing 1.813 ms [1.782 ms, 1.845 ms] 358.079 µs (24.6%)

@PerfectSlayer PerfectSlayer added tag: diagnostics Diagnostics related changes comp: profiling Profiling labels Jun 4, 2024
@PerfectSlayer PerfectSlayer changed the title add detailed debug logging for tracing/profiler context integration Add detailed debug logging for tracing/profiler context integration Jun 4, 2024
@richardstartin richardstartin force-pushed the rgs/debug-logging-null-context branch from 412d6ec to 35506b9 Compare June 4, 2024 08:17
@richardstartin richardstartin merged commit ad2cc7a into master Jun 4, 2024
79 of 80 checks passed
@richardstartin richardstartin deleted the rgs/debug-logging-null-context branch June 4, 2024 09:38
@github-actions github-actions bot added this to the 1.35.0 milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcculls mcculls mcculls approved these changes

@jbachorik jbachorik jbachorik approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@am312 am312 Awaiting requested review from am312 am312 is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: profiling Profiling tag: diagnostics Diagnostics related changes
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@richardstartin @mcculls @jbachorik @PerfectSlayer