Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure locals are in scope when generating metrics #7121

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Ensure locals are in scope when generating metrics #7121

merged 1 commit into from
Jun 4, 2024

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Jun 4, 2024 •
edited by jira bot
Loading

What Does This Do

Verify that where the metric is inserted, the local variable that we
try to access is in scope (from the LocalVariableTable)
We are doing this for CapturedContext now we add this for metrics to avoid having a VerifyError raised because the variable is not accessible or reused with another type than expected.

Motivation

avoid VerifyError exception when loading the instrumented class

Additional Notes

Jira ticket: DEBUG-2400

@jpbempel
Ensure locals are in scope when generating metrics
95d4f51 
Verify that where the metric is inserted, the local variable that we
 try to access is in scope (from the LocalVariableTable)
We are doing this for CapturedContext now we add this for metrics
to avoid having a VerifyError raised because the variable is not
accessible or reused with another type than expected.
@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label Jun 4, 2024
@jpbempel jpbempel requested a review from a team as a code owner June 4, 2024 08:29
@jpbempel jpbempel requested review from shatzi and removed request for a team June 4, 2024 08:29
@pr-commenter
Copy link

pr-commenter bot commented Jun 4, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/metric-local-var-in-scope
git_commit_date 1717485683 1717489580
git_commit_sha 70f9058 95d4f51
release_version 1.35.0-SNAPSHOT~70f9058751 1.35.0-SNAPSHOT~95d4f51838
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717492991 1717492991
ci_job_id 531274540 531274540
ci_pipeline_id 35769932 35769932
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 8 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~95d4f51838, baseline=1.35.0-SNAPSHOT~70f9058751

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.574 s) : 0, 1574228
Total [baseline] (14.206 s) : 0, 14206363
Agent [candidate] (1.571 s) : 0, 1570951
Total [candidate] (14.231 s) : 0, 14230633
section appsec
Agent [baseline] (1.749 s) : 0, 1749086
Total [baseline] (14.317 s) : 0, 14316855
Agent [candidate] (1.748 s) : 0, 1748238
Total [candidate] (14.426 s) : 0, 14425882
section iast
Agent [baseline] (1.709 s) : 0, 1708653
Total [baseline] (14.701 s) : 0, 14700710
Agent [candidate] (1.706 s) : 0, 1705994
Total [candidate] (14.741 s) : 0, 14740981
section profiling
Agent [baseline] (1.885 s) : 0, 1884655
Total [baseline] (14.672 s) : 0, 14671994
Agent [candidate] (1.879 s) : 0, 1879392
Total [candidate] (14.698 s) : 0, 14698004
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.574 s -
Agent appsec 1.749 s 174.858 ms (11.1%)
Agent iast 1.709 s 134.425 ms (8.5%)
Agent profiling 1.885 s 310.427 ms (19.7%)
Total tracing 14.206 s -
Total appsec 14.317 s 110.492 ms (0.8%)
Total iast 14.701 s 494.347 ms (3.5%)
Total profiling 14.672 s 465.631 ms (3.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.571 s -
Agent appsec 1.748 s 177.287 ms (11.3%)
Agent iast 1.706 s 135.044 ms (8.6%)
Agent profiling 1.879 s 308.441 ms (19.6%)
Total tracing 14.231 s -
Total appsec 14.426 s 195.25 ms (1.4%)
Total iast 14.741 s 510.349 ms (3.6%)
Total profiling 14.698 s 467.371 ms (3.3%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~95d4f51838, baseline=1.35.0-SNAPSHOT~70f9058751

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (969.715 ms) : 0, 969715
BytebuddyAgent [candidate] (966.739 ms) : 0, 966739
GlobalTracer [baseline] (462.093 ms) : 0, 462093
GlobalTracer [candidate] (461.771 ms) : 0, 461771
AppSec [baseline] (71.127 ms) : 0, 71127
AppSec [candidate] (71.265 ms) : 0, 71265
Remote Config [baseline] (835.999 µs) : 0, 836
Remote Config [candidate] (833.936 µs) : 0, 834
Telemetry [baseline] (9.87 ms) : 0, 9870
Telemetry [candidate] (9.841 ms) : 0, 9841
section appsec
BytebuddyAgent [baseline] (999.047 ms) : 0, 999047
BytebuddyAgent [candidate] (998.214 ms) : 0, 998214
GlobalTracer [baseline] (436.486 ms) : 0, 436486
GlobalTracer [candidate] (436.329 ms) : 0, 436329
AppSec [baseline] (231.451 ms) : 0, 231451
AppSec [candidate] (231.463 ms) : 0, 231463
IAST [baseline] (23.967 ms) : 0, 23967
IAST [candidate] (24.129 ms) : 0, 24129
Remote Config [baseline] (782.084 µs) : 0, 782
Remote Config [candidate] (778.671 µs) : 0, 779
Telemetry [baseline] (8.873 ms) : 0, 8873
Telemetry [candidate] (8.837 ms) : 0, 8837
section iast
BytebuddyAgent [baseline] (1.146 s) : 0, 1146242
BytebuddyAgent [candidate] (1.145 s) : 0, 1145342
GlobalTracer [baseline] (432.259 ms) : 0, 432259
GlobalTracer [candidate] (430.518 ms) : 0, 430518
AppSec [baseline] (66.784 ms) : 0, 66784
AppSec [candidate] (68.238 ms) : 0, 68238
IAST [baseline] (33.968 ms) : 0, 33968
IAST [candidate] (30.655 ms) : 0, 30655
Remote Config [baseline] (761.528 µs) : 0, 762
Remote Config [candidate] (775.202 µs) : 0, 775
Telemetry [baseline] (8.973 ms) : 0, 8973
Telemetry [candidate] (10.728 ms) : 0, 10728
section profiling
BytebuddyAgent [baseline] (979.779 ms) : 0, 979779
BytebuddyAgent [candidate] (979.255 ms) : 0, 979255
GlobalTracer [baseline] (577.352 ms) : 0, 577352
GlobalTracer [candidate] (575.014 ms) : 0, 575014
AppSec [baseline] (73.423 ms) : 0, 73423
AppSec [candidate] (71.656 ms) : 0, 71656
Remote Config [baseline] (944.132 µs) : 0, 944
Remote Config [candidate] (974.502 µs) : 0, 975
Telemetry [baseline] (9.531 ms) : 0, 9531
Telemetry [candidate] (9.791 ms) : 0, 9791
ProfilingAgent [baseline] (150.439 ms) : 0, 150439
ProfilingAgent [candidate] (149.578 ms) : 0, 149578
Profiling [baseline] (150.5 ms) : 0, 150500
Profiling [candidate] (149.635 ms) : 0, 149635
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~95d4f51838, baseline=1.35.0-SNAPSHOT~70f9058751

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.576 s) : 0, 1576080
Total [baseline] (11.917 s) : 0, 11916995
Agent [candidate] (1.568 s) : 0, 1568249
Total [candidate] (11.911 s) : 0, 11910542
section iast
Agent [baseline] (1.708 s) : 0, 1707630
Total [baseline] (12.543 s) : 0, 12543419
Agent [candidate] (1.703 s) : 0, 1702525
Total [candidate] (12.607 s) : 0, 12607131
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.713 s) : 0, 1713352
Total [baseline] (12.503 s) : 0, 12502843
Agent [candidate] (1.704 s) : 0, 1704343
Total [candidate] (12.493 s) : 0, 12493449
section iast_TELEMETRY_OFF
Agent [baseline] (1.699 s) : 0, 1699308
Total [baseline] (12.555 s) : 0, 12554834
Agent [candidate] (1.711 s) : 0, 1711116
Total [candidate] (12.532 s) : 0, 12531767
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.576 s -
Agent iast 1.708 s 131.55 ms (8.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.713 s 137.272 ms (8.7%)
Agent iast_TELEMETRY_OFF 1.699 s 123.228 ms (7.8%)
Total tracing 11.917 s -
Total iast 12.543 s 626.424 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 12.503 s 585.848 ms (4.9%)
Total iast_TELEMETRY_OFF 12.555 s 637.839 ms (5.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.568 s -
Agent iast 1.703 s 134.276 ms (8.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.704 s 136.094 ms (8.7%)
Agent iast_TELEMETRY_OFF 1.711 s 142.866 ms (9.1%)
Total tracing 11.911 s -
Total iast 12.607 s 696.589 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 12.493 s 582.907 ms (4.9%)
Total iast_TELEMETRY_OFF 12.532 s 621.225 ms (5.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~95d4f51838, baseline=1.35.0-SNAPSHOT~70f9058751

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (970.384 ms) : 0, 970384
BytebuddyAgent [candidate] (966.053 ms) : 0, 966053
GlobalTracer [baseline] (463.141 ms) : 0, 463141
GlobalTracer [candidate] (460.196 ms) : 0, 460196
AppSec [baseline] (71.313 ms) : 0, 71313
AppSec [candidate] (70.777 ms) : 0, 70777
Remote Config [baseline] (828.504 µs) : 0, 829
Remote Config [candidate] (833.419 µs) : 0, 833
Telemetry [baseline] (9.744 ms) : 0, 9744
Telemetry [candidate] (9.802 ms) : 0, 9802
section iast
BytebuddyAgent [baseline] (1.146 s) : 0, 1146013
BytebuddyAgent [candidate] (1.144 s) : 0, 1144093
GlobalTracer [baseline] (430.886 ms) : 0, 430886
GlobalTracer [candidate] (430.154 ms) : 0, 430154
AppSec [baseline] (67.456 ms) : 0, 67456
AppSec [candidate] (66.708 ms) : 0, 66708
IAST [baseline] (33.054 ms) : 0, 33054
IAST [candidate] (31.029 ms) : 0, 31029
Remote Config [baseline] (769.429 µs) : 0, 769
Remote Config [candidate] (786.786 µs) : 0, 787
Telemetry [baseline] (9.766 ms) : 0, 9766
Telemetry [candidate] (10.001 ms) : 0, 10001
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.149 s) : 0, 1148872
BytebuddyAgent [candidate] (1.144 s) : 0, 1144279
GlobalTracer [baseline] (432.372 ms) : 0, 432372
GlobalTracer [candidate] (430.364 ms) : 0, 430364
AppSec [baseline] (67.155 ms) : 0, 67155
AppSec [candidate] (68.312 ms) : 0, 68312
IAST [baseline] (34.382 ms) : 0, 34382
IAST [candidate] (30.706 ms) : 0, 30706
Remote Config [baseline] (772.243 µs) : 0, 772
Remote Config [candidate] (783.936 µs) : 0, 784
Telemetry [baseline] (9.895 ms) : 0, 9895
Telemetry [candidate] (9.921 ms) : 0, 9921
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.139 s) : 0, 1139239
BytebuddyAgent [candidate] (1.148 s) : 0, 1148481
GlobalTracer [baseline] (430.319 ms) : 0, 430319
GlobalTracer [candidate] (433.054 ms) : 0, 433054
AppSec [baseline] (67.518 ms) : 0, 67518
AppSec [candidate] (68.056 ms) : 0, 68056
IAST [baseline] (32.824 ms) : 0, 32824
IAST [candidate] (31.65 ms) : 0, 31650
Remote Config [baseline] (772.041 µs) : 0, 772
Remote Config [candidate] (794.167 µs) : 0, 794
Telemetry [baseline] (8.881 ms) : 0, 8881
Telemetry [candidate] (9.131 ms) : 0, 9131
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-04T08:45:41 2024-06-04T08:54:44
git_branch master jpbempel/metric-local-var-in-scope
git_commit_date 1717485683 1717489580
git_commit_sha 70f9058 95d4f51
release_version 1.35.0-SNAPSHOT~70f9058751 1.35.0-SNAPSHOT~95d4f51838
start_time 2024-06-04T08:45:24 2024-06-04T08:54:28
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717491739 1717491739
ci_job_id 531274542 531274542
ci_pipeline_id 35769932 35769932
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 5 metrics, 22 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling better
[-156.502µs; -84.789µs] or [-7.951%; -4.308%]		 unstable
[-322.079op/s; +473.594op/s] or [-13.286%; +19.536%]		 1.848ms 2500.000op/s 1.968ms 2424.242op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~95d4f51838, baseline=1.35.0-SNAPSHOT~70f9058751
    dateFormat X
    axisFormat %s
section baseline
no_agent (458.028 µs) : 429, 487
.   : milestone, 458,
iast (585.749 µs) : 554, 618
.   : milestone, 586,
iast_FULL (683.481 µs) : 652, 715
.   : milestone, 683,
iast_GLOBAL (618.407 µs) : 586, 650
.   : milestone, 618,
iast_HARDCODED_SECRET_DISABLED (590.377 µs) : 559, 622
.   : milestone, 590,
iast_INACTIVE (552.726 µs) : 522, 584
.   : milestone, 553,
iast_TELEMETRY_OFF (571.485 µs) : 540, 603
.   : milestone, 571,
tracing (532.215 µs) : 502, 562
.   : milestone, 532,
section candidate
no_agent (455.155 µs) : 426, 484
.   : milestone, 455,
iast (580.652 µs) : 549, 613
.   : milestone, 581,
iast_FULL (691.031 µs) : 659, 723
.   : milestone, 691,
iast_GLOBAL (611.702 µs) : 580, 644
.   : milestone, 612,
iast_HARDCODED_SECRET_DISABLED (595.473 µs) : 564, 626
.   : milestone, 595,
iast_INACTIVE (550.747 µs) : 519, 583
.   : milestone, 551,
iast_TELEMETRY_OFF (572.014 µs) : 541, 603
.   : milestone, 572,
tracing (535.878 µs) : 506, 565
.   : milestone, 536,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 458.028 µs [428.735 µs, 487.321 µs] -
iast 585.749 µs [553.738 µs, 617.76 µs] 127.721 µs (27.9%)
iast_FULL 683.481 µs [651.956 µs, 715.006 µs] 225.453 µs (49.2%)
iast_GLOBAL 618.407 µs [586.372 µs, 650.442 µs] 160.379 µs (35.0%)
iast_HARDCODED_SECRET_DISABLED 590.377 µs [558.772 µs, 621.982 µs] 132.348 µs (28.9%)
iast_INACTIVE 552.726 µs [521.602 µs, 583.85 µs] 94.698 µs (20.7%)
iast_TELEMETRY_OFF 571.485 µs [540.091 µs, 602.879 µs] 113.457 µs (24.8%)
tracing 532.215 µs [502.276 µs, 562.153 µs] 74.186 µs (16.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 455.155 µs [426.37 µs, 483.941 µs] -
iast 580.652 µs [548.511 µs, 612.793 µs] 125.497 µs (27.6%)
iast_FULL 691.031 µs [658.896 µs, 723.166 µs] 235.876 µs (51.8%)
iast_GLOBAL 611.702 µs [579.772 µs, 643.633 µs] 156.547 µs (34.4%)
iast_HARDCODED_SECRET_DISABLED 595.473 µs [564.448 µs, 626.498 µs] 140.318 µs (30.8%)
iast_INACTIVE 550.747 µs [518.68 µs, 582.814 µs] 95.592 µs (21.0%)
iast_TELEMETRY_OFF 572.014 µs [541.196 µs, 602.832 µs] 116.859 µs (25.7%)
tracing 535.878 µs [506.279 µs, 565.478 µs] 80.723 µs (17.7%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~95d4f51838, baseline=1.35.0-SNAPSHOT~70f9058751
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.706 ms) : 1681, 1731
.   : milestone, 1706,
appsec (2.179 ms) : 2147, 2211
.   : milestone, 2179,
appsec_no_iast (2.194 ms) : 2161, 2226
.   : milestone, 2194,
iast (1.903 ms) : 1874, 1933
.   : milestone, 1903,
profiling (1.968 ms) : 1932, 2004
.   : milestone, 1968,
tracing (1.884 ms) : 1851, 1916
.   : milestone, 1884,
section candidate
no_agent (1.703 ms) : 1678, 1728
.   : milestone, 1703,
appsec (2.208 ms) : 2176, 2240
.   : milestone, 2208,
appsec_no_iast (2.156 ms) : 2124, 2187
.   : milestone, 2156,
iast (1.906 ms) : 1876, 1935
.   : milestone, 1906,
profiling (1.848 ms) : 1817, 1878
.   : milestone, 1848,
tracing (1.872 ms) : 1840, 1903
.   : milestone, 1872,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.706 ms [1.681 ms, 1.731 ms] -
appsec 2.179 ms [2.147 ms, 2.211 ms] 473.153 µs (27.7%)
appsec_no_iast 2.194 ms [2.161 ms, 2.226 ms] 487.516 µs (28.6%)
iast 1.903 ms [1.874 ms, 1.933 ms] 197.062 µs (11.5%)
profiling 1.968 ms [1.932 ms, 2.004 ms] 262.14 µs (15.4%)
tracing 1.884 ms [1.851 ms, 1.916 ms] 177.478 µs (10.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.703 ms [1.678 ms, 1.728 ms] -
appsec 2.208 ms [2.176 ms, 2.24 ms] 504.708 µs (29.6%)
appsec_no_iast 2.156 ms [2.124 ms, 2.187 ms] 452.695 µs (26.6%)
iast 1.906 ms [1.876 ms, 1.935 ms] 202.705 µs (11.9%)
profiling 1.848 ms [1.817 ms, 1.878 ms] 144.812 µs (8.5%)
tracing 1.872 ms [1.84 ms, 1.903 ms] 168.641 µs (9.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/metric-local-var-in-scope
git_commit_date 1717485683 1717489580
git_commit_sha 70f9058 95d4f51
release_version 1.35.0-SNAPSHOT~70f9058751 1.35.0-SNAPSHOT~95d4f51838
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1717492529 1717492529
ci_job_id 531274544 531274544
ci_pipeline_id 35769932 35769932
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~95d4f51838, baseline=1.35.0-SNAPSHOT~70f9058751
    dateFormat X
    axisFormat %s
section baseline
no_agent (20.383 s) : 20383000, 20383000
.   : milestone, 20383000,
appsec (21.163 s) : 21163000, 21163000
.   : milestone, 21163000,
iast (24.278 s) : 24278000, 24278000
.   : milestone, 24278000,
iast_GLOBAL (25.069 s) : 25069000, 25069000
.   : milestone, 25069000,
profiling (20.748 s) : 20748000, 20748000
.   : milestone, 20748000,
tracing (20.489 s) : 20489000, 20489000
.   : milestone, 20489000,
section candidate
no_agent (20.735 s) : 20735000, 20735000
.   : milestone, 20735000,
appsec (21.583 s) : 21583000, 21583000
.   : milestone, 21583000,
iast (24.327 s) : 24327000, 24327000
.   : milestone, 24327000,
iast_GLOBAL (25.058 s) : 25058000, 25058000
.   : milestone, 25058000,
profiling (20.876 s) : 20876000, 20876000
.   : milestone, 20876000,
tracing (20.877 s) : 20877000, 20877000
.   : milestone, 20877000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 20.383 s [20.383 s, 20.383 s] -
appsec 21.163 s [21.163 s, 21.163 s] 780.0 ms (3.8%)
iast 24.278 s [24.278 s, 24.278 s] 3.895 s (19.1%)
iast_GLOBAL 25.069 s [25.069 s, 25.069 s] 4.686 s (23.0%)
profiling 20.748 s [20.748 s, 20.748 s] 365.0 ms (1.8%)
tracing 20.489 s [20.489 s, 20.489 s] 106.0 ms (0.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 20.735 s [20.735 s, 20.735 s] -
appsec 21.583 s [21.583 s, 21.583 s] 848.0 ms (4.1%)
iast 24.327 s [24.327 s, 24.327 s] 3.592 s (17.3%)
iast_GLOBAL 25.058 s [25.058 s, 25.058 s] 4.323 s (20.8%)
profiling 20.876 s [20.876 s, 20.876 s] 141.0 ms (0.7%)
tracing 20.877 s [20.877 s, 20.877 s] 142.0 ms (0.7%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~95d4f51838, baseline=1.35.0-SNAPSHOT~70f9058751
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.543 ms) : 1531, 1556
.   : milestone, 1543,
appsec (2.674 ms) : 2614, 2735
.   : milestone, 2674,
iast (2.337 ms) : 2266, 2407
.   : milestone, 2337,
iast_GLOBAL (2.406 ms) : 2334, 2479
.   : milestone, 2406,
profiling (2.205 ms) : 2143, 2266
.   : milestone, 2205,
tracing (2.168 ms) : 2110, 2226
.   : milestone, 2168,
section candidate
no_agent (1.546 ms) : 1533, 1559
.   : milestone, 1546,
appsec (2.671 ms) : 2611, 2730
.   : milestone, 2671,
iast (2.352 ms) : 2280, 2424
.   : milestone, 2352,
iast_GLOBAL (2.384 ms) : 2314, 2454
.   : milestone, 2384,
profiling (2.191 ms) : 2130, 2251
.   : milestone, 2191,
tracing (2.162 ms) : 2106, 2219
.   : milestone, 2162,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.543 ms [1.531 ms, 1.556 ms] -
appsec 2.674 ms [2.614 ms, 2.735 ms] 1.131 ms (73.3%)
iast 2.337 ms [2.266 ms, 2.407 ms] 793.197 µs (51.4%)
iast_GLOBAL 2.406 ms [2.334 ms, 2.479 ms] 863.045 µs (55.9%)
profiling 2.205 ms [2.143 ms, 2.266 ms] 661.167 µs (42.8%)
tracing 2.168 ms [2.11 ms, 2.226 ms] 624.623 µs (40.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.546 ms [1.533 ms, 1.559 ms] -
appsec 2.671 ms [2.611 ms, 2.73 ms] 1.124 ms (72.7%)
iast 2.352 ms [2.28 ms, 2.424 ms] 806.044 µs (52.1%)
iast_GLOBAL 2.384 ms [2.314 ms, 2.454 ms] 838.145 µs (54.2%)
profiling 2.191 ms [2.13 ms, 2.251 ms] 644.467 µs (41.7%)
tracing 2.162 ms [2.106 ms, 2.219 ms] 616.336 µs (39.9%)

@jpbempel jpbempel merged commit 9f6d75c into master Jun 4, 2024
83 checks passed
@jpbempel jpbempel deleted the jpbempel/metric-local-var-in-scope branch June 4, 2024 18:30
@github-actions github-actions bot added this to the 1.35.0 milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatzi shatzi shatzi approved these changes

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation type: bug
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jpbempel @shatzi