Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure locals are in scope when generating metrics #7121

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Ensure locals are in scope when generating metrics #7121

merged 1 commit into from
Jun 4, 2024

Commits on Jun 4, 2024

  1. Ensure locals are in scope when generating metrics 

    Verify that where the metric is inserted, the local variable that we
 try to access is in scope (from the LocalVariableTable)
We are doing this for CapturedContext now we add this for metrics
to avoid having a VerifyError raised because the variable is not
accessible or reused with another type than expected.
    @jpbempel
    jpbempel committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    95d4f51 View commit details
    Browse the repository at this point in the history