-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logs to tainted map 'garbage-collected entries are purged' flaky test #7240
Merged
manuel-alvarez-alvarez
merged 2 commits into
master
from
malvarez/iast-tainted-map-test-flaky
Jun 27, 2024
Merged
Add logs to tainted map 'garbage-collected entries are purged' flaky test #7240
manuel-alvarez-alvarez
merged 2 commits into
master
from
malvarez/iast-tainted-map-test-flaky
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuel-alvarez-alvarez
added
tag: flaky test
Flaky tests
comp: asm iast
Application Security Management (IAST)
labels
Jun 25, 2024
manuel-alvarez-alvarez
force-pushed
the
malvarez/iast-tainted-map-test-flaky
branch
from
June 25, 2024 16:00
59a9244
to
ad96bf3
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~8ccc7f3ed7, baseline=1.36.0-SNAPSHOT~04cda746be
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1075126
Total [baseline] (10.414 s) : 0, 10414300
Agent [candidate] (1.061 s) : 0, 1060655
Total [candidate] (10.291 s) : 0, 10290849
section appsec
Agent [baseline] (1.189 s) : 0, 1188755
Total [baseline] (10.488 s) : 0, 10488273
Agent [candidate] (1.188 s) : 0, 1188262
Total [candidate] (10.462 s) : 0, 10462074
section iast
Agent [baseline] (1.17 s) : 0, 1169520
Total [baseline] (10.723 s) : 0, 10722922
Agent [candidate] (1.172 s) : 0, 1171537
Total [candidate] (10.659 s) : 0, 10658787
section profiling
Agent [baseline] (1.271 s) : 0, 1270984
Total [baseline] (10.642 s) : 0, 10642153
Agent [candidate] (1.265 s) : 0, 1264659
Total [candidate] (10.608 s) : 0, 10607546
gantt
title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~8ccc7f3ed7, baseline=1.36.0-SNAPSHOT~04cda746be
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.043 ms) : 0, 674043
BytebuddyAgent [candidate] (665.02 ms) : 0, 665020
GlobalTracer [baseline] (307.117 ms) : 0, 307117
GlobalTracer [candidate] (303.006 ms) : 0, 303006
AppSec [baseline] (50.653 ms) : 0, 50653
AppSec [candidate] (50.157 ms) : 0, 50157
Remote Config [baseline] (708.003 µs) : 0, 708
Remote Config [candidate] (678.915 µs) : 0, 679
Telemetry [baseline] (7.69 ms) : 0, 7690
Telemetry [candidate] (7.508 ms) : 0, 7508
section appsec
BytebuddyAgent [baseline] (680.634 ms) : 0, 680634
BytebuddyAgent [candidate] (680.333 ms) : 0, 680333
GlobalTracer [baseline] (299.157 ms) : 0, 299157
GlobalTracer [candidate] (299.014 ms) : 0, 299014
AppSec [baseline] (154.869 ms) : 0, 154869
AppSec [candidate] (154.477 ms) : 0, 154477
Remote Config [baseline] (648.638 µs) : 0, 649
Remote Config [candidate] (643.754 µs) : 0, 644
Telemetry [baseline] (8.484 ms) : 0, 8484
Telemetry [candidate] (8.151 ms) : 0, 8151
IAST [baseline] (20.478 ms) : 0, 20478
IAST [candidate] (21.912 ms) : 0, 21912
section iast
BytebuddyAgent [baseline] (778.879 ms) : 0, 778879
BytebuddyAgent [candidate] (781.679 ms) : 0, 781679
GlobalTracer [baseline] (293.629 ms) : 0, 293629
GlobalTracer [candidate] (294.071 ms) : 0, 294071
AppSec [baseline] (47.043 ms) : 0, 47043
AppSec [candidate] (47.303 ms) : 0, 47303
Remote Config [baseline] (624.254 µs) : 0, 624
Remote Config [candidate] (605.898 µs) : 0, 606
Telemetry [baseline] (6.88 ms) : 0, 6880
Telemetry [candidate] (6.969 ms) : 0, 6969
IAST [baseline] (29.201 ms) : 0, 29201
IAST [candidate] (27.561 ms) : 0, 27561
section profiling
ProfilingAgent [baseline] (96.808 ms) : 0, 96808
ProfilingAgent [candidate] (96.533 ms) : 0, 96533
BytebuddyAgent [baseline] (667.994 ms) : 0, 667994
BytebuddyAgent [candidate] (663.86 ms) : 0, 663860
GlobalTracer [baseline] (389.336 ms) : 0, 389336
GlobalTracer [candidate] (387.176 ms) : 0, 387176
AppSec [baseline] (51.26 ms) : 0, 51260
AppSec [candidate] (51.782 ms) : 0, 51782
Remote Config [baseline] (756.713 µs) : 0, 757
Remote Config [candidate] (742.203 µs) : 0, 742
Telemetry [baseline] (7.434 ms) : 0, 7434
Telemetry [candidate] (7.381 ms) : 0, 7381
Profiling [baseline] (96.833 ms) : 0, 96833
Profiling [candidate] (96.557 ms) : 0, 96557
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~8ccc7f3ed7, baseline=1.36.0-SNAPSHOT~04cda746be
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061280
Total [baseline] (8.532 s) : 0, 8532340
Agent [candidate] (1.06 s) : 0, 1060400
Total [candidate] (8.552 s) : 0, 8552409
section iast
Agent [baseline] (1.194 s) : 0, 1193917
Total [baseline] (9.059 s) : 0, 9058548
Agent [candidate] (1.171 s) : 0, 1170635
Total [candidate] (9.005 s) : 0, 9005439
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.169 s) : 0, 1169139
Total [baseline] (8.995 s) : 0, 8994903
Agent [candidate] (1.17 s) : 0, 1169601
Total [candidate] (8.971 s) : 0, 8971215
section iast_TELEMETRY_OFF
Agent [baseline] (1.167 s) : 0, 1166875
Total [baseline] (8.981 s) : 0, 8981409
Agent [candidate] (1.167 s) : 0, 1167282
Total [candidate] (9.035 s) : 0, 9034735
gantt
title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~8ccc7f3ed7, baseline=1.36.0-SNAPSHOT~04cda746be
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.86 ms) : 0, 664860
BytebuddyAgent [candidate] (664.609 ms) : 0, 664609
GlobalTracer [baseline] (303.619 ms) : 0, 303619
GlobalTracer [candidate] (303.223 ms) : 0, 303223
AppSec [baseline] (50.186 ms) : 0, 50186
AppSec [candidate] (50.02 ms) : 0, 50020
Remote Config [baseline] (684.708 µs) : 0, 685
Remote Config [candidate] (689.899 µs) : 0, 690
Telemetry [baseline] (7.564 ms) : 0, 7564
Telemetry [candidate] (7.542 ms) : 0, 7542
section iast
BytebuddyAgent [baseline] (796.571 ms) : 0, 796571
BytebuddyAgent [candidate] (780.051 ms) : 0, 780051
GlobalTracer [baseline] (298.777 ms) : 0, 298777
GlobalTracer [candidate] (294.071 ms) : 0, 294071
AppSec [baseline] (48.005 ms) : 0, 48005
AppSec [candidate] (47.048 ms) : 0, 47048
IAST [baseline] (28.594 ms) : 0, 28594
IAST [candidate] (28.766 ms) : 0, 28766
Remote Config [baseline] (629.793 µs) : 0, 630
Remote Config [candidate] (609.705 µs) : 0, 610
Telemetry [baseline] (7.81 ms) : 0, 7810
Telemetry [candidate] (6.807 ms) : 0, 6807
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (780.101 ms) : 0, 780101
BytebuddyAgent [candidate] (779.848 ms) : 0, 779848
GlobalTracer [baseline] (293.854 ms) : 0, 293854
GlobalTracer [candidate] (293.333 ms) : 0, 293333
AppSec [baseline] (47.341 ms) : 0, 47341
AppSec [candidate] (47.186 ms) : 0, 47186
IAST [baseline] (26.908 ms) : 0, 26908
IAST [candidate] (27.528 ms) : 0, 27528
Remote Config [baseline] (634.188 µs) : 0, 634
Remote Config [candidate] (651.738 µs) : 0, 652
Telemetry [baseline] (6.979 ms) : 0, 6979
Telemetry [candidate] (7.708 ms) : 0, 7708
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (777.28 ms) : 0, 777280
BytebuddyAgent [candidate] (777.925 ms) : 0, 777925
GlobalTracer [baseline] (293.779 ms) : 0, 293779
GlobalTracer [candidate] (293.529 ms) : 0, 293529
AppSec [baseline] (47.059 ms) : 0, 47059
AppSec [candidate] (47.177 ms) : 0, 47177
IAST [baseline] (27.167 ms) : 0, 27167
IAST [candidate] (26.38 ms) : 0, 26380
Remote Config [baseline] (607.836 µs) : 0, 608
Remote Config [candidate] (596.241 µs) : 0, 596
Telemetry [baseline] (7.676 ms) : 0, 7676
Telemetry [candidate] (8.306 ms) : 0, 8306
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~8ccc7f3ed7, baseline=1.36.0-SNAPSHOT~04cda746be
dateFormat X
axisFormat %s
section baseline
no_agent (370.191 µs) : 350, 390
. : milestone, 370,
iast (489.266 µs) : 468, 511
. : milestone, 489,
iast_FULL (558.968 µs) : 538, 580
. : milestone, 559,
iast_GLOBAL (519.445 µs) : 497, 542
. : milestone, 519,
iast_HARDCODED_SECRET_DISABLED (485.657 µs) : 464, 507
. : milestone, 486,
iast_INACTIVE (455.329 µs) : 434, 476
. : milestone, 455,
iast_TELEMETRY_OFF (475.497 µs) : 454, 497
. : milestone, 475,
tracing (443.966 µs) : 424, 464
. : milestone, 444,
section candidate
no_agent (374.165 µs) : 355, 394
. : milestone, 374,
iast (492.854 µs) : 471, 515
. : milestone, 493,
iast_FULL (556.159 µs) : 535, 577
. : milestone, 556,
iast_GLOBAL (511.739 µs) : 491, 533
. : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (489.11 µs) : 468, 511
. : milestone, 489,
iast_INACTIVE (455.444 µs) : 435, 476
. : milestone, 455,
iast_TELEMETRY_OFF (477.253 µs) : 456, 499
. : milestone, 477,
tracing (448.811 µs) : 428, 470
. : milestone, 449,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~8ccc7f3ed7, baseline=1.36.0-SNAPSHOT~04cda746be
dateFormat X
axisFormat %s
section baseline
no_agent (1.346 ms) : 1326, 1367
. : milestone, 1346,
appsec (1.729 ms) : 1705, 1754
. : milestone, 1729,
appsec_no_iast (1.723 ms) : 1698, 1748
. : milestone, 1723,
iast (1.51 ms) : 1488, 1533
. : milestone, 1510,
profiling (1.553 ms) : 1528, 1579
. : milestone, 1553,
tracing (1.465 ms) : 1441, 1490
. : milestone, 1465,
section candidate
no_agent (1.363 ms) : 1342, 1383
. : milestone, 1363,
appsec (1.729 ms) : 1706, 1753
. : milestone, 1729,
appsec_no_iast (1.742 ms) : 1718, 1766
. : milestone, 1742,
iast (1.51 ms) : 1487, 1533
. : milestone, 1510,
profiling (1.499 ms) : 1474, 1524
. : milestone, 1499,
tracing (1.458 ms) : 1433, 1483
. : milestone, 1458,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~8ccc7f3ed7, baseline=1.36.0-SNAPSHOT~04cda746be
dateFormat X
axisFormat %s
section baseline
no_agent (1.459 ms) : 1447, 1470
. : milestone, 1459,
appsec (2.2 ms) : 2166, 2233
. : milestone, 2200,
iast (1.964 ms) : 1924, 2005
. : milestone, 1964,
iast_GLOBAL (2.011 ms) : 1969, 2053
. : milestone, 2011,
profiling (1.842 ms) : 1808, 1877
. : milestone, 1842,
tracing (1.827 ms) : 1795, 1859
. : milestone, 1827,
section candidate
no_agent (1.459 ms) : 1448, 1471
. : milestone, 1459,
appsec (2.213 ms) : 2178, 2247
. : milestone, 2213,
iast (1.968 ms) : 1927, 2010
. : milestone, 1968,
iast_GLOBAL (1.998 ms) : 1957, 2038
. : milestone, 1998,
profiling (1.85 ms) : 1816, 1883
. : milestone, 1850,
tracing (1.826 ms) : 1794, 1858
. : milestone, 1826,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~8ccc7f3ed7, baseline=1.36.0-SNAPSHOT~04cda746be
dateFormat X
axisFormat %s
section baseline
no_agent (15.55 s) : 15550000, 15550000
. : milestone, 15550000,
appsec (14.976 s) : 14976000, 14976000
. : milestone, 14976000,
iast (18.98 s) : 18980000, 18980000
. : milestone, 18980000,
iast_GLOBAL (17.894 s) : 17894000, 17894000
. : milestone, 17894000,
profiling (15.594 s) : 15594000, 15594000
. : milestone, 15594000,
tracing (14.807 s) : 14807000, 14807000
. : milestone, 14807000,
section candidate
no_agent (15.019 s) : 15019000, 15019000
. : milestone, 15019000,
appsec (14.96 s) : 14960000, 14960000
. : milestone, 14960000,
iast (18.99 s) : 18990000, 18990000
. : milestone, 18990000,
iast_GLOBAL (17.813 s) : 17813000, 17813000
. : milestone, 17813000,
profiling (14.795 s) : 14795000, 14795000
. : milestone, 14795000,
tracing (15.048 s) : 15048000, 15048000
. : milestone, 15048000,
|
PerfectSlayer
approved these changes
Jun 26, 2024
PerfectSlayer
added
the
tag: no release notes
Changes to exclude from release notes
label
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: asm iast
Application Security Management (IAST)
tag: flaky test
Flaky tests
tag: no release notes
Changes to exclude from release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Add logs to the tainted map
garbage-collected entries are purged
test in order to understand why it might flake under JDK 21.Motivation
The test has been observed to fail with no reason in some builds: example
Additional Notes
Jira ticket: [PROJ-IDENT]