-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ruby platform check for sorbet dependency #2445
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2445 +/- ##
==========================================
- Coverage 98.34% 98.33% -0.01%
==========================================
Files 1101 1101
Lines 58977 58974 -3
==========================================
- Hits 58001 57993 -8
- Misses 976 981 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Waiting on sorbet/sorbet#4119 to be addressed. There's already a PR up for it, currently under review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting on sorbet/sorbet#4119 to be addressed. There's already a PR up for it, currently under review.
Note that upstream seems very slow on this issue, so I don't think we can expect a fix anytime soon 😰
# Also, there's no support for windows | ||
if RUBY_VERSION >= '2.4.0' && (RUBY_PLATFORM =~ /^x86_64-(darwin|linux)/) | ||
# Also, there's no support for windows, but M1 Mac with `arm64-darwin21` architecture is doing fine | ||
if RUBY_VERSION >= '2.4.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that there's two changes being made here: enabling it on arm64 for macOS and for Linux. Afaik it doesn't work for Linux /yet/, so I think we should leave that part of the check for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important note: the locks that needs to be commited to work under aarch64-linux MUST NOT have sorbet, as this prevents Ideally the appraisal lockfiles shoud all have As I said to @marcotc the other day, conditionals in I have a tentative change locally to address the |
It's been working on a fork for something like a year. It's clearly just not their priority. |
👍 thanks for the reminder. To be honest we don't need sorbet for the appraisal steps, so even without #2421 I think we could fix this by for instance tweaking the condition so that it doesn't trigger when the But #2421 does seem to be a less hacky way of doing it, so that's probably the way to go. |
What does this PR do?
With the ruby platform check, the appraisal lockfile would always end up with difference. However, currently we are using a compatible version that could be installed on
x86
orarm64-darwin21
from M1 Mac. So we could remove this conditionalHow to test this
With M1 Mac,
bundle install && bundle exec rake typecheck