-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event kit API #2512
Merged
Merged
Add event kit API #2512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d7ecfcc
to
e4eb66a
Compare
Codecov Report
@@ Coverage Diff @@
## master #2512 +/- ##
==========================================
- Coverage 98.32% 98.32% -0.01%
==========================================
Files 1124 1126 +2
Lines 60660 60725 +65
==========================================
+ Hits 59644 59707 +63
- Misses 1016 1018 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
marcotc
reviewed
Jan 3, 2023
marcotc
reviewed
Jan 3, 2023
marcotc
reviewed
Jan 3, 2023
marcotc
approved these changes
Jan 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implement event sugar API for users to emit either login events or custom business events to be tracked.
Motivation
These events are a key feature that Sqreen had and enabled higher level analysis and partially to fully automated security response.
Additional Notes
Just as with
Datadog::Kit::Identity#set_user
this looks like convenience syntactic sugar. Nonetheless, just as withset_user
, wrapping the tag keys allows for these keys to evolve, or even the transport mechanism to change.In addition, blocking may be handled and triggered, which is probably a feature we don't want in
set_tag
!How to test the change?
There are a bunch of specs added.