DOCS-3666 Fix docker-compose integration installation doc #14384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
FAQ
buraizu
changed the title
|
Thanks, created DOCS-3666 to track this update! |
When installing the agent on my personal host, using docker-compose, I used the provided snippet, but it was not working. This PR add `privileged: true` to allow collection of other containers data. In the [Docker agent installation doc](https://docs.datadoghq.com/agent/docker/?tab=standard) it states that agent should be run with `--cgroupns host`, which is `privileged: true` in compose. I wanted to change `build: datadog` which is supposed to be used to build a local container to `image: datadog/agent` which pulls the image from docker repository, but did not. I'm balanced between the "it works out of the box" approach (`image: datadog/agent`) and the "in the real world you will customise it anyway" one (`image:` + `Dockerfile`).
hestonhoffman
force-pushed
the
themouette-patch-1
branch
from
5b425b6
to
ecaeeb0
Compare
github-actions
bot
added
agent
|
We don't expect our users to have to customize the About the |
hestonhoffman
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When installing the agent on my personal host, using docker-compose, I used the provided snippet, but it was not working.
This PR add
privileged: trueto allow collection of other containers data.In the Docker agent installation doc it states that agent should be run with
--cgroupns host, which isprivileged: truein compose.I wanted to change
build: datadogwhich is supposed to be used to build a local container toimage: datadog/agentwhich pulls the image from docker repository, but did not.I'm balanced between the "it works out of the box" approach (
image: datadog/agent) and the "in the real world you will customise it anyway" one (image:+Dockerfile).Motivation
Additional Notes
Reviewer checklist