Simplify OFFSET_INVALID condition (#15237)

DataDog · Jul 19, 2023 · 3d66292 · 3d66292
1 parent 2d00a08
commit 3d66292
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/kafka_consumer/datadog_checks/kafka_consumer/client.py b/kafka_consumer/datadog_checks/kafka_consumer/client.py
@@ -154,14 +154,16 @@ def get_consumer_offsets(self):
                             str(topic_partition.partition),
                         )
                         continue
+
+                    if offset == OFFSET_INVALID:
+                        continue
+
                     if self.config._monitor_unlisted_consumer_groups or not self.config._consumer_groups_compiled_regex:
-                        if offset != OFFSET_INVALID:
-                            consumer_offsets[(consumer_group, topic, partition)] = offset
+                        consumer_offsets[(consumer_group, topic, partition)] = offset
                     else:
                         to_match = f"{consumer_group},{topic},{partition}"
                         if self.config._consumer_groups_compiled_regex.match(to_match):
-                            if offset != OFFSET_INVALID:
-                                consumer_offsets[(consumer_group, topic, partition)] = offset
+                            consumer_offsets[(consumer_group, topic, partition)] = offset
 
         return consumer_offsets
 
@@ -206,7 +208,6 @@ def _get_consumer_offset_futures(self, consumer_groups):
                 continue
 
             for topic in topics:
-                topic_partitions = []
                 # If partitions are defined
                 if partitions := topics[topic]:
                     topic_partitions = [TopicPartition(topic, partition) for partition in partitions]