Add new service check oracle.can_query
#10004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
fanny-jiang
previously approved these changes
Aug 27, 2021
ofek
requested changes
Aug 30, 2021
ofek
requested changes
Aug 30, 2021
Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
yzhan289
commented
Sep 1, 2021
| aggregator.assert_service_check("oracle.can_query", check.CRITICAL, count=1, tags=expected_tags) | ||
|
|
||
|
|
||
| def test__get_connection_instant_client_server_incorrect_formatting(instance, dd_run_check, aggregator): |
There was a problem hiding this comment.
@sarah-witt This is the same test that you added in #9971, just renamed and using aggregator to assert service check.
ofek
previously approved these changes
Sep 1, 2021
ofek
approved these changes
Sep 1, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Sep 1, 2021
* Rename tests for oracle * Add new service check logic * Add new unit tests for service check changes * Add new service check can_query * Fix old unit test * Modify e2e tests * Fix style * Add service check to json * Fix name * Apply suggestions from code review Co-authored-by: Ofek Lev <ofekmeister@gmail.com> * Reformat newly added test * Reformat tests * Add host for service check: Co-authored-by: Ofek Lev <ofekmeister@gmail.com> 9f83705
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR does two things:
oracle.can_querytest_oracleandtest_metricsintotest_unitThe original
oracle.can_connectservice check emittedOKif the integration can connect to the database and if all of the queries can be run.This PR adds a new service check
oracle.can_queryto split up the original service check. Now,oracle.can_connectchecks if the integration can connect to the oracle database, andoracle.can_querychecks if all of the queries can be run.Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached