Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add disable generic tags options to apache #10277

Merged
merged 6 commits into from
Oct 1, 2021

Conversation

HantingZhang2
Copy link
Contributor

What does this PR do?

add disable generic tags options to the apache integration

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@HantingZhang2 HantingZhang2 requested review from a team as code owners September 29, 2021 16:21
@HantingZhang2 HantingZhang2 changed the title add disable generic tags options add disable generic tags options to apache Sep 29, 2021
Copy link
Contributor

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no docs team review needed

@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #10277 (805a846) into master (cefca34) will increase coverage by 0.02%.
The diff coverage is 84.61%.

Flag Coverage Δ
apache 95.08% <84.61%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

else:
service_check_tags = [
'host:%s' % apache_host,
'apache_host:%s' % apache_host,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'apache_host:%s' % apache_host,

apache/datadog_checks/apache/apache.py Show resolved Hide resolved
@coignetp coignetp merged commit e83b91b into master Oct 1, 2021
@coignetp coignetp deleted the hz-apache-disable-generic-tags branch October 1, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants