[nginx] allow proxy disabling #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivielpeau
requested changes
Jan 25, 2018
nginx/conf.yaml.example
Outdated
| # The (optional) skip_proxy parameter will bypass any proxy | ||
| # settings enabled and attempt to reach the URL directly. | ||
| # | ||
| # skip_proxy: false |
There was a problem hiding this comment.
Shouldn't this be no_proxy instead? (based on this: https://github.com/DataDog/dd-agent/blob/5.21.0/checks/__init__.py#L396)
ofek
force-pushed
the
ofek/nginx-skip-proxy
branch
from
ef75bf3
to
dd30f3b
Compare
derekwbrown
approved these changes
Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This allows users of the nginx check to bypass proxy settings. It is particularly useful for auto discovery with Docker.
Motivation
Customer request
Versioning
manifest.jsondatadog_checks/{integration}/__init__.pyCHANGELOG.md. Please useUnreleasedas the date in the titlefor the new section.