Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New dashboard for NGINX #10540

Merged
merged 6 commits into from
Dec 6, 2021
Merged

New dashboard for NGINX #10540

merged 6 commits into from
Dec 6, 2021

Conversation

yzhan289
Copy link
Contributor

@yzhan289 yzhan289 commented Nov 2, 2021

What does this PR do?

Updated dashboard for NGINX (See #10522)

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@yzhan289 yzhan289 requested a review from a team as a code owner November 2, 2021 18:55
@yzhan289 yzhan289 requested a review from a team as a code owner November 3, 2021 13:51
@ghost ghost added the documentation label Nov 3, 2021
alai97
alai97 previously approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@alai97 alai97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for docs!

@github-actions
Copy link

github-actions bot commented Nov 4, 2021

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

DrkSephy
DrkSephy reviewed Nov 4, 2021
View reviewed changes
Copy link
Contributor

@DrkSephy DrkSephy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should introduce a new dashboard file here and instead we should look into replacing the contents of an existing dashboard.

nginx/manifest.json Outdated Show resolved Hide resolved
sarah-witt
sarah-witt requested changes Nov 10, 2021
View reviewed changes
nginx/assets/dashboards/NGINX-Overview_dashboard.json Outdated Show resolved Hide resolved
nginx/assets/dashboards/NGINX-Overview_dashboard.json Outdated Show resolved Hide resolved
nginx/assets/dashboards/NGINX-Overview_dashboard.json Outdated Show resolved Hide resolved
nginx/assets/dashboards/NGINX-Overview_dashboard.json Outdated Show resolved Hide resolved
nginx/assets/dashboards/NGINX-Overview_dashboard.json Outdated Show resolved Hide resolved
nginx/assets/dashboards/NGINX-Overview_dashboard.json Outdated Show resolved Hide resolved
nginx/assets/dashboards/NGINX-Overview_dashboard.json Outdated Show resolved Hide resolved
yzhan289 and others added 2 commits November 10, 2021 10:11
@yzhan289 @sarah-witt
Update nginx/assets/dashboards/NGINX-Overview_dashboard.json
186ed26 
Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>
@yzhan289 @sarah-witt
Apply suggestions from code review
43c1a9a 
Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@codecov
Copy link

codecov bot commented Nov 10, 2021 •
edited
Loading

Codecov Report

Merging #10540 (030cf52) into master (fe47b8e) will increase coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
sqlserver 84.66% <ø> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@yzhan289 yzhan289 merged commit a289271 into master Dec 6, 2021
@yzhan289 yzhan289 deleted the az/nginx-dash branch December 6, 2021 17:54
cswatt pushed a commit that referenced this pull request Jan 5, 2022
@yzhan289 @sarah-witt @cswatt
Add new dashboard for NGINX (#10540)
dfa8434 
* Update NGINX dashboard

* Update nginx/assets/dashboards/NGINX-Overview_dashboard.json

Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>

* Apply suggestions from code review

Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>

* Add id from original dashboard

* Update id from original dashboard

* Change ID to 21

Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrkSephy DrkSephy DrkSephy left review comments

@sarah-witt sarah-witt sarah-witt approved these changes

@alai97 alai97 alai97 left review comments

Assignees
No one assigned
Labels
changelog/no-changelog documentation integration/nginx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yzhan289 @DrkSephy @sarah-witt @alai97