Fix failed reading and writing to cache when file is too long #12109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
piochelepiotr
added
category/bugfix
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
hithwen
reviewed
May 31, 2022
kafka_consumer/datadog_checks/kafka_consumer/new_kafka_consumer.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Julia <611228+hithwen@users.noreply.github.com>
hithwen
approved these changes
May 31, 2022
sarah-witt
pushed a commit
that referenced
this pull request
May 31, 2022
#12109) * kafka_consumer: failed reading and writing to cache when file is too long * kafka_consumer: Fixed cache key. Co-authored-by: Julia <611228+hithwen@users.noreply.github.com> * kafka_consumer: use constant for broker timestamp cache key Co-authored-by: Julia <611228+hithwen@users.noreply.github.com>
yzhan289
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…long
What does this PR do?
Bug introduced by #11861
The issue is that the value in the cache can't be set / read when we have too many tags.
And
self.instance.get('tags', [])doesn't return onlycustom_tagsas I thought, but all the host tags. (Where is that logic?)Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached