Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MySQL] Added Agent settings to log original unobfuscated strings #12941

Merged
merged 2 commits into from
Sep 29, 2022
Merged

[MySQL] Added Agent settings to log original unobfuscated strings #12941

merged 2 commits into from
Sep 29, 2022

Conversation

BennyW23
Copy link
Contributor

What does this PR do?

Adds two hidden options log_unobfuscated_queries and log_unobfuscated_plans which will log the original unobfuscated SQL queries and plans respectively if an obfuscation error occurs. These options will simplify the debugging process when dealing with obfuscation errors.

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@BennyW23 BennyW23 marked this pull request as ready for review September 15, 2022 19:30
@BennyW23 BennyW23 requested review from a team as code owners September 15, 2022 19:30
@codecov
Copy link

codecov bot commented Sep 15, 2022 •
edited
Loading

Codecov Report

Merging #12941 (9b7423e) into master (acf16e1) will increase coverage by 0.00%.
The diff coverage is 29.41%.

Flag Coverage Δ
mysql 87.98% <29.41%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@BennyW23 BennyW23 merged commit 61e6c70 into master Sep 29, 2022
@BennyW23 BennyW23 deleted the bennywong/mysql-log-unobfuscated-sql-settings branch September 29, 2022 19:16
steveny91 pushed a commit that referenced this pull request Oct 27, 2022
@BennyW23 @steveny91
[MySQL] Added Agent settings to log original unobfuscated strings (#1…
5b2f80b 
…2941)

* [MySQL] Added Agent settings to log original unobfuscated strings

* Adjusted obfuscation error logging to be more consistent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbarksdale alexbarksdale alexbarksdale left review comments

@alexandre-normand alexandre-normand alexandre-normand approved these changes

Assignees
No one assigned
Labels
documentation integration/mysql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BennyW23 @alexandre-normand @alexbarksdale