Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the base check dependency #13641

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Jan 6, 2023

What does this PR do?

Bump the base check dependency

Motivation

Additional Notes

  • Run ddev test --force-base-min --force-env-rebuild --junit snowflake to reproduce

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@ghost ghost added the integration/snowflake label Jan 6, 2023
@FlorentClarret FlorentClarret marked this pull request as ready for review January 6, 2023 10:46
@FlorentClarret FlorentClarret requested a review from a team as a code owner January 6, 2023 10:46
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #13641 (de1d4b6) into master (c0daa8e) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
snowflake 96.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@FlorentClarret FlorentClarret merged commit 59ae9c2 into master Jan 9, 2023
@FlorentClarret FlorentClarret deleted the florentclarret/snowflake/base-check-version branch January 9, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants