Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not check consumer_groups if the offset is invalid #15237

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Do not check consumer_groups if the offset is invalid #15237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions kafka_consumer/datadog_checks/kafka_consumer/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,14 +154,16 @@ def get_consumer_offsets(self):
str(topic_partition.partition),
)
continue

if offset == OFFSET_INVALID:
continue

if self.config._monitor_unlisted_consumer_groups or not self.config._consumer_groups_compiled_regex:
if offset != OFFSET_INVALID:
consumer_offsets[(consumer_group, topic, partition)] = offset
consumer_offsets[(consumer_group, topic, partition)] = offset
else:
to_match = f"{consumer_group},{topic},{partition}"
if self.config._consumer_groups_compiled_regex.match(to_match):
if offset != OFFSET_INVALID:
consumer_offsets[(consumer_group, topic, partition)] = offset
consumer_offsets[(consumer_group, topic, partition)] = offset

return consumer_offsets

Expand Down Expand Up @@ -206,7 +208,6 @@ def _get_consumer_offset_futures(self, consumer_groups):
continue

for topic in topics:
topic_partitions = []
# If partitions are defined
if partitions := topics[topic]:
topic_partitions = [TopicPartition(topic, partition) for partition in partitions]
Expand Down
Loading