Filter out empty consumer groups #15657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
yzhan289
changed the title
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
steveny91
previously approved these changes
Aug 28, 2023
Co-authored-by: Florent Clarret <florent.clarret@datadoghq.com>
FlorentClarret
approved these changes
Aug 29, 2023
3 tasks
vivek-datadog
pushed a commit
that referenced
this pull request
Sep 5, 2023
* Add debug log for discovered CG and filter out empty * Fix formatting * Add unit test * Add Changelog entry * Apply suggestions from code review Co-authored-by: Florent Clarret <florent.clarret@datadoghq.com> --------- Co-authored-by: Florent Clarret <florent.clarret@datadoghq.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR filters out consumer groups that are
"".Motivation
These consumer groups should not be considered valid, as we are unable to fetch offsets for consumer groups with names
"".https://datadoghq.atlassian.net/browse/AGENT-10106
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.