-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Confluent Platform Intergration - Correct Mbean regex stream thread metric #17490
Changes from 6 commits
5f318c3
e0bafc0
0a2c164
8aee7a4
d07f286
03db929
4bc637c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
|
||
Fix correct Mbean regex stream thread metric(after version 5.5.0 of confluent platform). Previously, because Bean Regex was set to Client metrics, Stream Thread Metrics were not collected. also added one useful attribute for debugging Stream Thread performance. | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1600,7 +1600,107 @@ jmx_metrics: | |
|
||
|
||
# Components Metrics: | ||
# - Confluent Streams Thread: https://docs.confluent.io/current/streams/monitoring.html#built-in-metrics | ||
# - Confluent Streams Thread: https://docs.confluent.io/current/streams/monitoring.html#thread-metrics | ||
- include: | ||
domain: kafka.streams | ||
bean_regex: kafka\.streams:type=stream-thread-metrics,thread-id=.* | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we add this entry as new one for this bean regex instead of overwriting the current one? If we overwrite this, it might break some backwards compatibility with at least version 5 of confluent platform: Moving this to a new entry will ensure both legacy and new versions to submit this metric. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @steveny91 Thank you your advice. |
||
attribute: | ||
blocked-time-ns-total: | ||
# The total time the Kafka Streams thread spent blocked on Kafka since it was started, in nanoseconds (ns). | ||
alias: confluent.$domain.stream.$attribute | ||
metric_type: gauge | ||
commit-latency-avg: | ||
# The average value of commit-latency. | ||
alias: confluent.$domain.stream.$attribute | ||
metric_type: gauge | ||
commit-latency-max: | ||
# The maximum value of commit-latency. | ||
alias: confluent.$domain.stream.$attribute | ||
metric_type: gauge | ||
commit-rate: | ||
# The average per-second number of commit calls | ||
alias: confluent.$domain.stream.$attribute | ||
metric_type: gauge | ||
commit-total: | ||
# The total number of commit calls | ||
alias: confluent.$domain.stream.$attribute | ||
metric_type: gauge | ||
poll-latency-avg: | ||
# The average value of poll-latency. | ||
alias: confluent.$domain.stream.$attribute | ||
metric_type: gauge | ||
poll-latency-max: | ||
# The maximum value of poll-latency. | ||
alias: confluent.$domain.stream.$attribute | ||
metric_type: gauge | ||
poll-rate: | ||
# The average per-second number of poll calls | ||
alias: confluent.$domain.stream.$attribute | ||
metric_type: gauge | ||
poll-total: | ||
# The total number of poll calls | ||
alias: confluent.$domain.stream.$attribute | ||
metric_type: gauge | ||
process-latency-avg: | ||
# The average value of process-latency. | ||
alias: confluent.$domain.stream.$attribute | ||
metric_type: gauge | ||
process-latency-max: | ||
# The maximum value of process-latency. | ||
alias: confluent.$domain.stream.$attribute | ||
metric_type: gauge | ||
process-rate: | ||
# The average per-second number of process calls | ||
alias: confluent.$domain.stream.$attribute | ||
metric_type: gauge | ||
process-total: | ||
# The total number of process calls | ||
alias: confluent.$domain.stream.$attribute | ||
metric_type: gauge | ||
punctuate-latency-avg: | ||
# The average value of punctuate-latency. | ||
alias: confluent.$domain.stream.$attribute | ||
metric_type: gauge | ||
punctuate-latency-max: | ||
# The maximum value of punctuate-latency. | ||
alias: confluent.$domain.stream.$attribute | ||
metric_type: gauge | ||
punctuate-rate: | ||
# The average per-second number of punctuate calls | ||
alias: confluent.$domain.stream.$attribute | ||
metric_type: gauge | ||
punctuate-total: | ||
# The total number of punctuate calls | ||
alias: confluent.$domain.stream.$attribute | ||
metric_type: gauge | ||
skipped-records-rate: | ||
# The average per-second number of skipped records | ||
alias: confluent.$domain.stream.$attribute | ||
metric_type: gauge | ||
skipped-records-total: | ||
# The total number of skipped records | ||
alias: confluent.$domain.stream.$attribute | ||
metric_type: gauge | ||
task-closed-rate: | ||
# The average per-second number of closed tasks | ||
alias: confluent.$domain.stream.$attribute | ||
metric_type: gauge | ||
task-closed-total: | ||
# The total number of closed tasks | ||
alias: confluent.$domain.stream.$attribute | ||
metric_type: gauge | ||
task-created-rate: | ||
# The average per-second number of newly created tasks | ||
alias: confluent.$domain.stream.$attribute | ||
metric_type: gauge | ||
task-created-total: | ||
# The total number of newly created tasks | ||
alias: confluent.$domain.stream.$attribute | ||
metric_type: gauge | ||
|
||
# Components Metrics: | ||
# - Confluent Streams Thread: https://docs.confluent.io/legacy/platform/5.4.10/streams/monitoring.html#built-in-metrics | ||
# For backwards compatibility with at least version 5.4.10 of confluent platform | ||
- include: | ||
domain: kafka.streams | ||
bean_regex: kafka\.streams:type=stream-metrics,client-id=.* | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks I think your suggestion is more appropriate.