-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add assets for Cisco SD-WAN integration #17502
Conversation
The |
"tags": [ | ||
"integration:cisco-sdwan" | ||
], | ||
"description": "This monitor alerts when a Cisco SD-WAN device has rebooted more than 5 times within the last 10 minutes.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TCheruy, the description is a duplicate of the title and could also add more information on the impact of this as an issue. See the Best Practices in this documentation. Let me know if you have any questions on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @estherk15 👋🏻 Thanks! I tried to update the description following the best practises, let me know what you think 🙇
The |
Co-authored-by: Esther Kim <esther.kim@datadoghq.com>
cisco_sdwan/metadata.csv
Outdated
cisco_sdwan.bfd_session.status,gauge,,,,The status of the BFD session.,0,cisco_sdwan,, | ||
cisco_sdwan.control_connection.status,gauge,,,,The status of the control connection.,0,cisco_sdwan,, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non blocking nit. Not sure the values of these metrics, but if they're status metrics like 1 for up 0 for down, would it make sense to document these in the description?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point thanks, updated in c31a3b4
cisco_sdwan/metadata.csv
Outdated
cisco_sdwan.disk.usage,gauge,,percent,,The percentage of disk currently being used.,0,cisco_sdwan,, | ||
cisco_sdwan.interface.rx_bandwidth_usage,gauge,,percent,,The percent rate of used received bandwidth.,0,cisco_sdwan,, | ||
cisco_sdwan.interface.rx_bits,count,,bit,,The total number of bits received on the interface.,0,cisco_sdwan,, | ||
cisco_sdwan.interface.rx_bps,gauge,,bit,second,The inbound bandwidth rate in kilobit per second.,0,cisco_sdwan,, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the unit here bit or kilobit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 🫣 updated f5f8c80
cisco_sdwan.interface.rx_bps,gauge,,bit,second,The inbound bandwidth rate in kilobit per second.,0,cisco_sdwan,, | ||
cisco_sdwan.interface.rx_drops,count,,packet,,The number of inbound packets chosen to be discarded even though no errors had been detected to prevent them being deliverable to a higher-layer protocol.,0,cisco_sdwan,, | ||
cisco_sdwan.interface.rx_errors,count,,packet,,The number of inbound packets that contained errors preventing them from being deliverable to a higher-layer protocol.,0,cisco_sdwan,, | ||
cisco_sdwan.interface.speed,gauge,,,,The interface current speed in bits per second.,0,cisco_sdwan,, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this one be bit per second as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could, but setting it as bit per second makes the unit scale to Ki/Mi/Gi
units in the UI which is very weird for network interfaces (1Gb interface will be displayed as 0,9313 GiB), so we choose to not set units (similarly to SNMP)
cisco_sdwan/metadata.csv
Outdated
cisco_sdwan.interface.tx_drops,count,,packet,,The number of outbound packets chosen to be discarded even though no errors had been detected to prevent them being transmitted.,0,cisco_sdwan,, | ||
cisco_sdwan.interface.tx_errors,count,,packet,,The number of outbound packets that could not be transmitted because of errors.,0,cisco_sdwan,, | ||
cisco_sdwan.memory.usage,gauge,,percent,,The percentage of memory currently being used.,0,cisco_sdwan,, | ||
cisco_sdwan.omp_peer.status,gauge,,,,The status of the OMP Peer connection.,0,cisco_sdwan,, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the other status metrics
…o ThibaudC/cisco-sdwan-assets
The |
cisco_sdwan/manifest.json
Outdated
}, | ||
"oauth": {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}, | |
"oauth": {} | |
} |
This field isn't needed anymore. Non blocking
* Add assets for Cisco SD-WAN integration * Sync labeler conf * Fix manifest * Fix manifest (again) * Fix assets (again) * Add NDM as codeowners for Cisco SDWAN * Fix link * Improve monitor description * Network jitter is measured in ms * Shorter monitor descr * Caps * Add beta notice * Add beta notice * Fix typo * Update beta warning * Fix source name * Update monitors * Change reboot monitor threshold * Update dashboard * Update cisco_sdwan/assets/monitors/device_reboot.json Co-authored-by: Esther Kim <esther.kim@datadoghq.com> * Update status metrics description * Fix bps description * quotes * typo * typo * Group by device namespace in query value widgets * fix unreachable widget color * Remove oauth field from manifest --------- Co-authored-by: Esther Kim <esther.kim@datadoghq.com> 9aafcf2
What does this PR do?
Add assets for the Cisco SD-WAN integration
Includes:
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged