-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python3 support #2497
Add python3 support #2497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@@ -93,7 +89,7 @@ def check(self, instance): | |||
metric_count = 0 | |||
# Loop through and extract the numerical values | |||
for line in response.splitlines(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for line in r.iter_lines(decode_unicode=True):
@@ -93,7 +89,7 @@ def check(self, instance): | |||
metric_count = 0 | |||
# Loop through and extract the numerical values | |||
for line in response.splitlines(): | |||
values = line.split(': ') | |||
values = line.decode().split(': ') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then change this back
apache/tests/test_apache.py
Outdated
@@ -9,6 +9,8 @@ | |||
import time | |||
import logging | |||
|
|||
from six.moves import xrange |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just change everything to range
Codecov Report
@@ Coverage Diff @@
## master #2497 +/- ##
==========================================
+ Coverage 84.59% 92.71% +8.12%
==========================================
Files 622 4 -618
Lines 34675 151 -34524
Branches 4205 17 -4188
==========================================
- Hits 29332 140 -29192
+ Misses 4084 7 -4077
+ Partials 1259 4 -1255 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
What does this PR do?
Add support for Python3 for apache integration
Motivation
More python3 support
Review checklist
no-changelog
label attachedAdditional Notes
Anything else we should know when reviewing?