Add python3 support #2497
Merged
Add python3 support #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofek
requested changes
Nov 1, 2018
| @@ -93,7 +89,7 @@ def check(self, instance): | |||
| metric_count = 0 | |||
| # Loop through and extract the numerical values | |||
| for line in response.splitlines(): | |||
There was a problem hiding this comment.
for line in r.iter_lines(decode_unicode=True):
| @@ -93,7 +89,7 @@ def check(self, instance): | |||
| metric_count = 0 | |||
| # Loop through and extract the numerical values | |||
| for line in response.splitlines(): | |||
| values = line.split(': ') | |||
| values = line.decode().split(': ') | |||
apache/tests/test_apache.py
Outdated
| @@ -9,6 +9,8 @@ | |||
| import time | |||
| import logging | |||
|
|
|||
| from six.moves import xrange | |||
There was a problem hiding this comment.
just change everything to range
Codecov Report
@@ Coverage Diff @@
## master #2497 +/- ##
==========================================
+ Coverage 84.59% 92.71% +8.12%
==========================================
Files 622 4 -618
Lines 34675 151 -34524
Branches 4205 17 -4188
==========================================
- Hits 29332 140 -29192
+ Misses 4084 7 -4077
+ Partials 1259 4 -1255 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for Python3 for apache integration
Motivation
More python3 support
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?