Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds note about proxy password to docker-daemon docs #4194

Merged
merged 2 commits into from
Aug 15, 2019
Merged

adds note about proxy password to docker-daemon docs #4194

merged 2 commits into from
Aug 15, 2019

Conversation

cswatt
Copy link
Contributor

@cswatt cswatt commented Jul 24, 2019

What does this PR do?

Adds a note that PROXY_PASSWORD is required for passing in authentication passwords

Motivation

support request

@cswatt cswatt requested review from a team as code owners July 24, 2019 18:03
@ruthnaebeck
wording update
ff467ed 
Co-Authored-By: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com>
mfpierre
mfpierre reviewed Jul 26, 2019
View reviewed changes
Copy link
Contributor

@mfpierre mfpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to confirm, this is a doc update for the agent 5 right?

@hithwen hithwen requested a review from a team July 26, 2019 08:55
@ruthnaebeck
Copy link
Contributor

just to confirm, this is a doc update for the agent 5 right?

Correct. Information for Agent v6 starts on line 106.

@apigirl apigirl merged commit 213e392 into master Aug 15, 2019
@apigirl apigirl deleted the cswatt/proxy-pass branch August 15, 2019 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfpierre mfpierre mfpierre left review comments

@ruthnaebeck ruthnaebeck ruthnaebeck left review comments

@l0k0ms l0k0ms l0k0ms approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog documentation integration/docker_daemon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cswatt @ruthnaebeck @mfpierre @l0k0ms @ofek @apigirl