Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e to pdh_check #4393

Merged
merged 5 commits into from
Aug 23, 2019
Merged

Add e2e to pdh_check #4393

merged 5 commits into from
Aug 23, 2019

Conversation

ChristineTChen
Copy link
Contributor

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I believe you'll need a local interface for dd_environment like

yield common.CONFIG_INSTANCE, 'local'

pdh_check/tests/common.py Outdated Show resolved Hide resolved
pdh_check/tests/test_e2e.py Outdated Show resolved Hide resolved
pdh_check/tests/test_pdh_check.py Outdated Show resolved Hide resolved
pdh_check/tox.ini Outdated Show resolved Hide resolved
from datadog_test_libs.win.pdh_mocks import initialize_pdh_tests, pdh_mocks_fixture # noqa: F401


@pytest.mark.e2e
Copy link
Contributor

@hithwen hithwen Aug 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add skip if not windows, otherwise I get

ddev env test pdh_check -ne
Setting up environment `py27`... failed!
Stopping the environment...
The environment `py27` does not support this platform.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by #4398

@ofek
Copy link
Contributor

ofek commented Aug 20, 2019

  Running Checks
  ==============

    pdh_check (1.6.1)
    -----------------
      Instance ID: pdh_check:de68c6f531f4b15d [OK]
      Configuration Source: file:C:\ProgramData\Datadog\conf.d\pdh_check.d\pdh_check.yaml
      Total Runs: 1
      Metric Samples: Last Run: 2, Total: 2
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 0, Total: 0
      Average Execution Time : 214ms

ofek
ofek previously approved these changes Aug 20, 2019
pdh_check/tests/test_e2e.py Outdated Show resolved Hide resolved
@ofek ofek merged commit a47673e into master Aug 23, 2019
@ofek ofek deleted the cc/pdh_e2e branch August 23, 2019 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants