Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Airflow integration #5232

Merged
merged 28 commits into from
Jan 3, 2020
Merged

Add Airflow integration #5232

merged 28 commits into from
Jan 3, 2020

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Dec 17, 2019 •
edited
Loading

What does this PR do?

Depend on: DataDog/datadog-agent#4471

Add Airflow integration

Motivation

User request.

Additional Notes

Since Dogstatsd Mapper is not released yet. The Statsd/Dogstatsd Mapping can be tested against this version of the agent: DataDog/datadog-agent#4471

TODO:

  • Will explore adding e2e tests for statsd/dogstastsd metrics via another PR.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@AlexandreYang AlexandreYang requested review from a team as code owners December 17, 2019 15:16
@AlexandreYang AlexandreYang mentioned this pull request Dec 17, 2019
Closed
cswatt
cswatt previously requested changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@cswatt cswatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs review

airflow/README.md Outdated Show resolved Hide resolved
airflow/README.md Outdated Show resolved Hide resolved
airflow/README.md Outdated Show resolved Hide resolved
airflow/README.md Outdated Show resolved Hide resolved
airflow/README.md Outdated Show resolved Hide resolved
airflow/README.md Outdated Show resolved Hide resolved
airflow/README.md Outdated Show resolved Hide resolved
airflow/manifest.json Show resolved Hide resolved
airflow/tests/README.md Outdated Show resolved Hide resolved
airflow/tests/README.md Outdated Show resolved Hide resolved
AlexandreYang and others added 14 commits December 17, 2019 18:31
@AlexandreYang @cswatt
Update airflow/README.md
96f39e6 
Co-Authored-By: cswatt <cecilia.watt@datadoghq.com>
@AlexandreYang @cswatt
Update airflow/README.md
c5b3cd9 
Co-Authored-By: cswatt <cecilia.watt@datadoghq.com>
@AlexandreYang @cswatt
Update airflow/README.md
bb15997 
Co-Authored-By: cswatt <cecilia.watt@datadoghq.com>
@AlexandreYang @cswatt
Update airflow/README.md
e2dc7d0 
Co-Authored-By: cswatt <cecilia.watt@datadoghq.com>
@AlexandreYang @cswatt
Update airflow/README.md
5fd51a7 
Co-Authored-By: cswatt <cecilia.watt@datadoghq.com>
@AlexandreYang @cswatt
Update airflow/README.md
d71e438 
Co-Authored-By: cswatt <cecilia.watt@datadoghq.com>
@AlexandreYang @cswatt
Update airflow/README.md
4b0eba5 
Co-Authored-By: cswatt <cecilia.watt@datadoghq.com>
@AlexandreYang @cswatt
Update airflow/tests/README.md
8e648e0 
Co-Authored-By: cswatt <cecilia.watt@datadoghq.com>
@AlexandreYang @cswatt
Update airflow/tests/README.md
58d7332 
Co-Authored-By: cswatt <cecilia.watt@datadoghq.com>
@AlexandreYang @cswatt
Update airflow/README.md
f50178a 
Co-Authored-By: cswatt <cecilia.watt@datadoghq.com>
@AlexandreYang @cswatt
Update airflow/README.md
3a3fe37 
Co-Authored-By: cswatt <cecilia.watt@datadoghq.com>
@AlexandreYang @cswatt
Update airflow/README.md
e8349ce 
Co-Authored-By: cswatt <cecilia.watt@datadoghq.com>
@AlexandreYang @cswatt
Update airflow/README.md
72ec431 
Co-Authored-By: cswatt <cecilia.watt@datadoghq.com>
@AlexandreYang
Address doc review
9b8d420
@codecov
Copy link

codecov bot commented Dec 17, 2019 •
edited
Loading

Codecov Report

Merging #5232 into master will increase coverage by 6.59%.
The diff coverage is 92.92%.

Impacted Files Coverage Δ
airflow/datadog_checks/airflow/__about__.py 100% <100%> (ø)
airflow/datadog_checks/airflow/__init__.py 100% <100%> (ø)
airflow/tests/conftest.py 100% <100%> (ø)
airflow/tests/common.py 100% <100%> (ø)
airflow/tests/test_unit.py 100% <100%> (ø)
airflow/datadog_checks/airflow/airflow.py 86.48% <86.48%> (ø)
airflow/tests/test_integration_e2e.py 88.88% <88.88%> (ø)
...checks_dev/tests/plugin/test_environment_runner.py
riakcs/datadog_checks/riakcs/riakcs.py
oracle/tests/test_oracle.py
... and 854 more

@AlexandreYang AlexandreYang mentioned this pull request Dec 19, 2019
Merged
ofek
ofek requested changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

airflow/datadog_checks/airflow/airflow.py Outdated Show resolved Hide resolved
@AlexandreYang
Copy link
Member Author

@cswatt I accepted the suggestions, could you review again this PR. Thx.

ofek
ofek previously approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb!

@AlexandreYang AlexandreYang merged commit 07c69ba into master Jan 3, 2020
@dd-devflow dd-devflow bot deleted the alex/airflow_integration2 branch February 7, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

@cswatt cswatt Awaiting requested review from cswatt

@florimondmanca florimondmanca Awaiting requested review from florimondmanca

Assignees
No one assigned
Labels
integration/airflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexandreYang @cswatt @ofek @florimondmanca