Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hazelcast integration #6236

Merged
merged 6 commits into from
Apr 23, 2020
Merged

Add Hazelcast integration #6236

merged 6 commits into from
Apr 23, 2020

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Apr 2, 2020

No description provided.

@ofek ofek requested review from a team as code owners April 2, 2020 14:22
@ofek ofek force-pushed the ofek/hazelcast branch 2 times, most recently from 7003a17 to 6f4e1c4 Compare April 2, 2020 14:53
@codecov
Copy link

codecov bot commented Apr 2, 2020 •
edited
Loading

Codecov Report

Merging #6236 into master will increase coverage by 3.40%.
The diff coverage is 91.46%.

Impacted Files Coverage Δ
hazelcast/datadog_checks/hazelcast/check.py 76.66% <76.66%> (ø)
hazelcast/datadog_checks/hazelcast/__about__.py 100.00% <100.00%> (ø)
hazelcast/datadog_checks/hazelcast/__init__.py 100.00% <100.00%> (ø)
hazelcast/datadog_checks/hazelcast/utils.py 100.00% <100.00%> (ø)
hazelcast/tests/common.py 100.00% <100.00%> (ø)
hazelcast/tests/conftest.py 100.00% <100.00%> (ø)
hazelcast/tests/metrics.py 100.00% <100.00%> (ø)
hazelcast/tests/test_check.py 100.00% <100.00%> (ø)
hazelcast/tests/utils.py 100.00% <100.00%> (ø)
spark/tests/common.py
... and 848 more

@ofek ofek force-pushed the ofek/hazelcast branch 4 times, most recently from c51617c to c04ceab Compare April 7, 2020 16:35
@ofek ofek force-pushed the ofek/hazelcast branch 4 times, most recently from 0591aec to 94871d4 Compare April 15, 2020 01:51
sarah-witt
sarah-witt reviewed Apr 15, 2020
View reviewed changes
Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I had a few small comments

hazelcast/tox.ini Outdated Show resolved Hide resolved
hazelcast/setup.py Outdated Show resolved Hide resolved
hazelcast/metadata.csv Show resolved Hide resolved
hazelcast/datadog_checks/hazelcast/data/metrics.yaml Outdated Show resolved Hide resolved
hazelcast/datadog_checks/hazelcast/check.py Show resolved Hide resolved
@ruthnaebeck ruthnaebeck added the editorial review Waiting on a more in-depth review from a docs team editor label Apr 17, 2020
@ruthnaebeck ruthnaebeck requested a review from cswatt April 17, 2020 16:07
cswatt
cswatt requested changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@cswatt cswatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs styleguide

hazelcast/README.md Outdated Show resolved Hide resolved
hazelcast/README.md Outdated Show resolved Hide resolved
hazelcast/README.md Outdated Show resolved Hide resolved
hazelcast/README.md Outdated Show resolved Hide resolved
hazelcast/README.md Outdated Show resolved Hide resolved
hazelcast/README.md Outdated Show resolved Hide resolved
ofek and others added 6 commits April 23, 2020 11:21
sarah-witt
sarah-witt approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the check locally, LGTM!

@ofek ofek merged commit 3e8e878 into master Apr 23, 2020
@ofek ofek deleted the ofek/hazelcast branch April 23, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cswatt cswatt cswatt requested changes

@ChristineTChen ChristineTChen ChristineTChen approved these changes

@sarah-witt sarah-witt sarah-witt approved these changes

Assignees
No one assigned
Labels
dev/testing documentation editorial review Waiting on a more in-depth review from a docs team editor integration/hazelcast
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ofek @cswatt @ChristineTChen @sarah-witt @ruthnaebeck