-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config specs #6797
Add config specs #6797
Conversation
Codecov Report
|
# source: nginx | ||
# - type: file | ||
# path: /var/log/nginx/access.log | ||
# source: nginx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing service?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the point it is should be defined in the instance or init so it gets applied to metrics and logs. Having it here is deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove the service
line from the template?
integrations-core/datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/logs.yaml
Line 10 in 19b4c39
service - required - The name of the service that generates the log. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's still a valid config but the unified one should be used instead
# source: nginx | ||
# - type: file | ||
# path: /var/log/nginx/error.log | ||
# source: nginx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same in this example
No description provided.