-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version metadata collection #7972
Conversation
9fc4305
to
9083744
Compare
Codecov Report
|
@@ -141,10 +152,6 @@ def check(self, instance): | |||
func = funcs[metric_type] | |||
func(name, value, tags) | |||
|
|||
# for vts and plus versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's vts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nginx module for virtual traffic (https://github.com/vozlt/nginx-module-vts)
|
Co-authored-by: Julia <611228+hithwen@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
What does this PR do?
Fix how we submit the nginx version metadata.
Send it only when the configuration enables itSend the correct nginx version:
version
from the/nginx
endpoint of the PLUS API https://docs.nginx.com/nginx/admin-guide/monitoring/live-activity-monitoring/#getting-statistics-with-the-api, that it different from the API version, also namedversion
in a different endpoint.We explicitly get the version from the correct endpoint, so it's not override in the metric loop.
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached