Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Snowflake connector proxy configuration and support proxy connection options #8181

Merged
merged 12 commits into from
Dec 11, 2020

Conversation

ChristineTChen
Copy link
Contributor

@ChristineTChen ChristineTChen commented Dec 10, 2020

What does this PR do?

Documents environment variable approach: https://docs.snowflake.com/en/user-guide/python-connector-example.html#using-a-proxy-server

Supports connection proxy params: https://github.com/snowflakedb/snowflake-connector-python/blob/master/src/snowflake/connector/proxy.py#L10

Fixes #8019

Motivation

FR

The previous wrapper workaround is error prone. This PR uses the Snowflake Connector method (originally avoided because it automatically sets proxy env vars as well).

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ChristineTChen ChristineTChen requested review from a team as code owners December 10, 2020 16:02
@ChristineTChen ChristineTChen changed the title Fix proxy configuration Document Snowflake connector proxy configuration and support proxy connection options Dec 10, 2020
snowflake/README.md Outdated Show resolved Hide resolved
snowflake/datadog_checks/snowflake/check.py Show resolved Hide resolved
coignetp
coignetp previously approved these changes Dec 11, 2020
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs review

snowflake/README.md Outdated Show resolved Hide resolved
snowflake/README.md Show resolved Hide resolved
snowflake/README.md Outdated Show resolved Hide resolved
snowflake/README.md Outdated Show resolved Hide resolved
snowflake/README.md Outdated Show resolved Hide resolved
Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com>
ChristineTChen and others added 3 commits December 11, 2020 12:03
Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com>
Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com>
Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com>
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs

@ChristineTChen ChristineTChen merged commit d32f5f1 into master Dec 11, 2020
@ChristineTChen ChristineTChen deleted the cc/fix-proxy branch December 11, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants